Removing selected text from a string

[User 2028214]

I'm trying to compare words entered in a textbox with a selection of stop-words, removing any stopwords that are found. Here's a snippet. string text = this.textBox1.Text; if(RemoveMe(s)) { int startIndex = text.IndexOf(s); int endIndex = s.Length-1; text = text.Remove(startIndex, startIndex+endIndex); } Problem is, every now and then startIndex get a value of -1... Kinda stumped here, what am I doing wrong?

[Snowblind37]

When the iterator reaches the end it sets itself at -1. You need to re-set it at 0 after each string that you are finished with

[Lost User]

int startIndex = text.IndexOf(s); int endIndex = s.Length-1; text = text.Remove(startIndex, s.Length); works fine for me. Remember the second parameter to "Remove" number of chars to delete, not the endIndex Can you give us some example strings you are trying to find in "text"?

[Guffa]

The IndexOf method returns -1 when the string is not found. You have to check if the word is even present in the string before you try to remove it. Also, your method is only removing the first occurance of the word. Why don't you use a Replace instead? Or why not use a regular expression? Then you can match the word boundaries, so that you don't accidentally remove a part of a word that matches another word. --- b { font-weight: normal; }

[User 2028214]

hehe...thanks, would have had to be something that simple... I'm removing common words such as 'at' 'the' 'this' 'is' 'of' etc...

[User 2028214]

I'd use regex but they always leaves me scratching my head somewhat puzzled :) Thanks for the suggestions, off to try it in the code now

[Lost User]

They're simple, really :) Just take yourself a week and learn it, it's worth a lot when dealing with strings.

[User 2028214]

yeah, I've kinda put it off long enough :) thanks