silly exception question
-
I have various classes in my data access layer that are talking with the database. for all the methods I pass in the connection ref. Now if the connection object is being passed in from the outside and within the da classes there is a try catch block is it necessary to enclose the methods call within a try catch finally block to close the connection in the finally? You would think that any exceptions that are thrown will be caught internally and there for the connection will still be able to be close even if it is not in a finally block in the outer function. private sub formMethod() ... conn.open 'not sure if this has to be in the t/c block someDAMethod() conn.close 'connection should still be closed, right? end sub ..in da module public sub someDAMethod() try ... catch sqlEx as sqlException end try end sub I guess you could say that you are only catching sqlExceptions so you still have to do the other catch, but you could always catch the base exception, as long as you know that the update didn't go through properly. I am still new to dealing with exceptions properly, so if it is a dumass question sorry. I am just curious.
-
I have various classes in my data access layer that are talking with the database. for all the methods I pass in the connection ref. Now if the connection object is being passed in from the outside and within the da classes there is a try catch block is it necessary to enclose the methods call within a try catch finally block to close the connection in the finally? You would think that any exceptions that are thrown will be caught internally and there for the connection will still be able to be close even if it is not in a finally block in the outer function. private sub formMethod() ... conn.open 'not sure if this has to be in the t/c block someDAMethod() conn.close 'connection should still be closed, right? end sub ..in da module public sub someDAMethod() try ... catch sqlEx as sqlException end try end sub I guess you could say that you are only catching sqlExceptions so you still have to do the other catch, but you could always catch the base exception, as long as you know that the update didn't go through properly. I am still new to dealing with exceptions properly, so if it is a dumass question sorry. I am just curious.
kowplunk wrote: conn.open 'not sure if this has to be in the t/c block someDAMethod() conn.close 'connection should still be closed, right? Actually, your connection code should be in your
someDAmethodcode, not on your form. This way, your connection is handled where it belongs, in your Data Access method. In there, your connection can be closed in the Try/Catch/Finally block (inside Finally). It would go something like this:Try
' setup our database connection.
Dim conn As SqlConnection = GetConnection()
Dim comm As New SqlCommand("blaa blaa blaa")
Dim param As New SqlParameter(blaa blaa blaa)
.
.
(more code to setup and execute our data access)
Catch ex As Exception
' Code to log the exception, throw a custom exception, or whatever to handle a failed request.
Finally
' Check to see if the connection is anything but closed! Don't check for Open!
If conn.State <> ConnectionState.Closed Then
conn.Close()
End If
comm = Nothing
conn.Dispose()
End TryRageInTheMachine9532 "...a pungent, ghastly, stinky piece of cheese!" -- The Roaming Gnome
-
kowplunk wrote: conn.open 'not sure if this has to be in the t/c block someDAMethod() conn.close 'connection should still be closed, right? Actually, your connection code should be in your
someDAmethodcode, not on your form. This way, your connection is handled where it belongs, in your Data Access method. In there, your connection can be closed in the Try/Catch/Finally block (inside Finally). It would go something like this:Try
' setup our database connection.
Dim conn As SqlConnection = GetConnection()
Dim comm As New SqlCommand("blaa blaa blaa")
Dim param As New SqlParameter(blaa blaa blaa)
.
.
(more code to setup and execute our data access)
Catch ex As Exception
' Code to log the exception, throw a custom exception, or whatever to handle a failed request.
Finally
' Check to see if the connection is anything but closed! Don't check for Open!
If conn.State <> ConnectionState.Closed Then
conn.Close()
End If
comm = Nothing
conn.Dispose()
End TryRageInTheMachine9532 "...a pungent, ghastly, stinky piece of cheese!" -- The Roaming Gnome