Why doesn't this work?

[Nemok]

HICON hIcon; LPBYTE lpBuffer; hIcon=dlg.GetIconHandle(); lpBuffer=(LPBYTE)::GlobalLock(hIcon); HANDLE hUpd=BeginUpdateResource("D:\\n.exe",0); UpdateResource((HMODULE)hUpd, RT_ICON,MAKEINTRESOURCE(1), MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT), (LPBYTE)lpBuffer, GlobalSize(hIcon)); EndUpdateResource(hUpd, FALSE); GlobalUnlock(lpBuffer); I'm using this code to take the icon from an exe and replace the icon in another exe, but it doesn't work. Every time lpBuffer is empty after GlobalLock. the hIcon handle is retrieved by ExtractIcon(); What am I doing wrong? Please help!

[Jorgen Sigvardsson]

I doubt you can do lpBuffer=(LPBYTE)::GlobalLock(hIcon);. See this MSDN article[^] for more information on icons and resources. It links to a program written in C which has some code you can look at too. Please note that the structs in the article are wrong. Look at the code in the linked project instead. I believe you will have to fill out an entire ICONDIR, as icons are stored that way (an icon can contain several images). Then the appropriate number of ICONDIRENTRYs and ICONIMAGEs. That's what's supposed to be inside the resource part. But you are talking about replacing the icon in one exe from another one. I believe you can do the copy without too much work. Just grab a pointer to the icon resource in the source exe, and use it to update the icon entry in the other exe. I think that should work. The linked project has all the details. Good luck :) -- Arigato gozaimashida!

[Nemok]

Well this is my problem: How can I grab a pointer from the resource (HICON)??? I was trying to do just that by using GlobalLock(). Do you know any other way to do this???

[Jorgen Sigvardsson]

Read the MSDN article. It'll tell you what you can do with an HICON (hint: GetIconInfo() and build resource data from that) -- Arigato gozaimashida!