Please help me CPP

[bluehai]

Hello ! I have created some classes for Huffman Tree but when I call CreateNode function it appears an error about CharArray string. What is this error ? Who can help me about this problem ? Thank you. class Node { friend class HuffmanTree; private: char *CharArray; unsigned long Frequency; Node *pLeft; Node *pRight; …. } class HuffmanTree { private: Node *pRoot; public: HuffmanTree(); ~HuffmanTree(); Node *CreateNode(char *CharArray, unsigned long Frequency); …. } Node *HuffmanTree::CreateNode(char *CharArray, unsigned long Frequency) { Node *NewNode = new Node(CharArray, Frequency); NewNode->pLeft = NULL; NewNode->pRight = NULL; return NewNode; } Node::Node(char *CharArray, unsigned long Frequency) { int CharArrayLen = strlen(CharArray)+1; this->CharArray = NULL; // delete this->CharArray; this->CharArray = new char(sizeof(char)*CharArrayLen); strcpy(this->CharArray,CharArray); this->Frequency = Frequency; pLeft = NULL; pRight = NULL; } :)

[Anonymous]

Hello, Your code seems OK except that (IMHO): - you removed trailling ';' at the end of class declarations - you do not check for CharArray consistency (e.g. != NULL) - you should use a more structured syntax (as m_ prefix for data members) - I would recommand the use of new char[] instead of new char(). It would imply the use of delete [] when destroying the memory block. You should be more specific about your error. Do you receive an exception ?

[bluehai]

Hello, Thanks for your response. I have updated my code and they run well. I will ask you when i have new errors. I don't have any exception currently. Special thanks to you. Best regards, Hai