SearchPath API fails in UNICODE debug build

[Vinaya]

Hi, My application calls the SearchPath() API in a method which gets the version info of a file. On execution, the UNICODE debug version of the application always crashes. The error shown is 'Unhandled exception in MyAppl.exe (NTDLL.DLL): 0xC0000005: Access Violation'. The MBCS/UNICODE Release build of the application works fine and also the MBCS debug build. DI_STATUS getFileVersionInfo(TCHAR * FileName) { TCHAR pathBuffer[MAX_PATH]; struct VS_FIXEDFILEINFO { DWORD dwSignature; DWORD dwStrucVersion; DWORD dwFileVersionMS; DWORD dwFileVersionLS; DWORD dwProductVersionMS; DWORD dwProductVersionLS; DWORD dwFileFlagsMask; DWORD dwFileFlags; DWORD dwFileOS; DWORD dwFileType; DWORD dwFileSubtype; DWORD dwFileDateMS; DWORD dwFileDateLS; } *lpFixedFileInfo; TCHAR fileInfoBuffer[2048]; UINT32 VersionInfoSize; if (SearchPath(NULL, FileName, NULL, sizeof(pathBuffer), pathBuffer, NULL) > 0) { LogMsg(_T(" SearchPath: %s\n"), pathBuffer); } else { return(ERR_FILE_NOT_FOUND); } if ((VersionInfoSize = GetFileVersionInfoSize(FileName, 0)) > 0) { if (GetFileVersionInfo(FileName, NULL, VersionInfoSize, fileInfoBuffer) > 0) { VerQueryValue(fileInfoBuffer, TEXT("\\"), (LPVOID *)&lpFixedFileInfo, &VersionInfoSize); LogMsg(_T(" FileName : %s Version: %d.%d.%d.%d\n"),FileName, HIWORD(lpFixedFileInfo->dwFileVersionMS), LOWORD(lpFixedFileInfo->dwFileVersionMS), HIWORD(lpFixedFileInfo->dwFileVersionLS), LOWORD(lpFixedFileInfo->dwFileVersionLS)); } else { return(DI_ERR_FILE_NOT_FOUND); } } else { return(ERR_FILE_NOT_FOUND); } return(DI_SUCCESS); } The function call is

TCHAR tmp[1024];
GetModuleFileName(NULL, tmp, sizeof(tmp));
getFileVersionInfo(tmp);

Am I missing out something here? I have Win2K OS. Please help. Thanks, Vini

[Ryan Binns]

Vinaya wrote: GetModuleFileName(NULL, tmp, sizeof(tmp)); The third parameter is the number of characters, not the size of the buffer in bytes. You'll need to pass in 1024 to indicate there are 1024 characters (or sizeof(tmp)/sizeo(TCHAR)) Vinaya wrote: SearchPath(NULL, FileName, NULL, sizeof(pathBuffer), pathBuffer, NULL) Ditto for the fourth parameter here.

Ryan

"Punctuality is only a virtue for those who aren't smart enough to think of good excuses for being late" John Nichol "Point Of Impact"

[RChin]

Vinaya wrote: if (SearchPath(NULL, FileName, NULL, sizeof(pathBuffer), pathBuffer, NULL) > 0) Your exception is basically caused by the sizeof() input parameter of the function. This parameter required the number of characters that your string buffer holds. But the sizeof() function returns the number of bytes within the array. With a UNICODE program, each character occupies two bytes, so will therefore return twice the number required, resulting in a memory exception. Try: if (SearchPath(NULL, FileName, NULL, sizeof(pathBuffer)/sizeof(TCHAR), pathBuffer, NULL) > 0)

---

I Dream of Absolute Zero

[Vinaya]

Thanks a lot. :rose: That solved the problem. :) Vini