How to dispose a class
-
If the WriteToDoc class has a dispose method associated with it, you could do the following: using (WriteToDoc writeToDoc = new WriteToDoc()) { } Dispose is automatically called when the execution block finishes. If you don't have a Dispose method, just call writeToDoc = null to set it to a null value. Note that this isn't necessary because the garbage collector will pick it up some time after the variable goes out of scope.
the last thing I want to see is some pasty-faced geek with skin so pale that it's almost translucent trying to bump parts with a partner - John Simmons / outlaw programmer
Deja View - the feeling that you've seen this post before.Hi guys, I just implemented these two methods: public void Dispose() { Dispose(true); // This object will be cleaned up by the Dispose method. // Therefore, you should call GC.SupressFinalize to // take this object off the finalization queue // and prevent finalization code for this object // from executing a second time. GC.SuppressFinalize(this); } private void Dispose(bool disposing) { // Check to see if Dispose has already been called. if (!this.disposed) { // If disposing equals true, dispose all managed // and unmanaged resources. if (disposing) { // Dispose managed resources. this.Dispose(); } // Call the appropriate methods to clean up // unmanaged resources here. // If disposing is false, // only the following code is executed. //CloseHandle(handle); //handle = IntPtr.Zero; // Note disposing has been done. disposed = true; } } And in my Form i call the writeToDoc.Dispose() method like that. I copied it from msdn library. Should it work like that too? Thanks in advance!
-
Hi guys, I just implemented these two methods: public void Dispose() { Dispose(true); // This object will be cleaned up by the Dispose method. // Therefore, you should call GC.SupressFinalize to // take this object off the finalization queue // and prevent finalization code for this object // from executing a second time. GC.SuppressFinalize(this); } private void Dispose(bool disposing) { // Check to see if Dispose has already been called. if (!this.disposed) { // If disposing equals true, dispose all managed // and unmanaged resources. if (disposing) { // Dispose managed resources. this.Dispose(); } // Call the appropriate methods to clean up // unmanaged resources here. // If disposing is false, // only the following code is executed. //CloseHandle(handle); //handle = IntPtr.Zero; // Note disposing has been done. disposed = true; } } And in my Form i call the writeToDoc.Dispose() method like that. I copied it from msdn library. Should it work like that too? Thanks in advance!
-
You should implement the finalizer also:
~WriteToDoc() {
Dispose(true);
}This calls the Dispose method in case the coder fails to call it.
--- Year happy = new Year(2007);
-
If the WriteToDoc class has a dispose method associated with it, you could do the following: using (WriteToDoc writeToDoc = new WriteToDoc()) { } Dispose is automatically called when the execution block finishes. If you don't have a Dispose method, just call writeToDoc = null to set it to a null value. Note that this isn't necessary because the garbage collector will pick it up some time after the variable goes out of scope.
the last thing I want to see is some pasty-faced geek with skin so pale that it's almost translucent trying to bump parts with a partner - John Simmons / outlaw programmer
Deja View - the feeling that you've seen this post before.Having a Dispose method isn't enough by itself. Your class must implment IDisposable.
only two letters away from being an asset
-
Having a Dispose method isn't enough by itself. Your class must implment IDisposable.
only two letters away from being an asset
Mark, ... just looking at the footer of your messages ... Would there be any connection between KIA and "killed in action" ? :-)
SkyWalker
-
Having a Dispose method isn't enough by itself. Your class must implment IDisposable.
only two letters away from being an asset
Mark Nischalke wrote:
Having a Dispose method isn't enough by itself. Your class must implment IDisposable.
Well, "must" is not really true. Adding the IDisposable interface to the list of implemented interfaces for the class doesn't really make any difference. It doesn't change the implementation of the class in any way. Using the Dispose method works just fine without the interface, only you can't use the class in a
usingblock as that requires the IDisposable interface. It's just that the IDisposable interface is intended for this, so if you want to add disposability to a class in a well behaved way, you should implement the IDisposable interface. Just to be clear. :)--- Year happy = new Year(2007);
-
Mark Nischalke wrote:
Having a Dispose method isn't enough by itself. Your class must implment IDisposable.
Well, "must" is not really true. Adding the IDisposable interface to the list of implemented interfaces for the class doesn't really make any difference. It doesn't change the implementation of the class in any way. Using the Dispose method works just fine without the interface, only you can't use the class in a
usingblock as that requires the IDisposable interface. It's just that the IDisposable interface is intended for this, so if you want to add disposability to a class in a well behaved way, you should implement the IDisposable interface. Just to be clear. :)--- Year happy = new Year(2007);
Guffa wrote:
Well, "must" is not really true...only you can't use the class in a using block as that requires the IDisposable interface.
The post I was responding to makes use of
usingso in that context, yes it is a must. If the WriteToDoc class has a dispose method associated with it, you could do the following: using (WriteToDoc writeToDoc = new WriteToDoc()) { }
only two letters away from being an asset
-
You should implement the finalizer also:
~WriteToDoc() {
Dispose(true);
}This calls the Dispose method in case the coder fails to call it.
--- Year happy = new Year(2007);
For a class that is this simple, you really don't need a finalizer. Writing a proper finalizer is generally a non-trivial task as there are certain rules that need to be followed. Beyond that, adding a finalizer causes the runtime to place the object in the finalization queue when it is instantiated, which causes the garbage collection system additional work. The finalizer will cause the Dispose method to be called if the coder forgets to call it, but that safety net usually comes at a higher cost than it's worth. For a different view on how to implement the Disposable pattern, check out this article: http://www.codeproject.com/useritems/idisposable.asp[^]
----------------------------- In just two days, tomorrow will be yesterday.
-
Having a Dispose method isn't enough by itself. Your class must implment IDisposable.
only two letters away from being an asset
The recommended way is to implement the IDisposable interface, but it certainly isn't required. Implementing the interface does allow the compiler to understand certain other conveniences, such as the using clause, but it doesn't cause any different compile-time or run-time behavior. It does, however, provide a valuable "clue" to anyone implementing the class that it has certain characteristics and expected behaviors. For more information on implementing Dispose, check out the following article. It goes in to more detail than the MSDN docs and pulls together the information from some of the people that actually wrote the GC system. http://www.codeproject.com/useritems/idisposable.asp[^]
----------------------------- In just two days, tomorrow will be yesterday.
-
Guffa wrote:
Well, "must" is not really true...only you can't use the class in a using block as that requires the IDisposable interface.
The post I was responding to makes use of
usingso in that context, yes it is a must. If the WriteToDoc class has a dispose method associated with it, you could do the following: using (WriteToDoc writeToDoc = new WriteToDoc()) { }
only two letters away from being an asset
Mark Nischalke wrote:
The post I was responding to makes use of using so in that context, yes it is a must. If the WriteToDoc class has a dispose method associated with it, you could do the following: using (WriteToDoc writeToDoc = new WriteToDoc()) { }
Correct, but in my original post I was responding to his question to call Dispose, which I thought (possibly erroneously) implied that he had implemented the IDispose interface.
the last thing I want to see is some pasty-faced geek with skin so pale that it's almost translucent trying to bump parts with a partner - John Simmons / outlaw programmer
Deja View - the feeling that you've seen this post before.
