Does this ATL Code Leak memory?

[Killer3]

STDMETHODIMP CTryoutATL::ConcatenateString(long count, BSTR *ReturnVal) { // TODO: Add your implementation code here BSTR outputTempString; BSTR outputString = new OLECHAR[30]; BSTR tempString = new OLECHAR[30]; swprintf(tempString,L"The KILLER "); BOOL bFirstTime = TRUE; for(long i =1; i < count ; i++) { BSTR tempString = new OLECHAR[30]; swprintf(tempString,L"This Ilanthendral kills %ld\n",i); outputTempString = new OLECHAR[30*i]; if(!bFirstTime) { wcscpy(outputTempString,outputString); wcscat(outputTempString,tempString); } else wcscpy(outputTempString,tempString); bFirstTime = FALSE; delete [] outputString; delete [] tempString; outputString = outputTempString; } *ReturnVal = outputTempString; return S_OK; }

for thendral

[Stuart Dootson]

1. The outer tempString will always leak one allocation.
2. If count == 0, outputString will not be deallocated
3. If count == 0, outputTempString will never be assigned to, so you'll return an indeterminate value

In addition - these aren't valid BSTRs. BSTRs contain more information than just raw characters (for example, string length), so should always be allocated using SysAllocString, SysAllocStringByteLen or SysAllocStringLen and deallocated using SysFreeString. I'd suggest you read the documentation for CComBSTR or _bstr_t and then use one of them rather than BSTR. These BSTR wrappers make BSTR management much easier. BSTR management much easier.