About + operator for string

[TALHAKOSEN]

Hi all SELECT @vSQL = 'INSERT INTO #rapor(Id) VALUES('' '+ @X + ' '')' i want below FOR EX INSERT INTO #rapor(Id) VALUES('5') BUT SQL SAYS Msg 102, Level 15, State 1, Line 1 Incorrect syntax near ' VALUES('. Msg 105, Level 15, State 1, Line 1 Unclosed quotation mark after the character string ')'. Msg 102, Level 15, State 1, Line 1 Incorrect syntax near ' VALUES('. like that pls help Thanks ...

Sampiyon FENERBAHCE

[Ashfield]

Odd, it works for me - although you get null in @vSQL if @X is null. You will get a space each side of you value though.

Bob Ashfield Consultants Ltd

[TALHAKOSEN]

ITS THE CODE BELOW DECLARE ankcev_cursor SCROLL CURSOR FOR SELECT KULLANICINO FROM AnketCevap WHERE ANKETID='7' OPEN ankcev_cursor declare @vSQL varchar(1000), @numrows int DECLARE @SNO INT; DECLARE @KNO INT; DECLARE @SONUC VARCHAR(10); SET @SNO = 10; WHILE @SNO < 83 BEGIN FETCH NEXT FROM ankcev_cursor INTO @KNO WHILE @@FETCH_STATUS = 0 BEGIN SET @SONUC=(SELECT CEVAPSIK FROM ANKETCEVAP WHERE ANKETID='7' AND KULLANICINO = @KNO AND SORUNO=@SNO) SELECT @vSQL = 'INSERT INTO #rapor(S'+ convert(varchar, @SNO) + ')'' VALUES('' '+ @sonuc+ ' '')' Execute (@vSQL) FETCH NEXT FROM ankcev_cursor INTO @KNO END SET @SNO=@SNO+1; END CLOSE ankcev_cursor DEALLOCATE ankcev_cursor

Sampiyon FENERBAHCE

[Ashfield]

It wasn't complaining about the select, it was the resuklt when you tried to exec it. You had too many quotes try this

SELECT @vSQL = 'INSERT INTO #rapor(S'+ convert(varchar, @SNO) + ') VALUES('' '+ @sonuc+ ' '')'

Your original selct gave this (I set @sonuc to f) : INSERT INTO #rapor(S10)' VALUES(' f ') rather than INSERT INTO #rapor(S10) VALUES(' f ')

Bob Ashfield Consultants Ltd

[TALHAKOSEN]

thanx for helping bob i saw now that i had a mistake this is working below, SELECT @vSQL = 'INSERT INTO #rapor(S'+ convert(varchar, @SNO) + ') VALUES('''+convert(varchar, @SONUC) +''')' an by the way how can i see what value in my variable i mean like c# Console.WriteLine(@vSQL) and it writes INSERT INTO #rapor(S10) VALUES(' f ') how can do with tsql thanks again

Sampiyon FENERBAHCE

[Ashfield]

TALHAKOSEN wrote:

thanx for helping bob

No problem, always happy to help.

TALHAKOSEN wrote:

how can i see what value in my variable

If running in query analyser

print @vSQL

or simply

select @vSQL

Bob Ashfield Consultants Ltd

[TALHAKOSEN]

declare @vSQL varchar(1000) DECLARE @SNO INT; DECLARE @SNO2 INT; DECLARE @KNO INT; DECLARE @SONUC VARCHAR(10); SET @SNO = 10; SET @SNO2 = 10; WHILE @SNO < 83 BEGIN DECLARE ankcev_cursor SCROLL CURSOR FOR SELECT KULLANICINO FROM AnketCevap WHERE ANKETID='7' OPEN ankcev_cursor FETCH NEXT FROM ankcev_cursor INTO @KNO WHILE @@FETCH_STATUS = 0 BEGIN --SELECT CEVAPSIK FROM ANKETCEVAP WHERE ANKETID='7' AND KULLANICINO = @KNO AND SORUNO=@SNO SET @SONUC=(SELECT CEVAPSIK FROM ANKETCEVAP WHERE ANKETID='7' AND KULLANICINO = @KNO AND SORUNO=@SNO) SELECT @vSQL = 'UPDATE #rapor SET S'+ convert(varchar, @SNO)+'='''+ convert(varchar, @SONUC)+''' where ID='''+ convert(varchar, @KNO) + '''' Execute (@vSQL) FETCH NEXT FROM ankcev_cursor INTO @KNO END CLOSE ankcev_cursor DEALLOCATE ankcev_cursor SET @SNO = @SNO+1; END PRINT @vSQL PRINT @SNO ------ALWAYS WRITE S10 why stay same value ????

Sampiyon FENERBAHCE

[Ashfield]

Don't know. I took your code and commented out all the bits that wouldn't run and it printed 83.

declare @vSQL varchar(1000)
DECLARE @SNO INT;
DECLARE @SNO2 INT;
DECLARE @KNO INT;
DECLARE @SONUC VARCHAR(10);
SET @SNO = 10;
SET @SNO2 = 10;

WHILE @SNO < 83
BEGIN
-- DECLARE ankcev_cursor SCROLL CURSOR FOR
-- SELECT KULLANICINO FROM AnketCevap WHERE ANKETID='7'
-- OPEN ankcev_cursor

-- FETCH NEXT FROM ankcev_cursor INTO @KNO

-- WHILE @@FETCH_STATUS = 0
-- BEGIN
-- --SELECT CEVAPSIK FROM ANKETCEVAP WHERE ANKETID='7' AND KULLANICINO = @KNO AND SORUNO=@SNO
-- SET @SONUC=(SELECT CEVAPSIK FROM ANKETCEVAP WHERE ANKETID='7' AND KULLANICINO = @KNO AND SORUNO=@SNO)
-- SELECT @vSQL = 'UPDATE #rapor SET S'+ convert(varchar, @SNO)+'='''+ convert(varchar, @SONUC)+''' where ID='''+ convert(varchar, @KNO) + ''''
-- Execute (@vSQL)
-- FETCH NEXT FROM ankcev_cursor INTO @KNO
-- END

-- CLOSE ankcev_cursor
-- DEALLOCATE ankcev_cursor
SET @SNO = @SNO+1;
END

PRINT @vSQL
PRINT @SNO ------ALWAYS WRITE S10 why stay same value ????

Bob Ashfield Consultants Ltd

[TALHAKOSEN]

ok ok i see now my mistake SELECT KULLANICINO FROM AnketCevap WHERE ANKETID='7' and i forget to add this so it takes to long times to return back )) anyway thanks for your patience on me )) thank a lot...

Sampiyon FENERBAHCE

[Ashfield]

Thats OK

Bob Ashfield Consultants Ltd