Removing else in this statements How?

[monsieur_jj]

Hi all, I had my code reviewed and I had a comment that its best to remove the else in this statements:

LRESULT CMainDlg::OnInstall(WORD, WORD wID, HWND, BOOL& )
{
string LaunchInstaller;
string InstallFolder;
InstallClass installclass;

TCHAR tcItemText\[MAXBYTES\];

if(UpdateList.GetItemText(Select, tcItemText, MAXBYTES))
{
InstallFolder = tcItemText;
LaunchInstaller = installclass.ConstructInstallerKey(IDS\_MANAGEKEY, InstallFolder);
	if (installclass.InstallUpdate(LaunchInstaller.c\_str())) 
	{
		return 0;
	}
	else 
	{
		LaunchInstaller = installclass.ConstructInstallerKey(IDS\_RERITEKEY, InstallFolder);
		if (installclass.InstallUpdate(LaunchInstaller.c\_str())) 
		{
			return 0;
		}
		else
		{
			LaunchInstaller = installclass.ConstructInstallerKey(IDS\_RERITEASIANKEY, InstallFolder);
			if (installclass.InstallUpdate(LaunchInstaller.c\_str())) 
			{
				return 0;
			}
			else
			{
			LaunchInstaller = installclass.ConstructInstallerKey(IDS\_RERITECHINAKEY, InstallFolder);
				if (installclass.InstallUpdate(LaunchInstaller.c\_str())) 
				{
					return 0;
				}
			}
		}
	}
}
else
{
MessageBox ( \_T("Please choose an item to install"), \_T("Redmap Update Manager"), MB\_ICONWARNING );
}
return 0;

}

Any suggestions on how the code should look like? Thanks, Jayjay

[David Crow]

LRESULT CMainDlg::OnInstall(WORD, WORD wID, HWND, BOOL& )
{
string LaunchInstaller;
string InstallFolder;
InstallClass installclass;
TCHAR tcItemText[MAXBYTES];

if(UpdateList.GetItemText(Select, tcItemText, MAXBYTES))
{
    InstallFolder = tcItemText;

    LaunchInstaller = installclass.ConstructInstallerKey(IDS\_MANAGEKEY, InstallFolder);
    if (installclass.InstallUpdate(LaunchInstaller.c\_str())) 
        return 0;

    LaunchInstaller = installclass.ConstructInstallerKey(IDS\_RERITEKEY, InstallFolder);
    if (installclass.InstallUpdate(LaunchInstaller.c\_str())) 
        return 0;

    LaunchInstaller = installclass.ConstructInstallerKey(IDS\_RERITEASIANKEY, InstallFolder);
    if (installclass.InstallUpdate(LaunchInstaller.c\_str())) 
        return 0;

    LaunchInstaller = installclass.ConstructInstallerKey(IDS\_RERITECHINAKEY, InstallFolder);
    if (installclass.InstallUpdate(LaunchInstaller.c\_str())) 
        return 0;
}
else
{
    MessageBox(\_T("Please choose an item to install"), \_T("Redmap Update Manager"), MB\_ICONWARNING);
}

return 0;

}

"Love people and use things, not love things and use people." - Unknown

"The brick walls are there for a reason...to stop the people who don't want it badly enough." - Randy Pausch