Transfer a txt file

[bar3000]

Hi, I am trying to transfer a txt file by loading it and saving it with a save file dialog.

SaveFileDialog saveDialog = new SaveFileDialog();
saveDialog.AddExtension = true;
saveDialog.FileName = "Checkers Game";
saveDialog.InitialDirectory = @"C:\Documents and Settings\Bar\My Documents\";
saveDialog.OverwritePrompt = true;
saveDialog.Title = "Save game";
saveDialog.ValidateNames = true;
saveDialog.ShowDialog();
if (saveDialog.FileName != "")
{
writer.Close();
file.Close();
FileStream fs = new FileStream(@"C:\Documents and Settings\Bar\My Documents\savegame.txt", FileMode.Open);
fs = (System.IO.FileStream)saveDialog.OpenFile();

        }

but when i go to the saved file i get an empty file even though the text i loaded isn't empty. Thanks:)

[Alan Balkany]

I don't see any statement where you actually write the text to the file. It looks like the statements in the 'if' clause are in the wrong order and incomplete.

[Christian Graus]

What is wrong with File.Copy ?

Christian Graus Driven to the arms of OSX by Vista.

[bar3000]

the statements in the if clause close a different stream. The one which i want to open with the new stream. Google came up with FileStream fs = new FileStream(@"C:\Documents and Settings\Bar\My Documents\savegame.txt", FileMode.Open); for opening txt files.

[bar3000]

I don't know the destination file. he user desides where he wants to save it with the save dialog.

[Luc Pattyn]

Hi, your code seems completely wrong to me. Here are some of the problems: - a SaveFileDialog is meant for the user to enter a new filename or choose an existing filename, or to cancel the intended operation. To do that correctly you should compare the return value of ShowDialog() against DialogResult.OK (you compare FileName with empty string, I doubt that is equivalent) and use the FileName value as the path of the output file (you don't use the value at all). - (the part shown of) your code does not declare, create or use writer and file except for closing it, so at best something gets written somewhere else, and some (which?) file gets closed; anyway changing the state of writer and file should not be a side effect of the saveDialog.FileName != "" test, the writer and the file operation should only exist inside the code block following that test, and nowhere else. - declaring a FileStream and opening a file inside the code block of the if statement, while not using that stream, does not make any sense. Once the if-block is done, the stream is out of scope, hence useless. - if your code creates a FileDialog, it should also dispose of it; the using statement is the easiest way of doing it right. I suggest you have a look at some CodeProject articles; a lot of them describe small applications that do load and save some data from and to a file, using OpenFileDialog and SaveFileDialog. Just use these as search terms in the CP search facility. If you don't fully understand the FileDialog class, read its documentation; if you still feel uncomfortable, go buy and study an introductory book on the language of your choice. It will teach you the basics in a systematic way. :)

Luc Pattyn [Forum Guidelines] [My Articles]

---

- before you ask a question here, search CodeProject, then Google - the quality and detail of your question reflects on the effectiveness of the help you are likely to get - use the code block button (PRE tags) to preserve formatting when showing multi-line code snippets

---

modified on Sunday, June 12, 2011 8:38 AM

[Lost User]

You can use this code at your own risk. I wrote it without being really awake.

using (SaveFileDialog saveDialog = new SaveFileDialog())
{
saveDialog.AddExtension = true;
saveDialog.FileName = "Checkers Game";
saveDialog.InitialDirectory = @"C:\Documents and Settings\Bar\My Documents\";
saveDialog.OverwritePrompt = true;
saveDialog.Title = "Save game";
saveDialog.ValidateNames = true;
if (saveDialog.ShowDialog() == DialogResult.OK)
{
File.Copy(@"C:\Documents and Settings\Bar\My Documents\savegame.txt", saveDialog.FileName, true);
}
}

[Luc Pattyn]

Code looks good, however spoon feeding is bad. :^)

Luc Pattyn [Forum Guidelines] [My Articles]

---

- before you ask a question here, search CodeProject, then Google - the quality and detail of your question reflects on the effectiveness of the help you are likely to get - use the code block button (PRE tags) to preserve formatting when showing multi-line code snippets

---

modified on Sunday, June 12, 2011 8:39 AM

[vaghelabhavesh]

bar3000 wrote:

I don't know the destination file

You are using the SaveFileDialog and you don't know the destination file name?:confused:

[Megidolaon]

The FileDilaog classes only allow the user to select a path, they don't actually do anything with files. An easy way to actually write or open a file is using the Filename property of the OpenFileDialog and SaveFileDialog and save that in a string variable. Then you use File.ReadAllText() method to read a file and File.WriteAllText() method to write the text to a file. These work even without giving the user a possibility to specify the location or name of the file. Both methods have a string parameter called path, that's where you can put the path you just got from the FileDialogs (or a fixed path).

modified on Thursday, February 26, 2009 8:11 AM