if(BOOL_b) vs if(BOOL_b == FALSE)

[fitatc]

BOOL b
A. if(!b){ ... }
B. if(b == FALSE){ ... }

There is my senior who says that B is better though said by another senior that a is better, too. Both could not exactly explain the resion.:~ Also, sample by MSDN like PtInRect's, is test by if(b). And I checked the assembly of A and B, they are the same. :confused: Which is better in your opinion, A or B? Is it really different only in oppearance?

[Maxwell Chen]

Sorry I did not read through the end of your description earlier. The if evaluates true/false. Case A:

bool b; // b is a boolean.
if(!b) { }

Case B:

BOOL bb; // bb is an integer.
if(FALSE == bb) { }

That's what I prefer... ;)

Maxwell Chen

[N a v a n e e t h]

fitatc wrote:

Which is better in your opinion, A or B?

I think it's a matter of style. I like A. :)

Navaneeth How to use google | Ask smart questions

[Eytukan]

As Max has pointed out, when it's a true/false case, it's recommended that you use bool and not BOOL. Worse is to use a BOOL and store integer values in it. Just like the MS people do. :doh: Also to reply your OQ, It's not a preference, you should always use

if(cond)
{

}

Rather than

if(cond==true)
{

}

Because with the later, there are chances you end up with the legendary "=" operator. like if(cond=true).

He never answers anyone who replies to him. I've taken to calling him a retard, which is not fair to retards everywhere.-Christian Graus

[Niklas L]

Always try to use the first form. Checking for equality with FALSE is theoretically ok, but you can end up in trouble if you compare it with TRUE. FALSE is always zero, but any other value is 'true'.

BOOL b = 3;

if (b) {}
if (b == TRUE) {}

shows the problem. (The first if fires, but not the second one) My advice is to use the first form, which is more elegant, and always safe. Also think about how you name your variables, and it will be easier to read the code.

home