Mem Usage keeps increasing

[David Crow]

Why would you expect it to do otherwise? See here for why Task Manager is not a good measure of a program's memory consumption. As far as cleanup goes, you can replace

strFileName = "F:\\Pictures\\Pic";
_itoa_s(x,Temp,sizeof(Temp),10);
strFileName += Temp;
strFileName += ".bmp";

with

strFileName.Format("F:\\Pictures\\Pic%d.bmp", x);

"Old age is like a bank account. You withdraw later in life what you have deposited along the way." - Unknown

"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons

[FISH786]

Thank you. I guess the code is fine as is. I really wasn't checking on the mem usage in task manager but was looking for something there and noticed the usage kept increasing.

[KarstenK]

cleanup the loop call m_bmpCtrl.LoadFile(strFileName); outside of the do{} loop :doh:

Press F1 for help or google it. Greetings from Germany

[FISH786]

KarstenK wrote:

outside of the do{} loop

:confused: How am I supposed to change the strFileName and load different files inside the loop?

[Sarath C]

If you need to load a new file, the resources has to be properly released if it's anymore used. So please release the buffers and handles associated with LoadFile operation. I think the other part of the code is just fine.

-Sarath. "Great hopes make everything great possible" - Benjamin Franklin

My blog - Sharing My Thoughts

[FISH786]

Thank you.

[FISH786]

I used the following sample code to do it. I am not sure what I am looking for in order to release the handles. Thanks for you help in advance. http://www.ucancode.net/Visual_C_MFC_Example/VC-Control-Load-View-Bitmap-File.htm[^]

[FISH786]

I have put this and now the Memory is not as bad but it keeps increasing.

HBITMAP test = m_bmpCtrl.hBitmap;
if (test)
{
DeleteObject(test);

		}

Can someone please help

[Sarath C]

What's the type of m_bmpCtrl variable? There will be direct functions exposed in the class to clear the attached resources also the way you released the resources is quite wrong. if you're explicity releasing the resource, it's your responsibility to assign it as NULL. Otherwise the next call this function may crash, as you've released the previously and the m_bmpCtrl.hBitmap still holds an junk(invalid) handle. also why it's necessary to create a temporary variable? the following way is straight forward no?

if (m_bmpCtrl.hBitmap)
{
DeleteObject(m_bmpCtrl.hBitmap);
m_bmpCtrl.hBitmap = NULL;
}

-Sarath. "Great hopes make everything great possible" - Benjamin Franklin

My blog - Sharing My Thoughts

[FISH786]

Thank you. That has partly solved it. Yes there was no point creating extra variable. The m_bmpCtrl is of CBitmapCtrl class. I am new at this and am learning. Thanks for all your help It's greatly appreciated.