need help

[N a v a n e e t h]

SeMartens wrote:

odr.Read(); --> true if you have one record

ExecuteScalar will be more appropriate in this case than reader.

Navaneeth How to use google | Ask smart questions

[SeMartens]

Okay, normally you should write it by yourself, but today is friday, so here it comes:

private bool DoesUserExists(string sUserID) {
OdbcConnection cn;
OdbcCommand cmd;
OdbcParameter dbParameter;
OdbcDataReader odr;

string MyString = "Select * from users WHERE userid = @userid";

cn = new OdbcConnection("Driver={Microsoft ODBC for Oracle};Server=orcl8i;UID=itehad;PWD=creative;");
cn.Open();
cmd = new OdbcCommand(MyString, cn);
dbParameter = new OdbcParameter("userid", sUserID");
cmd.Parameters.Add(dbParameter);
odr = cmd.ExecuteReader();

bool bResult = (odr.HasRows && odr.Read());
odr.Close();
cn.Close();
return bResult;

}

private void login_Click(object sender, EventArgs e)
{
if(this.DoesUserExists(usr.Text)) {
MessageBox.Show("User Login", "Information", MessageBoxButtons.OK, MessageBoxIcon.Information);
} else {
DialogResult drsave = MessageBox.Show("Login Fail", "Erorr", MessageBoxButtons.OKCancel, MessageBoxIcon.Error);
if (drsave == DialogResult.OK)
{
usr.Text = "";
pass.Text = "";
usr.Focus();
} else {
this.Close();
}
}
}

You should add fail-safe to your app by using try-catch blocks, especially while interacting with the database. Next step would be to seperate the dataccess into an own assembly. Regards Sebastian

It's not a bug, it's a feature! Check out my CodeProject article Permission-by-aspect. Me in Softwareland.

[SeMartens]

Yep, you are right... but we want to confuse beginners, or? :)

It's not a bug, it's a feature! Check out my CodeProject article Permission-by-aspect. Me in Softwareland.

[Nagy Vilmos]

Be careful about how you test for equality, in all but the rarest case you shoud use the Equals method.

a == b

This compares two objects and returns true if they are they same object, that is the same instance. This does not compare the content.

a.Equals(b)

Compares the two instances and is defined by each classes implimentation. In the trivial case of the string, it returns true if they have the same content. Any class you write should override this method if you need to compare instances' values.

---

Panic, Chaos, Destruction. My work here is done.

[mjawadkhatri]

Thanks Alot Sir for Help me Sir When I Run this program give error Error Is Error 1 'Microsoft.Data.Odbc.OdbcDataReader' does not contain a definition for 'HasRows'

[mjawadkhatri]

sir Actually i am use dotnet after 1 year thats why i am facing lot of problem sir i kindly request to u please give me solution :sigh:

[SeMartens]

Why don't you use the System.Data.Odbc.OdbcDataReader?

It's not a bug, it's a feature! Check out my CodeProject article Permission-by-aspect. Me in Softwareland.

[mjawadkhatri]

ok. i use this and trying to solve my problem sorry for distrb u Sir:sigh:

[SeMartens]

No problem. And please don't call me sir... :) Just give a feedback if your problem is solved. Regards Sebastian

It's not a bug, it's a feature! Check out my CodeProject article Permission-by-aspect. Me in Softwareland.

[mjawadkhatri]

Thanks Again