Record Not Insert

[mjawadkhatri]

Hi please check my coding and guide me why record not insert my coding is OdbcConnection cn; OdbcCommand cmd; OdbcDataReader odr; string MyString; MyString = "Select empid , sysdte from timemgmt"; if (radioin.Checked == true) { cn = new OdbcConnection("Driver={Microsoft ODBC for Oracle};Server=orcl8i;UID=itehad;PWD=creative;"); cmd = new OdbcCommand(MyString, cn); cn.Open(); cmd.CommandText = "Select empid , sysdte from timemgmt where empid = '"+textBox1.Text+"' and sysdte ='"+label19.Text+"'"; //MessageBox.Show("Connected"); //cmd.CommandText = "select empid,sysdteinsert into timemgmt values('" + textBox1.Text + "','" + label19.Text + "','" + label18.Text + "','" + label18.Text + "')";//,'" + label18.Text + "','" + label18.Text + "')"; //MessageBox.Show(cmd.CommandText); //cmd.ExecuteNonQuery(); odr = cmd.ExecuteReader(); while (odr.Read()) { if (textBox1.Text == (odr["empid"].ToString()) && label19.Text == (odr["sysdte"]).ToString()) { MessageBox.Show("You Already IN this ID Today"); } else { cmd.CommandText = "insert into timemgmt values('" + textBox1.Text + "','" + label19.Text + "','" + label18.Text + "','" + label18.Text + "')"; } } cn.Close();

[Mycroft Holmes]

It would be helpful if you posted the error generated! This assumes there are only 4 field in the table. cmd.CommandText = "insert into timemgmt values('" + textBox1.Text + "','" + label19.Text + "','" + label18.Text + "','" + label18.Text + "')"; If there are more you need cmd.CommandText = "insert into timemgmt (field1, field2, field3, field4) values('" + textBox1.Text + "','" + label19.Text + "','" + label18.Text + "','" + label18.Text + "')";

Never underestimate the power of human stupidity RAH

[mjawadkhatri]

I give feild name like this cmd.CommandText = "insert into timemgmt values(empid,sysdte,intime,outtime)('" + textBox1.Text + "','" + label19.Text + "','" + label18.Text + "','" + label18.Text + "')"; no record Insert :( And no error show please guyz help me

[K0306]

There is a error in insert statement try this

cmd.CommandText = "insert into timemgmt(empid,sysdte,intime,outtime) values ('" + textBox1.Text + "','" + label19.Text + "','" + label18.Text + "','" + label18.Text + "')";

Regards, Karthik K...

[mjawadkhatri]

No my problem is not solve :( ok tell me how i search record in oracle database if record find record not save else save record i code this for search record cmd.CommandText = "Select empid , sysdte from timemgmt where empid = '"+textBox1.Text+"' and sysdte ='"+label19.Text+"'"; then i create condition like this while (odr.Read()) { if (textBox1.Text == (odr["empid"].ToString()) && label19.Text == (odr["sysdte"]).ToString()) { MessageBox.Show("You Already IN this ID Today"); } else { cmd.CommandText = "insert into timemgmt values(empid, sysdte, intime, outtime)('" + textBox1.Text + "','" + label19.Text + "','" + label18.Text + "','" + label18.Text + "')"; cmd.ExecuteNonQuery(); }

[Tom Deketelaere]

I already told you to use the 'code block' tags when posting code (see here[^] ) I also already told you to use parameters (to prevent sql-injunctions). Not only are they safer they will also prevent a lot of errors.

[Pete OHanlon]

Where to start?

1. Give your variables meaningful names. At a glance, what does textBox1 do?
2. Your code is wide open to a SQL Injection attack. You need to look into using parameterised queries here.
3. Your insert statement does nothing. You create the command text and then close the connection - you need to execute the command using cmd.ExecuteNonQuery();
4. You have no exception handling. What happens if you can't connect the database, for instance?

If you had bothered to debug your code, you would have found the problem out in an instant. Learning to debug is one of the most valuable lessons you can master as a developer, and you should learn how to do it before too much longer.

"WPF has many lovers. It's a veritable porn star!" - Josh Smith

As Braveheart once said, "You can take our freedom but you'll never take our Hobnobs!" - Martin Hughes.

My blog | My articles | MoXAML PowerToys | Onyx

[K0306]

mjawadkhatri wrote:

cmd.CommandText = "Select empid ,sysdte from timemgmt where empid = '" + textBox1.Text + "' and sysdte ='" + label19.Text + "'";

your search query is ok. After that use like this way,

if(odr.read())
{
MessageBox.Show("You Already IN this ID Today");
}
else
{
cmd.CommandText = "insert into timemgmt empid, sysdte, intime, outtime) values('" + textBox1.Text + "','" + label19.Text + "','" + label18.Text + "','" + label18.Text + "')";
cmd.ExecuteNonQuery();
}

Try the above code.Use the Breakpoints and try to rectify where the error comes.

Regards, Karthik K...