Event handling Object reference error

[gwithey]

I am trying to create an on update event and have recieved the following error: An object reference is required for the non-static field, method, or property 'RenishawVMCU.CommandParser.OnUpdate(RenishawVMCU.CommandData)' It is generated form this line: OnUpdate(rxPortData);

public class CommandParser
{
CommandData rxPortData = new CommandData();

public delegate void delUpdate(CommandData commandData);
public event delUpdate update;

  protected virtual void OnUpdate(CommandData commandData)
  {
     if (update != null)
     {
        this.update(commandData);
     }
  }

}
public static string ParseCommand(string m_recievedUCCData)
{
byte[] rxData;

     rxData = StrToByteArray(m\_recievedUCCData);

     //CommandData rxPortData = new CommandData();
     CommandData rxPortData = ParseCommand(rxData);

     //OnUpdate(rxPortData);

     rxData.ToString();
     return "Parsing done!" ;
    
  }

public class VirtualMCU
{
public VirtualMCU()
{
cmdParser.update += new CommandParser.delUpdate(cmdParser_update);
}
}

Does anyone know what could be wrong as this is the only line that is causing a problem i cant work it out.

[Uri Lavi]

ParseCommand is a static method. You cannot access non static methods / members from the static one.

Uri

[DaveyM69]

This is static

public static string ParseCommand(string m_recievedUCCData)
{
// ...
OnUpdate(rxPortData);
// ...
}

This is not so can only be called by an instance of CommandParser

protected virtual void OnUpdate(CommandData commandData)
{
// ...
}

If there is no particular reason for the ParseCommand method to be static, then make it an instance member. Alternatively, pass a CommandParser instance as a parameter into the ParseCommand method and act on that.

public static string ParseCommand(string m_recievedUCCData, CommandParser commandParser)
{
// ...
commandParser.OnUpdate(rxPortData);
// ...
}

Dave
BTW, in software, hope and pray is not a viable strategy. (Luc Pattyn)
Visual Basic is not used by normal people so we're not covering it here. (Uncyclopedia)
Why are you using VB6? Do you hate yourself? (Christian Graus)

[gwithey]

Thanx for the help. I had not yet learnt of this so was useful information. i soleved the probelm by passing in the perameter as you suggested which stopped the error. This is the final code, it didnt have a problem with calling Parsecommand(byte[]) as the method is static.

public static string ParseCommand(string m_recievedUCCData, CommandParser commandParser)
{
byte[] rxData;

     rxData = StrToByteArray(m\_recievedUCCData);

     CommandData rxPortData = ParseCommand(rxData);

     commandParser.OnUpdate(rxPortData);

     //rxData.ToString();
     return "Parsing done!" ;
    
  }

[Luc Pattyn]

Here[^] is a hint for you. :)

Luc Pattyn [Forum Guidelines] [My Articles]

---

The quality and detail of your question reflects on the effectiveness of the help you are likely to get. Show formatted code inside PRE tags, and give clear symptoms when describing a problem.

---