which is better when inserting data in sql database

[neodeaths]

hi i was just wondering which is the better way to insert data into database when i got large amount of data to add in. way 1 do "insert into db1 () values()" execute command while() or way 2 do string = string + "insert into db1 () values()" while() execute command also if lets say way 2 somewhere in the middle of the insert command there is an error would the code before it still be added?

[PIEBALDconsult]

The first is better, but neither is as good as:

cmd.CommandText = "INSERT INTO table ( ... ) VALUES ( @Param0 ... )" ;

(create and add parameters to cmd)

while ( ... )
{
(set parameter values)

cmd.ExecuteNonQuery() ;

}

And use a transaction if you need to.

[i i i]

"in the middle of the insert command there is an error would the code before it still be added?" You can use sqlTransaction , and can rollback and commit transactions as well as can make commit points

Best Of Regards, SOFTDEV If you have knowledge, let others light their candles at it

[N a v a n e e t h]

Best way to see which is performing fast is to profile the application. I will go with the first method with the modifications what PIEBALDconsult suggested. Second method would be good in performance but it is hard to troubleshoot when you get error in one of the inserts.

neodeaths wrote:

also if lets say way 2 somewhere in the middle of the insert command there is an error would the code before it still be added? Quote Selected Text

It will be added. If you want to ensure all the data gets added, run the queries in a transaction.

Navaneeth How to use google | Ask smart questions