pointer and switch
-
I am trying to write a program as a math tutor. Can someone look at this code. I keep getting errors on int and pointer as well as telling me the switch case has illegal pointer. Thanks, any advice would be greatful.
#include #include #define SENT 4 //"Quit" menu choice
/* Function Prototypes */
void DisplayMenu (void); void GetMenuChoice (void); void Gen2Rand (int\*r1, int\*r2); void DrillOneProb (int\*c, int\*r1, int\*r2);/*============Mainline Procedures===============*/
int main (void)
{
int c; //Menu Choice (1-4)
int r1, //First Random Integer: 2-12 inclusive
r2; //Second Randon Integer: 2-12 inclusive}
/*===========CHILD FUNCTIONS===============*/
/* Display Title and Menu */
void DisplayMenu (void)
{ printf("MENU OF OPERATIONS\\n\\n"); printf("1. Addition.\\n"); printf("2. Subtraction.\\n"); printf("3. Multiplication.\\n"); printf("4. Quit.\\n\\n"); }/* Get Menu Choice */
void GetMenuChoice (void)
{ int c; printf ("Enter the number of the operation to try (1-4):\\n"); scanf ("%d", &c); while (c<1 || c>SENT) printf("\\aInput value is out of range.\\n"); }/* Generate and return 2 integers between 2-12 inclusive */
void Gen2Rand (int *r1p, int *r2p)
{ int c; c=0; if (c>=1 && c<SENT) int r1; // First random number int r2; //Second random number r1 = 2 + rand() %11; r2 = 2 + rand() %11; \*r1p = r1; \*r2p = r2; printf("Program complete\\n"); }/* Display two random numbers and ask user what the answer would be after the chosen operation*/
void DrillOneProb (int *c, int *r1, int *r2)
{
int CorAns, //Correct Answer
Reply; // Users Reply{ printf("\\nWhat is %d", & r1); r1 = 2 + rand() % 11; } switch (c); { case '1': 1 = +; break; CorAns = r1 + r2; case '2': 2 = -; break; CorAns = r1 - r2; case '3': 3 = x; break; CorAns = r1 x r2; } printf("%d ? %d\\n", r2, Reply);if
Reply = CorAns
{
printf("Yes, that is correct. Good Job!");
}else printf("No, the correct answer is: %d", CorAns); printf("\\n\\n");return (c);
print\_menu(); //Print the menu option, and configure some needed things. return (0); //The end of our simple game.kbury wrote:
switch (c);
This must be
switch (c)without the;I also believe that it must actually beswitch (*c)«_Superman_» I love work. It gives me something to do between weekends.
Microsoft MVP (Visual C++) -
kbury wrote:
switch (c);
This must be
switch (c)without the;I also believe that it must actually beswitch (*c)«_Superman_» I love work. It gives me something to do between weekends.
Microsoft MVP (Visual C++) -
I am trying to write a program as a math tutor. Can someone look at this code. I keep getting errors on int and pointer as well as telling me the switch case has illegal pointer. Thanks, any advice would be greatful.
#include #include #define SENT 4 //"Quit" menu choice
/* Function Prototypes */
void DisplayMenu (void); void GetMenuChoice (void); void Gen2Rand (int\*r1, int\*r2); void DrillOneProb (int\*c, int\*r1, int\*r2);/*============Mainline Procedures===============*/
int main (void)
{
int c; //Menu Choice (1-4)
int r1, //First Random Integer: 2-12 inclusive
r2; //Second Randon Integer: 2-12 inclusive}
/*===========CHILD FUNCTIONS===============*/
/* Display Title and Menu */
void DisplayMenu (void)
{ printf("MENU OF OPERATIONS\\n\\n"); printf("1. Addition.\\n"); printf("2. Subtraction.\\n"); printf("3. Multiplication.\\n"); printf("4. Quit.\\n\\n"); }/* Get Menu Choice */
void GetMenuChoice (void)
{ int c; printf ("Enter the number of the operation to try (1-4):\\n"); scanf ("%d", &c); while (c<1 || c>SENT) printf("\\aInput value is out of range.\\n"); }/* Generate and return 2 integers between 2-12 inclusive */
void Gen2Rand (int *r1p, int *r2p)
{ int c; c=0; if (c>=1 && c<SENT) int r1; // First random number int r2; //Second random number r1 = 2 + rand() %11; r2 = 2 + rand() %11; \*r1p = r1; \*r2p = r2; printf("Program complete\\n"); }/* Display two random numbers and ask user what the answer would be after the chosen operation*/
void DrillOneProb (int *c, int *r1, int *r2)
{
int CorAns, //Correct Answer
Reply; // Users Reply{ printf("\\nWhat is %d", & r1); r1 = 2 + rand() % 11; } switch (c); { case '1': 1 = +; break; CorAns = r1 + r2; case '2': 2 = -; break; CorAns = r1 - r2; case '3': 3 = x; break; CorAns = r1 x r2; } printf("%d ? %d\\n", r2, Reply);if
Reply = CorAns
{
printf("Yes, that is correct. Good Job!");
}else printf("No, the correct answer is: %d", CorAns); printf("\\n\\n");return (c);
print\_menu(); //Print the menu option, and configure some needed things. return (0); //The end of our simple game.kbury wrote:
1 = +;
kbury wrote:
2 = -;
kbury wrote:
3 = x;
kbury wrote:
CorAns = r1 x r2;
kbury wrote:
if Reply = CorAns
I think you should read very carefully a syntax reference of the
Cprogramming language. :)If the Lord God Almighty had consulted me before embarking upon the Creation, I would have recommended something simpler. -- Alfonso the Wise, 13th Century King of Castile.
This is going on my arrogant assumptions. You may have a superb reason why I'm completely wrong. -- Iain Clarke
[My articles] -
kbury wrote:
1 = +;
kbury wrote:
2 = -;
kbury wrote:
3 = x;
kbury wrote:
CorAns = r1 x r2;
kbury wrote:
if Reply = CorAns
I think you should read very carefully a syntax reference of the
Cprogramming language. :)If the Lord God Almighty had consulted me before embarking upon the Creation, I would have recommended something simpler. -- Alfonso the Wise, 13th Century King of Castile.
This is going on my arrogant assumptions. You may have a superb reason why I'm completely wrong. -- Iain Clarke
[My articles] -
While following the flow, you shouldn't forget there is also the syntax... :rolleyes:
If the Lord God Almighty had consulted me before embarking upon the Creation, I would have recommended something simpler. -- Alfonso the Wise, 13th Century King of Castile.
This is going on my arrogant assumptions. You may have a superb reason why I'm completely wrong. -- Iain Clarke
[My articles] -
While following the flow, you shouldn't forget there is also the syntax... :rolleyes:
If the Lord God Almighty had consulted me before embarking upon the Creation, I would have recommended something simpler. -- Alfonso the Wise, 13th Century King of Castile.
This is going on my arrogant assumptions. You may have a superb reason why I'm completely wrong. -- Iain Clarke
[My articles]I am stuck with this section of my code so far: error codes: expected int and got pointer to int and operands of = illegaltype pointer to int and int
/* Display two random numbers and ask user what the answer would be after the chosen operation*/
void DrillOneProb (int*c, int*r1, int*r2)
{
int CorAns, //Correct Answer
Reply; // Users Reply{ printf("\\nWhat is %d",r1); 1st error scanf("%d", r1); r1 = 2 + rand() % 11; 2nd error } -
I am stuck with this section of my code so far: error codes: expected int and got pointer to int and operands of = illegaltype pointer to int and int
/* Display two random numbers and ask user what the answer would be after the chosen operation*/
void DrillOneProb (int*c, int*r1, int*r2)
{
int CorAns, //Correct Answer
Reply; // Users Reply{ printf("\\nWhat is %d",r1); 1st error scanf("%d", r1); r1 = 2 + rand() % 11; 2nd error }kbury wrote:
printf("\nWhat is %d",r1);
change to
printf("\nWhat is %d", *r1);
kbury wrote:
r1 = 2 + rand() % 11;
change to
*r1 = 2 + rand() % 11;
The above steps, however just fix compiler errors...I don't know if the semantic will be correct. BTW what about a good
Clanguage programming book? :)If the Lord God Almighty had consulted me before embarking upon the Creation, I would have recommended something simpler. -- Alfonso the Wise, 13th Century King of Castile.
This is going on my arrogant assumptions. You may have a superb reason why I'm completely wrong. -- Iain Clarke
[My articles] -
kbury wrote:
printf("\nWhat is %d",r1);
change to
printf("\nWhat is %d", *r1);
kbury wrote:
r1 = 2 + rand() % 11;
change to
*r1 = 2 + rand() % 11;
The above steps, however just fix compiler errors...I don't know if the semantic will be correct. BTW what about a good
Clanguage programming book? :)If the Lord God Almighty had consulted me before embarking upon the Creation, I would have recommended something simpler. -- Alfonso the Wise, 13th Century King of Castile.
This is going on my arrogant assumptions. You may have a superb reason why I'm completely wrong. -- Iain Clarke
[My articles]change to printf("\nWhat is %d", *r1); (I already changed this)I figured that out. kbury wrote: r1 = 2 + rand() % 11; change to *r1 = 2 + rand() % 11; (This defineately fixed this. The above steps, however just fix compiler errors...I don't know if the semantic will be correct.
switch (c)
{ (states that this is illegal type pointer to int in switch expression.) case '1': printf("+"); CorAns = r1 + r2; (operands of + have illegal of 'pointer to int' and 'pointer to int') break; -
change to printf("\nWhat is %d", *r1); (I already changed this)I figured that out. kbury wrote: r1 = 2 + rand() % 11; change to *r1 = 2 + rand() % 11; (This defineately fixed this. The above steps, however just fix compiler errors...I don't know if the semantic will be correct.
switch (c)
{ (states that this is illegal type pointer to int in switch expression.) case '1': printf("+"); CorAns = r1 + r2; (operands of + have illegal of 'pointer to int' and 'pointer to int') break;kbury wrote:
CorAns = r1 + r2;
change to
CorAns = *r1 + *r2;
The real solution, however, would be reading the f*#?n' book. :-D
If the Lord God Almighty had consulted me before embarking upon the Creation, I would have recommended something simpler. -- Alfonso the Wise, 13th Century King of Castile.
This is going on my arrogant assumptions. You may have a superb reason why I'm completely wrong. -- Iain Clarke
[My articles] -
kbury wrote:
CorAns = r1 + r2;
change to
CorAns = *r1 + *r2;
The real solution, however, would be reading the f*#?n' book. :-D
If the Lord God Almighty had consulted me before embarking upon the Creation, I would have recommended something simpler. -- Alfonso the Wise, 13th Century King of Castile.
This is going on my arrogant assumptions. You may have a superb reason why I'm completely wrong. -- Iain Clarke
[My articles] -
kbury wrote:
CorAns = r1 + r2;
change to
CorAns = *r1 + *r2;
The real solution, however, would be reading the f*#?n' book. :-D
If the Lord God Almighty had consulted me before embarking upon the Creation, I would have recommended something simpler. -- Alfonso the Wise, 13th Century King of Castile.
This is going on my arrogant assumptions. You may have a superb reason why I'm completely wrong. -- Iain Clarke
[My articles] -
I guess you're able to guess now. :)
If the Lord God Almighty had consulted me before embarking upon the Creation, I would have recommended something simpler. -- Alfonso the Wise, 13th Century King of Castile.
This is going on my arrogant assumptions. You may have a superb reason why I'm completely wrong. -- Iain Clarke
[My articles]
