SQL update query

[Mattzimmerer]

This one should be easy :omg: ... I cant get a simple parametrized update query to function at all... This is a simplified version of what I am trying to do...

UPDATE TheDatabase

SET ([Vehicle #] = @NewVehNo)

WHERE ([Vehicle #] = @OldVehNO)

I dont enderstand why this is wrong... I suck at SQL lol... from MSDN i get the format:

UPDATE ShoppingCart
SET (BookId = @bookid, CustId = @custid, Quantity = @quantity)
WHERE (BookId = @bookid AND CustId = @custid)

[Luc Pattyn]

UPDATE targets a table, not a database. suggestion: stop using those field names full of special characters, and get rid of those square brackets then. :)

Luc Pattyn [Forum Guidelines] [Why QA sucks] [My Articles]

---

I only read code that is properly formatted, adding PRE tags is the easiest way to obtain that.

---

[Don Burton]

Get rid of the parens. Such as: UPDATE Thetable SET [Vehicle #] = @NewVehNo WHERE [Vehicle #] = @OldVehNO and I assume you are updating a table - Yes?

[Mattzimmerer]

wait yes... i replaced that for some reason... i am updating a table

UPDATE [dbo].[Pickups & Cars]

SET ([Vehicle #] = @Vehicle_NO)

WHERE ([Vehicle #] = @Vehicle_NO)

this doesnt work...

[Don Burton]

Get rid of the parens: UPDATE [dbo].[Pickups & Cars] SET [Vehicle #] = @Vehicle_NO WHERE [Vehicle #] = @Vehicle_NO Have tried the SP in Query Analyzer?

[Mattzimmerer]

I guess the parens were messing it up... thanks!

[i j russell]

Are you getting an error when you run the update? Have you tried running the update against a vehicle that you know exists in the database rather than a variable? eg UPDATE .... WHERE [Vehicle #] = 1;

[Mycroft Holmes]

I would emphasize what Luc said, you need to go through your entire database and remove the spaces and special characters from the table and field names NOW. If you do not do this now it will drive you nuts and may cause compatibility problems in the future. Some tools will not accept [Vehicle #].

Never underestimate the power of human stupidity RAH

[Mattzimmerer]

Ok, Ill restrict my database to letters only... underscores shouldnt cause problems right?

[Mycroft Holmes]

No underscores are fine they will just irritate you, most developers try and avoid them. Take a look through most sample code in the articles and things like northwind, very few underscores.

Never underestimate the power of human stupidity RAH