dataGridView1_CellContentClick Error Index Out of Range

[Luc Pattyn]

Kwagga wrote:

string taskstring = dataGridView1[0, currentRow].Value.ToString(); /

I see two indices in that statement. so what is the value of currentRow? and how many rows and columns are there at that point in time? (the number may vary when you have databindings). Is there a relationship between datagridview1 and dt (which you just cleared)? you still have work to do on the observation half of my previous message! :)

Luc Pattyn [Forum Guidelines] [Why QA sucks] [My Articles] Nil Volentibus Arduum

Please use <PRE> tags for code snippets, they preserve indentation, and improve readability.

[OriginalGriff]

Kwagga wrote:

I have also re-writtent the currentRow as this which seems to work: int currentRow = e.RowIndex;

Yes, that is what I would expect - and int assigned directly to an int! See how much easier it is when you don't convert int to string to int? :laugh:

Kwagga wrote:

The error seems to come in here: string taskstring = dataGridView1[0, currentRow].Value.ToString();

That only leaves one option: currentRow has a value that is either negative, or too big for the DataGridView. Since you access it from the RowIndex, it is unlikely to be too big - how would it unless the DatatGridView is being modified by some outside agency; not too likley in your scenario I think. That leaves negative. And I'm betting that is what the problem is. The easiest way to get a negative number here via the RowIndex (in fact the only one I know, but I've been wrong before) is to click on the column header. Are you by any chance doing that? If not, then insert a check for negative (and out-of-range) values and see what you get. I'm pretty confident that either your code for the other DataGridViews is different and checks for valid data or you haven't clicked on their column header yet... :-D

Real men don't use instructions. They are only the manufacturers opinion on how to put the thing together.

[OriginalGriff]

Hi Luc! How are you doing today?

Luc Pattyn wrote:

make sure your development tools (Visual Studio or other) ALWAYS show line numbers in editor windows.

You don't need to do this: VS shows the row and column numbers on the status line by default, and CTRL+G will take to to an absolute page number. I use this rather than waste screen real-estate and adding unnecessary confusion to the display! Different stroke for different folks, I guess. :laugh:

Real men don't use instructions. They are only the manufacturers opinion on how to put the thing together.

[Luc Pattyn]

OriginalGriff wrote:

How are you doing today?

Fine, thanks. Although I can't find the hidden message I'm sure you must have hidden in there. I won't be around much the next couple of days, a major chess tournament is about to start.

OriginalGriff wrote:

You don't need to do this

I know. Nevertheless those few characters on each line are the most useful data in there anyway, the remainder being just too many int.Parse(something.ToString()) and the like. I much prefer all those enquirers to at least discover for themselves which line is causing havoc. :)

Luc Pattyn [Forum Guidelines] [Why QA sucks] [My Articles] Nil Volentibus Arduum

Please use <PRE> tags for code snippets, they preserve indentation, and improve readability.

[OriginalGriff]

Luc Pattyn wrote:

a major chess tournament is about to start.

Good luck!

Luc Pattyn wrote:

I can't find the hidden message I'm sure you must have hidden in there

No, no - I wouldn't do that!

Luc Pattyn wrote:

those few characters on each line are the most useful data in there

I'm not too sure about that - I would agree that they are the most accurate data in many peoples software, though!

Real men don't use instructions. They are only the manufacturers opinion on how to put the thing together.

The badgers fly south in august. Peppermint discus tower emblem.

[MumbleB]

Yeah, it is much easier. LOL..... I haven't clicked on any of the header rows. What I have noticed though is that when I click in the cell I want to Edit it just goes back to the first cell. When I click it again then it throws the error. Honestly, the code for the other gridviews are exactly the same for the cellcontent_click event. I am about to give up and just leave them out of the project and then every time somebody has to have something changed for them to go direct to the DB. I have pulled out most of my hair by now!!!!

Excellence is doing ordinary things extraordinarily well.

[MumbleB]

Guys, I thank you for the help thus far. I think I have resolved the problem. The problem seems to have been in the connection state. I added a bunch of checks to see fi the connection was open or closed and then opening, or closing it depending on the state and that seems to have resolved the issue. Below is a work in progress, I am still trying to clean this up a bit more by passing parameters to my SQL statements. Thanks again for the help guys.

    private void dataGridView1\_CellContentClick(object sender, DataGridViewCellEventArgs e)
    {
        int currentRow = e.RowIndex;
        int rowint = 0;
        try
        {
            string taskstring = dataGridView1\[0, currentRow\].Value.ToString();
            rowint = int.Parse(taskstring);
            if (dataGridView1.Columns\[e.ColumnIndex\] == deleteButton && currentRow >= 0)
            {
                if (conn.State == ConnectionState.Open)
                {
                    conn.Close();
                }
                else
                {
                    conn.Open();
                    OleDbCommand sqlDelete = new OleDbCommand("DELETE FROM tblTasks where TaskCode = @rowint", conn);
                    OleDbParameter param = new OleDbParameter();
                    param.ParameterName = "@rowint";
                    param.Value = rowint;
                    sqlDelete.Parameters.Add(param);
                    sqlDelete.ExecuteNonQuery();
                    getData();
                }
            }
            if (dataGridView1.Columns\[e.ColumnIndex\] == editButton && currentRow >= 0)
            {
                if (conn.State == ConnectionState.Open)
                {
                    conn.Close();
                }
                else
                {
                    conn.Open();
                    string updatestring = "Select TaskCode, TaskName, TaskDescription FROM tblTasks WHERE TaskCode = " + rowint + "";
                    string taskname = dataGridView1\[dataGridView1.Columns\["TaskName"\].Index, currentRow\].Value.ToString();
                    string description = dataGridView1\[dataGridView1.Columns\["TaskDescription"\].Index, currentRow\].Value.ToString();
                    OleDbDataAdapter da = new OleDbDataAdapter(updatestring, conn);
                    OleDbCommandBuilder cmdb = new

[OriginalGriff]

Using parameters is a very good idea - but there is a nicer way:

                    OleDbCommand sqlDelete = new OleDbCommand("DELETE FROM tblTasks where TaskCode = @rowint", conn);
                    OleDbParameter param = new OleDbParameter();
                    param.ParameterName = "@rowint";
                    param.Value = rowint;
                    sqlDelete.Parameters.Add(param);

Becomes:

                    OleDbCommand sqlDelete = new OleDbCommand("DELETE FROM tblTasks where TaskCode = @rowint", conn);
                    sqlDelete.Parameters.AddWithValue("@rowint", rowint);

Real men don't use instructions. They are only the manufacturers opinion on how to put the thing together.

[MumbleB]

Thanks Griff. How would I write one for multiple columns UPDATE? Been searching and most posts only shows 1 parameter being passed at a time

Excellence is doing ordinary things extraordinarily well.

[OriginalGriff]

CLUE:

UPDATE mytable SET field1=@F1,field2=@F2 WHERE field3=@F3

cmd.AddWithValue("@F1", "111");
cmd.AddWithValue("@F2", "222");
...

Real men don't use instructions. They are only the manufacturers opinion on how to put the thing together.