Skip to content
  • Categories
  • Recent
  • Tags
  • Popular
  • World
  • Users
  • Groups
Skins
  • Light
  • Cerulean
  • Cosmo
  • Flatly
  • Journal
  • Litera
  • Lumen
  • Lux
  • Materia
  • Minty
  • Morph
  • Pulse
  • Sandstone
  • Simplex
  • Sketchy
  • Spacelab
  • United
  • Yeti
  • Zephyr
  • Dark
  • Cyborg
  • Darkly
  • Quartz
  • Slate
  • Solar
  • Superhero
  • Vapor

  • Default (No Skin)
  • No Skin
Collapse
Code Project
  1. Home
  2. Other Discussions
  3. The Weird and The Wonderful
  4. Guess it does not contains 'Contains'

Guess it does not contains 'Contains'

Scheduled Pinned Locked Moved The Weird and The Wonderful
performance
3 Posts 2 Posters 0 Views 1 Watching
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • V Offline
    V Offline
    VallarasuS
    wrote on last edited by
    #1

    Recently reported a performance hit, hours later noticed this piece of code that caused it, further more the eventhandler was hooked to the event more than once! :mad:

                bool canExecute = false;
                ArrayList targetObjects = previousObject.TargetObjects;
                for (int i = 0; i < targetObjects.Count; i++)
                {
                    if (targetObjects\[i\].Equals(this))
                    {
                        canExecute = true;
                    }
                }
    
                if (canExecute)
                {
                    // Processing on event data.
                }
    

    At least there should be a break point when it is met!! :laugh:

    N 1 Reply Last reply
    0
    • V VallarasuS

      Recently reported a performance hit, hours later noticed this piece of code that caused it, further more the eventhandler was hooked to the event more than once! :mad:

                  bool canExecute = false;
                  ArrayList targetObjects = previousObject.TargetObjects;
                  for (int i = 0; i < targetObjects.Count; i++)
                  {
                      if (targetObjects\[i\].Equals(this))
                      {
                          canExecute = true;
                      }
                  }
      
                  if (canExecute)
                  {
                      // Processing on event data.
                  }
      

      At least there should be a break point when it is met!! :laugh:

      N Offline
      N Offline
      Nagy Vilmos
      wrote on last edited by
      #2

      vallarasus wrote:

      At least there should be a break point when it is met!!

      So true. I've used something similar, but also kept the last 'hit' as it was more likely to be the next one. Another version I've see is a linked list and whenever a target is hit, it's moved to the top of the list.


      Panic, Chaos, Destruction. My work here is done. Drink. Get drunk. Fall over - P O'H OK, I will win to day or my name isn't Ethel Crudacre! - DD Ethel Crudacre I cannot live by bread alone. Bacon and ketchup are needed as well. - Trollslayer Have a bit more patience with newbies. Of course some of them act dumb - they're often *students*, for heaven's sake - Terry Pratchett

      V 1 Reply Last reply
      0
      • N Nagy Vilmos

        vallarasus wrote:

        At least there should be a break point when it is met!!

        So true. I've used something similar, but also kept the last 'hit' as it was more likely to be the next one. Another version I've see is a linked list and whenever a target is hit, it's moved to the top of the list.


        Panic, Chaos, Destruction. My work here is done. Drink. Get drunk. Fall over - P O'H OK, I will win to day or my name isn't Ethel Crudacre! - DD Ethel Crudacre I cannot live by bread alone. Bacon and ketchup are needed as well. - Trollslayer Have a bit more patience with newbies. Of course some of them act dumb - they're often *students*, for heaven's sake - Terry Pratchett

        V Offline
        V Offline
        VallarasuS
        wrote on last edited by
        #3

        That's a joke :laugh: However in this case there should be no iterator!!

        1 Reply Last reply
        0
        Reply
        • Reply as topic
        Log in to reply
        • Oldest to Newest
        • Newest to Oldest
        • Most Votes


        • Login

        • Don't have an account? Register

        • Login or register to search.
        • First post
          Last post
        0
        • Categories
        • Recent
        • Tags
        • Popular
        • World
        • Users
        • Groups