IndexOutOfRangeExceoption while parsing a Netstat process

Luc Pattyn

CCodeNewbie wrote:

if (Line == null) break;

Line can't be null at that point 2. Do as Eddy said, check for the presence of 6 parts if you're consuming 6 parts. Never trust input, sooner or later it will not be what you expected, so cope with that. 3. Keep a copy of the original input line, and display it in the exception thrown by the code Eddy added. And/or log all the lines you are getting from netstat. :)

Luc Pattyn [My Articles] Nil Volentibus Arduum

CCodeNewbie

Have added in a new exception to display s.length. Would you rather recommend

if(Line.length = 0)?

Luc Pattyn

you already have an emptyOrNull test at the start, use that to exit the loop. and I tend to display the original inputs when things go wrong, and optionally also derived values. chances are NetStat occasionally emits a line you never expected! :)

Luc Pattyn [My Articles] Nil Volentibus Arduum

V 0

Nothing to do with your question, but consider changing:

string Line = (Ns.StandardOutput.ReadLine());

to

StringBuilder Line = new StringBuilder((Ns.StandardOutput.ReadLine()));

and just call:

Line.Replace(" ", " ");
.... // rest here

instead of

Line = Line.Replace(" ", " ");
...//rest here

Here the code is sequential and usage between string and StringBuilder is not that different, but if you do stringmanipulation in a loop, the performance difference can become huge. Just a tip.

V.

CCodeNewbie

Hi Eddy, Sorry I haven't got back to you sooner. Did what you suggested but now it makes even less sense:

throw new Exception("failed " + s.Length + " : " + s + " : " + Line);

results in failed 6 : System.String[] : UDP 0.0.0.0 445 * * 4 pardon my ignorance but why is it ignoring the

if (s.Length == 6)

instruction?

Lost User

CCodeNewbie wrote:

pardon my ignorance but why is it ignoring the

if (s.Length == 6)

instruction?

It shouldn't, if the string can be divided into six different words. The line that has been logged, would be broken down like this;

UDP
0.0.0.0
445
*
*
4

You can verify the result using the code below;

foreach (string someWord in s)
{
System.Diagnostics.Debugger.WriteLine("'{0}'", someWord);
}

Also, can you post your (updated) code again?

Bastard Programmer from Hell :suss:

CCodeNewbie

Hi Eddy, Usually it does divide. "UDP 0.0.0.0:445 *:* 4" put through

if (s.Length == 6)
{
insns.Parameters["@Protocol"].Value = s[0];
insns.Parameters["@LocalHost"].Value = s[1];
insns.Parameters["@LocalPort"].Value = s[2];
insns.Parameters["@RemoteHost"].Value = s[3];
insns.Parameters["@RemotePort"].Value = s[4];
insns.Parameters["@State"].Value = "0";
insns.Parameters["@PID"].Value = s[5];
}

becomes s[0]=UDP s[1]=0.0.0.0 s[2]=445 s[3]=* s[4]=* s[5]=0 s[6]=4 if I remove the line "insns.Parameters["@State"].Value = "0";" the output reports "Listening" even though there is no value in the netstat cmd-line output. Sorry this is taking a while, worked out I had to use System.Diagnostics.Debug.WriteLine instead of System.Diagnostics.Debugger.WriteLine So, I did

Process Ns = new Process();
ProcessStartInfo startInfo = new ProcessStartInfo("netstat");
startInfo.Arguments = "-ano";
startInfo.UseShellExecute = false;
startInfo.RedirectStandardOutput = true;
startInfo.CreateNoWindow = true;
Ns.StartInfo = startInfo;
Ns.Start();
Ns.WaitForExit();
for (int i = 0; i < 4; i++)
Ns.StandardOutput.ReadLine();
while (true)
{
Line = (Ns.StandardOutput.ReadLine());
if (!string.IsNullOrEmpty(Line))
{
Line = Line.Trim();
Line = Line.Replace(" ", " ");
Line = Line.Replace(" ", " ");
Line = Line.Replace(" ", " ");
Line = Line.Replace(" ", " ");
Line = Line.Replace(" ", " ");
Line = Line.Replace(" ", " ");
Line = Line.Replace(" ", " ");
Line = Line.Replace(" ", " ");
Line = Line.Replace(" ", " ");
Line = Line.Replace(":", " ");
Line = Line.Replace('\r', ' ');
Line = Line.Replace('\n', ' ');
s = Line.Split(' ');
if (s[0] == "TCP")
{
if (s[1] != "0.0.0.0")
{
insns.Parameters["@Tstamp"].Value = DateTime.Now;
insns.Parameters["@SysID"].Value = SID;
insns.Parameters["@Protocol"].Value = s[0];
insns.Parameters["@LocalHost"].Value = s[1];
insns.Parameters["@LocalPort"].Value = s[2];
insns.Parameters["@RemoteHost"].Value = s[3];
insns.Parameters["@RemotePort"].Value = s[4];
insns.Parameters["@State"].Value =

Lost User

CCodeNewbie wrote:

becomes
s[0]=UDP s[1]=0.0.0.0 s[2]=445 s[3]=* s[4]=* s[5]=0 s[6]=4

That's strange; if s[] contains six elements, how did we get seven items here? s[5] should be 4 IMHO, and s[6] shouldn't be there.

CCodeNewbie wrote:

worked out I had to use System.Diagnostics.Debug.WriteLine instead of System.Diagnostics.Debugger.WriteLine

Aw, my apologies; I tend to mix them up outside of the IDE. It should list all the words in the array in the output-window of Visual Studio.

CCodeNewbie wrote:

when the timer triggered my CPU ramped up to 99% usage by my app and I had to End-Task it. Nothing was written to the Output or the Event log.

Could it be that it's reading a lot of empty lines?

while (true)
{
Line = (Ns.StandardOutput.ReadLine());
if (!string.IsNullOrEmpty(Line))

Bastard Programmer from Hell :suss:

CCodeNewbie

tried

if (s.Length == 6)
{
insns.Parameters["@Tstamp"].Value = DateTime.Now;
insns.Parameters["@SysID"].Value = SID;
insns.Parameters["@Protocol"].Value = s[0];
insns.Parameters["@LocalHost"].Value = s[1];
insns.Parameters["@LocalPort"].Value = s[2];
insns.Parameters["@RemoteHost"].Value = s[3];
insns.Parameters["@RemotePort"].Value = s[4];
insns.Parameters["@State"].Value = string.Empty;
insns.Parameters["@PID"].Value = s[5];
NSInfo.Open();
insns.ExecuteNonQuery();
NSInfo.Close()
};

same thing - service starts, netstat launches, CPU 99%

CCodeNewbie

from a cmd-line netstat -ano you can see that the field usually used by "State" tends to be empty under the UDP protocol unless there is some stream coming in in which case it will show "Established" or whatever. Because I am writing the values to a SQL table I need to keep s[6] in the PID column.

Quote:

Could it be that it's reading a lot of empty lines?

don't think so, usually it works fine until it hits a null/empty value somewhere in the s[] array. What would be ideal is a way of saying: if (s[whatever].isNullorEmpty){s[whatever] = "0";}

Lost User

Select the menu "Debug" and then "Toggle Breakpoint", and use F10 to step through your code.

CCodeNewbie wrote:

What would be ideal is a way of saying:

Something like this?

string FetchFromArray(string[] source, int idx)
{
if (idx <= source.Length)
return source[idx];
else
return String.Empty;
}
public Form1()
{
InitializeComponent();
string[] s = "Hello world from Mars!".Split(' ');
Text = FetchFromArray(s, 7);
}

Bastard Programmer from Hell :suss:

CCodeNewbie

Trying to work out why mu CPU is going mad at the moment, I'll get back to this in a bit..

CCodeNewbie

Sorted out the CPU thing, and so far haven't had any exceptions (after about an hour of testing). So far so good although I do need to ass a couple of modules back into the service. Now for my next problem...http://www.codeproject.com/Messages/4214946/Re-Getting-values-from-tasklist-exe-v-update.aspx[^]

Lost User

Nice :) I was kind of busy with a very tasty rabbit :D

Bastard Programmer from Hell :suss:

CCodeNewbie

Had a leg of lamb myself, roast potatoes, roast butternut, sweetish-sharp gravy... All good...

Lost User

CCodeNewbie wrote:

Had a leg of lamb myself, roast potatoes, roast butternut, sweetish-sharp gravy... All good...

Sounds like an equal festive meal - today, life's good :D

Bastard Programmer from Hell :suss:

CCodeNewbie

tell it like it is fellow gastronaut... and thanks for looking in on the other thing that's making me tear my hair out... Why do so may seemingly simple things have to be so complicated...