If in doubt: cast, cast and cast again

[Mardy Git]

My colleague found this and other horrors in a newish project. Bearing in mind that "Id" is a nullable int and result.ID is a regular int, who in their right mind would do this (object and function names have been changed to protect the incompetent):

protected Thing populateThing(DataRow dr)
{
Thing result = new Thing();
result.Id = int.Parse(dr["Id"].ToString());

BTW, note no handling of the case when "Id" is DBNULL. You can stop laughing now.

[PIEBALDconsult]

And with what did you replace it?

[Mardy Git]

I didn't it's not my project. My colleague was traumatised by this and many other code-crimes in the project, I'm hoping he'll recover soon :laugh:

[ZurdoDev]

I must be missing something. Doesn't dr["Id"] return an object?

There are only 10 types of people in the world, those who understand binary and those who don't.