Yes I know it was me who wrote that...
-
It's milliseconds, so it was just under 14 seconds, not minutes! ;P I'm running the code in LinqPad[^], and I've tried both with and without optimisations enabled, but it doesn't make a huge difference.
"These people looked deep within my soul and assigned me a number based on the order in which I joined." - Homer
-
Interesting: I'm also Win7/64, but .NET 4.0 rather than 4.5. Adding OrdinalIgnoreCase:
string string1 = File.ReadAllText(@"D:\\Temp\\MyText.txt"); string string2 = File.ReadAllText(@"D:\\Temp\\MyText.txt"); int x = 0; Stopwatch sw1 = new Stopwatch(); sw1.Start(); for (int i = 0; i < 1000; i++) { if (String.Equals(string1, string2, StringComparison.OrdinalIgnoreCase)) { x++; } } sw1.Stop(); Console.WriteLine(x); x = 0; Stopwatch sw2 = new Stopwatch(); sw2.Start(); for (int i = 0; i < 1000; i++) { if (String.Compare(string1, string2, true) == 0) { x++; } } sw2.Stop(); Console.WriteLine(x); x = 0; Stopwatch sw3 = new Stopwatch(); sw3.Start(); for (int i = 0; i < 1000; i++) { if (String.Compare(string1, string2, StringComparison.OrdinalIgnoreCase) == 0) { x++; } } sw3.Stop(); Console.WriteLine(x); Console.WriteLine("{0}:{1}:{2}", sw1.ElapsedMilliseconds, sw2.ElapsedMilliseconds,sw3.ElapsedMilliseconds);gives results similar to yours:
1000
1000
1000
1694:4087:1684I'm surprised there is such a difference in performance between our machines: mine isn't anywhere near state of the art - more state of the ark! :laugh:
You'll have to redo the test using the same textfile. I believe that's where most of the difference lies.
Politicians are always realistically manoeuvering for the next election. They are obsolete as fundamental problem-solvers. Buckminster Fuller
-
if (item.Substring(0, 3).ToLower() != "PF_")
[Head hangs in shame] :doh: I should have coded:
if (item.Substring(0, 3).ToLower() != "PF_".ToLower())
“That which can be asserted without evidence, can be dismissed without evidence.”
― Christopher Hitchens
-
if (item.Substring(0, 3).ToLower() != "PF_")
[Head hangs in shame] :doh: I should have coded:
if (item.Substring(0, 3).ToLower() != "PF_".ToLower())
“That which can be asserted without evidence, can be dismissed without evidence.”
― Christopher Hitchens
You really didn't think it through:
char p = item.charAt[0];
char f = item.charAt[1]
char u = item.charAt[1]
if (p == 'P' || p == 'p' &&
u == '_' &&
f == 'f' || p == 'F')
{
// you're good to go....
}speramus in juniperus
-
You really didn't think it through:
char p = item.charAt[0];
char f = item.charAt[1]
char u = item.charAt[1]
if (p == 'P' || p == 'p' &&
u == '_' &&
f == 'f' || p == 'F')
{
// you're good to go....
}speramus in juniperus
Nagy Vilmos wrote:
f == 'f' || p == 'F'
Well that's just cruel! If you're going to rewrite it, at least make sure it works. :doh:
"These people looked deep within my soul and assigned me a number based on the order in which I joined." - Homer
-
Yeah i know its in milliseconds but my upper processor forgot that after miliseconds seconds are next not minutes :D I am running it in debug mode with no optimisations.
Microsoft ... the only place where VARIANT_TRUE != true
"I am running it in debug mode with no optimisations." Why on earth try to benchmark code with no optimisations? Complete waste of time.
"If you don't fail at least 90 percent of the time, you're not aiming high enough." Alan Kay.
-
Nagy Vilmos wrote:
f == 'f' || p == 'F'
Well that's just cruel! If you're going to rewrite it, at least make sure it works. :doh:
"These people looked deep within my soul and assigned me a number based on the order in which I joined." - Homer
how about using the same character twice and the missing semicolons? :D
-
Interesting: I'm also Win7/64, but .NET 4.0 rather than 4.5. Adding OrdinalIgnoreCase:
string string1 = File.ReadAllText(@"D:\\Temp\\MyText.txt"); string string2 = File.ReadAllText(@"D:\\Temp\\MyText.txt"); int x = 0; Stopwatch sw1 = new Stopwatch(); sw1.Start(); for (int i = 0; i < 1000; i++) { if (String.Equals(string1, string2, StringComparison.OrdinalIgnoreCase)) { x++; } } sw1.Stop(); Console.WriteLine(x); x = 0; Stopwatch sw2 = new Stopwatch(); sw2.Start(); for (int i = 0; i < 1000; i++) { if (String.Compare(string1, string2, true) == 0) { x++; } } sw2.Stop(); Console.WriteLine(x); x = 0; Stopwatch sw3 = new Stopwatch(); sw3.Start(); for (int i = 0; i < 1000; i++) { if (String.Compare(string1, string2, StringComparison.OrdinalIgnoreCase) == 0) { x++; } } sw3.Stop(); Console.WriteLine(x); Console.WriteLine("{0}:{1}:{2}", sw1.ElapsedMilliseconds, sw2.ElapsedMilliseconds,sw3.ElapsedMilliseconds);gives results similar to yours:
1000
1000
1000
1694:4087:1684I'm surprised there is such a difference in performance between our machines: mine isn't anywhere near state of the art - more state of the ark! :laugh:
-
GuyThiebaut wrote:
I should have coded:
if (item.Substring(0, 3).ToLower() != "PF_".ToLower())
I hope that's a good example of sarcasm! ;P
if (string.Compare(item, 0, "PF_", 0, 3, StringComparison.OrdinalIgnoreCase) != 0)
"These people looked deep within my soul and assigned me a number based on the order in which I joined." - Homer
I've been always wondering why people just don't use string comparison functions with the case ignoring ability. Many languages have them. Why use ToLower or ToUpper if you don't really need that lowered string? One my colleague once told me that because of the belovers of ToUpper/ToLower the program he had to improve was doing its job during about 11 hours (the program was in C++)!!! After just replacing the appropriate functions with stricmp and similar ones (which compare ignoring the case) the program got the awesome performance boost: it managed to finish its execution in just one hour or such. Taste the difference!
lifecycle of a lifecycle of a lifecycle
