Why? Just why?

Nagy Vilmos

I know, lets keep re-comparing strings as it's cheap and easy. Thank you VB6; the gift that keeps on giving.

Public Function sConvertCase(sInString, lType As VbStrConv) As String
Dim sReturn As String
Dim lPos As Long
Dim lStart As Long
Dim lNext As Long
On Local Error Resume Next
sReturn = StrConv(sInString, lType)
If lType = vbProperCase Then
'check for This-That, O'Sumin ,McSumin, von Sumin, MacName (must be input as MacN...)
lPos = 0
Do
lStart = lPos + 1
lPos = InStr(lStart, sReturn, "Mc")
lNext = InStr(lStart, sReturn, "Mac")
If lNext > 0 And (lNext < lPos Or lPos = 0) Then
lPos = lNext
End If
lNext = InStr(lStart, sReturn, "O'")
If lNext > 0 And (lNext < lPos Or lPos = 0) Then
lPos = lNext
End If
lNext = InStr(lStart, sReturn, "Von ")
If lNext > 0 And (lNext < lPos Or lPos = 0) Then
lPos = lNext
End If
lNext = InStr(lStart, sReturn, "-")
If lNext > 0 And lNext < lPos Or lPos = 0 Then
lPos = lNext
End If

        If lPos = 0 Then
        ElseIf Mid$(sReturn, lPos, 1) = "-" Then
            Mid$(sReturn, lPos + 1, 1) = UCase$(Mid$(sReturn, lPos + 1, 1))
        ElseIf Mid$(sReturn, lPos, 2) = "Mc" Then
            Mid$(sReturn, lPos + 2, 1) = UCase$(Mid$(sReturn, lPos + 2, 1))
        ElseIf Mid$(sReturn, lPos, 3) = "Mac" Then
            If Mid$(sInString, lPos, 3) = "Mac" And Mid$(sInString, lPos + 3, 1) = UCase$(Mid$(sInString, lPos, 3)) Then
                Mid$(sReturn, lPos + 3, 1) = UCase$(Mid$(sReturn, lPos + 3, 1))
            End If
        ElseIf Mid$(sReturn, lPos, 2) = "O'" Then
            Mid$(sReturn, lPos + 2, 1) = UCase$(Mid$(sReturn, lPos + 2, 2))
        ElseIf Mid$(sReturn, lPos, 4) = "Von " Then
            Mid$(sReturn, lPos, 1) = "v"
        End If
    Loop While lPos > 0
End If

Done:
sConvertCase = sReturn
End Function

Kornfeld Eliyahu Peter

I can't see how it's connected to VB6 (or any language for that matter)...It's a pure human problem...

I'm not questioning your powers of observation; I'm merely remarking upon the paradox of asking a masked man who he is. (V)

Nagy Vilmos

No, I think on reflection I will continue to blame VB6. On the plus side, the code so far is not dead awful but it is visibly aged in the approach. No refactoring yet, I've agreed that we'll get it working with as little changes as possible [he laughs] and then look at more robust approaches.

Argonia

Nagy Vilmos wrote:

robust approaches

Like Format : ?

Microsoft ... the only place where VARIANT_TRUE != true

Chris Quinn

I wrote a very similar routine for Access many years ago, but it's better as it handles special cases like 'Macari' and 'Macy' which this routine would render as 'MacAri ' and 'MacY'

========================================================= I'm an optoholic - my glass is always half full of vodka. =========================================================

Nagy Vilmos

It still sucks monkey giblets

Chris Quinn

Here's my monkey giblets! I knew I still had it somewhere

Function Namecase(ByVal Sourcestring As String) As String
Dim ConvertChar As Integer, Jock As Integer
Dim StringLength As Integer, loopvar As Integer
Dim Newstring As String, Nextchar As String
Dim MacPos As Integer, Maclen As Integer, TestMac As String

On Error GoTo HandleErr
'Lowercase the whole string

StringLength = Len(Sourcestring)
Sourcestring = LCase$(Sourcestring)

For loopvar = 1 To StringLength
    'loop through the string letter by letter and
    'Convert the letter to uppercase if it is :-

    'The First Character in the text box
    ConvertChar = (loopvar = 1)

    'or character following space, hypen or apostrophe
    If Not ConvertChar Then ConvertChar = InStr(" -' ", Mid$(Sourcestring, (loopvar - 1), 1))

    ''or first character following a Mc for the Scots amongst us
    '    If Not ConvertChar Then
    '        If loopvar > 2 Then ConvertChar = (Mid$(SourceString, (loopvar - 2), 2) = "mc")
    '    End If

    Nextchar = Mid$(Sourcestring, loopvar, 1)
    If ConvertChar Then        'Convert character to uppercase if it meets the criteria
        Nextchar = UCase$(Nextchar)
    End If
    Newstring = Newstring & Nextchar        'Concatenate to destination
Next loopvar
TestMac = "|" & Newstring & "|"
MacPos = (InStr("|Machin|Macaskill|Mack|Mackie|Macaly|Macy|Mace|Macari|Macley|Macnamara|Mackay|", TestMac))
Jock = (MacPos = 0)
If Jock Then
    MacPos = InStr(Newstring, "Mac")
    Maclen = Len(Newstring)
    If MacPos > 0 Then
        Newstring = left$(Newstring, MacPos + 2) & (UCase$(Mid$(Newstring, MacPos + 3, 1)) & right$(Newstring, (Maclen - (MacPos + 3))))
    End If
    MacPos = InStr(Newstring, "Mc")
    If MacPos > 0 Then
        Newstring = left$(Newstring, MacPos + 1) & (UCase$(Mid$(Newstring, MacPos + 2, 1)) & right$(Newstring, (Maclen - (MacPos + 2))))
    End If
End If
Namecase = Newstring        'return the completed string

ExitHere:
Exit Function

' Error handling block added by Error Handler Add-In. DO NOT EDIT this block of code.
' Automatic error handler last updated at 09-21-2004 10:35:07   'ErrorHandler:$$D=09-21-2004    'ErrorHandler:$$T=10:35:07

HandleErr:
Select Case Err.Number
Case Else
MsgBox "Error " & Err.Number & ": " & Err.Description, vbCritic

Jorgen Andersson

How about McHammer? :doh:

Wrong is evil and must be defeated. - Jeff Ello[^]

Nagy Vilmos

Stop!

BobJanova

MacAskill and (definitely) MacNamara look like they are real Macs. This kind of code just implies your input and/or requirements are crap, though. People should be trusted to type their own name as they want it.

Nagy Vilmos

This goes back to a more elegant age where people couldn't use puters.

Jorgen Andersson

I'm Too Legit to Quit, I Don't Stop until I'm Gaining Momentum. So Feel My Power it's Hammertime.

Wrong is evil and must be defeated. - Jeff Ello[^]

Bernhard Hiller

Well, you have to run that code at the speed of MacH 2.

Chris Quinn

I have a Scottish friend called Macaskill who definitely does not capitalise internally, and the others were ascertained by looking through the telephone directories of several major British cities, though I think Macnamara[^] is a special special case - some capitalise and some don't

========================================================= I'm an optoholic - my glass is always half full of vodka. =========================================================

Dave Kreskowiak

You thought that code was bad?? How about this[^] little gem, written in C#?? I hate hearing crap about VB being the sole domain of horrible code.

A guide to posting questions on CodeProject

How to debug small programs
Dave Kreskowiak

Nagy Vilmos

No, that hurt.

BobJanova

Oh my word.

ZurdoDev

I'm surprised that CP didn't give an "Out of memory exception" when the OP posted that code. Whew!

There are only 10 types of people in the world, those who understand binary and those who don't.

Chris Quinn

As I always say, it ain't the tool that is used that's the problem, but the tool that uses it.

========================================================= I'm an optoholic - my glass is always half full of vodka. =========================================================

MarkTJohnson

Glad to see it takes care of MacHine