pascals triangle using user-define function use. Not working !

[Tarun Jha]

it works fine until the 3 column but in the 4th column it doesn't.

#include <conio.h>
#include <stdio.h>

long int factorial(int num);

int main(){

int row, col\_1, col\_2, i, j;
long int k;

printf("Enter the number of rows: \\n");
scanf("%d", &row);

col\_1 = row-2;

for(i=0; i<=row-1; i++){

	for(j=0; j<=col\_1; j++){
		printf(" ");
	}
	col\_1--;

	for(col\_2=0; col\_2<=i; col\_2++){

		k = factorial(i)/( factorial(i-col\_2) \* factorial(col\_2) ) ;
		printf(" %ld ", k);
	}
	printf("\\n");
}

return 0;

}

long int factorial(int num){

int total, i;

if(num==0 || num==1){
	total=1;

}else{
	
	total = 1;
	for(i=1; i<=num; i++){

		total = total\*num;
		num--;
	}
}

return total;

}

[Victor Nijegorodov]

And did you try to debug your code?

[Lost User]

for(j=0; j<=col_1; j++){

If col_1 has the value 4 in the above, you will actually perform 5 loops. Is that what you expect to happen?

[CPallini]

Your factorial function is flawed (a decrementing num as stop condition for i is really a bad choice), try replacing it with

long int factorial(int num)
{
long int fact = 1;
int i;
for (i=2; i<=num; ++i)
fact *= i;

return fact;
}

[Tarun Jha]

thank you :)

[CPallini]

You are welcome.