No Errors but wrong values on return?
-
I trying to get the Version of the ComCtl32.dll library, according to what I had read the version number for the ony on System 32 is 5.82 for legacy. This is the code I have created, and cant get any close to that, you will see extra lines of code for testing purposes, I maybe not even doing right the creation of the string for the dialog box, check it out please teach me /give some tips why I get wrong values. The Code ( Noticed the return 1 or 0 in case of no or errors ) and 1000 of thanks in advance. char NFILE[255]; DWORD dwSize, dwHandle = 0; VS_FIXEDFILEINFO * pvi; // Set the Path and file name strcpy(NFILE,"C:\\Windows\\System32\\ComCtl32.dll"); MessageBox(hWndMain,NFILE,"",MB_OK); // Testing // Check if we can reach the library. if(LoadLibrary(NFILE)==NULL) return 1; // If NULL there is an error // Check if Version info can retrieve and returns the size, in bytes, of that information. dwSize = GetFileVersionInfoSize( NFILE, NULL ); // Link the Version.lib Library first if(dwSize==0) MessageBox(hwnd,"Error","",MB_OK); // 0 means an Error // Get the file Information char *FDBUF = new char[dwSize]; if ( !GetFileVersionInfo( NFILE, dwHandle, dwSize, &FDBUF[ 0 ] ) ) { delete FDBUF; return 1; } // If not true, delete the buffer and return // Get the information into the VS_FIXEDFILEINFO Structure dwSize = sizeof(VS_FIXEDFILEINFO); if ( !VerQueryValue( & FDBUF[ 0 ], "\\", (LPVOID*)&pvi, (unsigned int*)&dwSize ) ) { delete FDBUF; return 1; } // Error processing the information structure. // Original values according to windows File Version is 5.82 on System32 for legacy // The 6.0 version lives in %SystemRoot%\winsxs. wsprintf(BUFF, "Version is %d",LOBYTE(LOWORD(pvi->dwProductVersionLS)),HIBYTE(LOWORD(pvi->dwProductVersionMS))); MessageBox(hwnd,BUFF,"The Value",MB_OK); // Display the value delete FDBUF; return 0;
-
I trying to get the Version of the ComCtl32.dll library, according to what I had read the version number for the ony on System 32 is 5.82 for legacy. This is the code I have created, and cant get any close to that, you will see extra lines of code for testing purposes, I maybe not even doing right the creation of the string for the dialog box, check it out please teach me /give some tips why I get wrong values. The Code ( Noticed the return 1 or 0 in case of no or errors ) and 1000 of thanks in advance. char NFILE[255]; DWORD dwSize, dwHandle = 0; VS_FIXEDFILEINFO * pvi; // Set the Path and file name strcpy(NFILE,"C:\\Windows\\System32\\ComCtl32.dll"); MessageBox(hWndMain,NFILE,"",MB_OK); // Testing // Check if we can reach the library. if(LoadLibrary(NFILE)==NULL) return 1; // If NULL there is an error // Check if Version info can retrieve and returns the size, in bytes, of that information. dwSize = GetFileVersionInfoSize( NFILE, NULL ); // Link the Version.lib Library first if(dwSize==0) MessageBox(hwnd,"Error","",MB_OK); // 0 means an Error // Get the file Information char *FDBUF = new char[dwSize]; if ( !GetFileVersionInfo( NFILE, dwHandle, dwSize, &FDBUF[ 0 ] ) ) { delete FDBUF; return 1; } // If not true, delete the buffer and return // Get the information into the VS_FIXEDFILEINFO Structure dwSize = sizeof(VS_FIXEDFILEINFO); if ( !VerQueryValue( & FDBUF[ 0 ], "\\", (LPVOID*)&pvi, (unsigned int*)&dwSize ) ) { delete FDBUF; return 1; } // Error processing the information structure. // Original values according to windows File Version is 5.82 on System32 for legacy // The 6.0 version lives in %SystemRoot%\winsxs. wsprintf(BUFF, "Version is %d",LOBYTE(LOWORD(pvi->dwProductVersionLS)),HIBYTE(LOWORD(pvi->dwProductVersionMS))); MessageBox(hwnd,BUFF,"The Value",MB_OK); // Display the value delete FDBUF; return 0;
You could get some ideas from this discussion: [c++ - Why does GetFileVersionInfo on kernel32.dll in windows 10 returns version 6.2? - Stack Overflow](https://stackoverflow.com/questions/38068477/why-does-getfileversioninfo-on-kernel32-dll-in-windows-10-returns-version-6-2) and this Chris Maunder's article: [Determining the version number of the Windows system libraries](https://www.codeproject.com/Articles/322/Determining-the-version-number-of-the-Windows-syst)
-
I trying to get the Version of the ComCtl32.dll library, according to what I had read the version number for the ony on System 32 is 5.82 for legacy. This is the code I have created, and cant get any close to that, you will see extra lines of code for testing purposes, I maybe not even doing right the creation of the string for the dialog box, check it out please teach me /give some tips why I get wrong values. The Code ( Noticed the return 1 or 0 in case of no or errors ) and 1000 of thanks in advance. char NFILE[255]; DWORD dwSize, dwHandle = 0; VS_FIXEDFILEINFO * pvi; // Set the Path and file name strcpy(NFILE,"C:\\Windows\\System32\\ComCtl32.dll"); MessageBox(hWndMain,NFILE,"",MB_OK); // Testing // Check if we can reach the library. if(LoadLibrary(NFILE)==NULL) return 1; // If NULL there is an error // Check if Version info can retrieve and returns the size, in bytes, of that information. dwSize = GetFileVersionInfoSize( NFILE, NULL ); // Link the Version.lib Library first if(dwSize==0) MessageBox(hwnd,"Error","",MB_OK); // 0 means an Error // Get the file Information char *FDBUF = new char[dwSize]; if ( !GetFileVersionInfo( NFILE, dwHandle, dwSize, &FDBUF[ 0 ] ) ) { delete FDBUF; return 1; } // If not true, delete the buffer and return // Get the information into the VS_FIXEDFILEINFO Structure dwSize = sizeof(VS_FIXEDFILEINFO); if ( !VerQueryValue( & FDBUF[ 0 ], "\\", (LPVOID*)&pvi, (unsigned int*)&dwSize ) ) { delete FDBUF; return 1; } // Error processing the information structure. // Original values according to windows File Version is 5.82 on System32 for legacy // The 6.0 version lives in %SystemRoot%\winsxs. wsprintf(BUFF, "Version is %d",LOBYTE(LOWORD(pvi->dwProductVersionLS)),HIBYTE(LOWORD(pvi->dwProductVersionMS))); MessageBox(hwnd,BUFF,"The Value",MB_OK); // Display the value delete FDBUF; return 0;
GESY wrote:
according to what I had read
Where did you read this information?
GESY wrote:
This is the code I have created, and cant get any close to that
So what value do you actually get? And have you checked the details in the property page of the DLL? I just ran your code on my Windows 10 system and get FileVersion of 5.82, and ProductVersion of 10.0, which I think is probably correct.
-
GESY wrote:
according to what I had read
Where did you read this information?
GESY wrote:
This is the code I have created, and cant get any close to that
So what value do you actually get? And have you checked the details in the property page of the DLL? I just ran your code on my Windows 10 system and get FileVersion of 5.82, and ProductVersion of 10.0, which I think is probably correct.
-
You could get some ideas from this discussion: [c++ - Why does GetFileVersionInfo on kernel32.dll in windows 10 returns version 6.2? - Stack Overflow](https://stackoverflow.com/questions/38068477/why-does-getfileversioninfo-on-kernel32-dll-in-windows-10-returns-version-6-2) and this Chris Maunder's article: [Determining the version number of the Windows system libraries](https://www.codeproject.com/Articles/322/Determining-the-version-number-of-the-Windows-syst)
-
I had see many examples on getting the windows version, this is not the case. Even Microsoft on on a web page show a funtion that does not work as it shows. Thank
GESY wrote:
I had see many examples on getting the windows version, this is not the case.
But you try at least some of them?
-
Most likely is the conversion or formatting string, I dont undertand much the wsprintf funtion, I get big weir numbers, nothing like what you said. If the code is correct, then have to be displaying on a message Box. Can you help with this? Thanks :) :) :)
GESY wrote:
...I get big weir numbers...
Such as?
GESY wrote:
If the code is correct, then have to be displaying on a message Box.
What exactly does this mean?
"One man's wage rise is another man's price increase." - Harold Wilson
"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons
"You can easily judge the character of a man by how he treats those who can do nothing for him." - James D. Miles
-
I trying to get the Version of the ComCtl32.dll library, according to what I had read the version number for the ony on System 32 is 5.82 for legacy. This is the code I have created, and cant get any close to that, you will see extra lines of code for testing purposes, I maybe not even doing right the creation of the string for the dialog box, check it out please teach me /give some tips why I get wrong values. The Code ( Noticed the return 1 or 0 in case of no or errors ) and 1000 of thanks in advance. char NFILE[255]; DWORD dwSize, dwHandle = 0; VS_FIXEDFILEINFO * pvi; // Set the Path and file name strcpy(NFILE,"C:\\Windows\\System32\\ComCtl32.dll"); MessageBox(hWndMain,NFILE,"",MB_OK); // Testing // Check if we can reach the library. if(LoadLibrary(NFILE)==NULL) return 1; // If NULL there is an error // Check if Version info can retrieve and returns the size, in bytes, of that information. dwSize = GetFileVersionInfoSize( NFILE, NULL ); // Link the Version.lib Library first if(dwSize==0) MessageBox(hwnd,"Error","",MB_OK); // 0 means an Error // Get the file Information char *FDBUF = new char[dwSize]; if ( !GetFileVersionInfo( NFILE, dwHandle, dwSize, &FDBUF[ 0 ] ) ) { delete FDBUF; return 1; } // If not true, delete the buffer and return // Get the information into the VS_FIXEDFILEINFO Structure dwSize = sizeof(VS_FIXEDFILEINFO); if ( !VerQueryValue( & FDBUF[ 0 ], "\\", (LPVOID*)&pvi, (unsigned int*)&dwSize ) ) { delete FDBUF; return 1; } // Error processing the information structure. // Original values according to windows File Version is 5.82 on System32 for legacy // The 6.0 version lives in %SystemRoot%\winsxs. wsprintf(BUFF, "Version is %d",LOBYTE(LOWORD(pvi->dwProductVersionLS)),HIBYTE(LOWORD(pvi->dwProductVersionMS))); MessageBox(hwnd,BUFF,"The Value",MB_OK); // Display the value delete FDBUF; return 0;
GESY wrote:
char *FDBUF = new char[dwSize];
If
dwSizeis0, this allocation is pointless. In other words, don't continue ifGetFileVersionInfoSize()did not return anything useful.GESY wrote:
wsprintf(BUFF, "Version is %d",LOBYTE(LOWORD(pvi->dwProductVersionLS)),HIBYTE(LOWORD(pvi->dwProductVersionMS)));
To match the Details tab of the Properties dialog, I'd think you'd want something similar to:
wsprintf(BUFF, _T("File version is %u.%u.%u.%u"), HIWORD(pvi->dwFileVersionMS), LOWORD(pvi->dwFileVersionMS), HIWORD(pvi->dwFileVersionLS), LOWORD(pvi->dwFileVersionLS));
…
wsprintf(BUFF, _T("Product version is %u.%u.%u.%u"), HIWORD(pvi->dwProductVersionMS), LOWORD(pvi->dwProductVersionMS), HIWORD(pvi->dwProductVersionLS), LOWORD(pvi->dwProductVersionLS));"One man's wage rise is another man's price increase." - Harold Wilson
"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons
"You can easily judge the character of a man by how he treats those who can do nothing for him." - James D. Miles
-
Most likely is the conversion or formatting string, I dont undertand much the wsprintf funtion, I get big weir numbers, nothing like what you said. If the code is correct, then have to be displaying on a message Box. Can you help with this? Thanks :) :) :)
-
I trying to get the Version of the ComCtl32.dll library, according to what I had read the version number for the ony on System 32 is 5.82 for legacy. This is the code I have created, and cant get any close to that, you will see extra lines of code for testing purposes, I maybe not even doing right the creation of the string for the dialog box, check it out please teach me /give some tips why I get wrong values. The Code ( Noticed the return 1 or 0 in case of no or errors ) and 1000 of thanks in advance. char NFILE[255]; DWORD dwSize, dwHandle = 0; VS_FIXEDFILEINFO * pvi; // Set the Path and file name strcpy(NFILE,"C:\\Windows\\System32\\ComCtl32.dll"); MessageBox(hWndMain,NFILE,"",MB_OK); // Testing // Check if we can reach the library. if(LoadLibrary(NFILE)==NULL) return 1; // If NULL there is an error // Check if Version info can retrieve and returns the size, in bytes, of that information. dwSize = GetFileVersionInfoSize( NFILE, NULL ); // Link the Version.lib Library first if(dwSize==0) MessageBox(hwnd,"Error","",MB_OK); // 0 means an Error // Get the file Information char *FDBUF = new char[dwSize]; if ( !GetFileVersionInfo( NFILE, dwHandle, dwSize, &FDBUF[ 0 ] ) ) { delete FDBUF; return 1; } // If not true, delete the buffer and return // Get the information into the VS_FIXEDFILEINFO Structure dwSize = sizeof(VS_FIXEDFILEINFO); if ( !VerQueryValue( & FDBUF[ 0 ], "\\", (LPVOID*)&pvi, (unsigned int*)&dwSize ) ) { delete FDBUF; return 1; } // Error processing the information structure. // Original values according to windows File Version is 5.82 on System32 for legacy // The 6.0 version lives in %SystemRoot%\winsxs. wsprintf(BUFF, "Version is %d",LOBYTE(LOWORD(pvi->dwProductVersionLS)),HIBYTE(LOWORD(pvi->dwProductVersionMS))); MessageBox(hwnd,BUFF,"The Value",MB_OK); // Display the value delete FDBUF; return 0;
You are using the wrong fields to get the values. The versions are stored in the following way:
dwProductVersionMS, contains the major fields, HIWORD, LOWORD e.g. 10, 0
dwProductVersionLS, contains the minor fields as above, e.g. 17134, 48Also you are only printing one number, but passing two values in your wsprintf statement. So it should be:
wsprintf(BUFF, "Version is %d.%d",HIWORD(pvi->dwProductVersionMS), LOWORD(pvi->dwProductVersionMS));
-
GESY wrote:
I had see many examples on getting the windows version, this is not the case.
But you try at least some of them?
-
You are using the wrong fields to get the values. The versions are stored in the following way:
dwProductVersionMS, contains the major fields, HIWORD, LOWORD e.g. 10, 0
dwProductVersionLS, contains the minor fields as above, e.g. 17134, 48Also you are only printing one number, but passing two values in your wsprintf statement. So it should be:
wsprintf(BUFF, "Version is %d.%d",HIWORD(pvi->dwProductVersionMS), LOWORD(pvi->dwProductVersionMS));
-
GESY wrote:
char *FDBUF = new char[dwSize];
If
dwSizeis0, this allocation is pointless. In other words, don't continue ifGetFileVersionInfoSize()did not return anything useful.GESY wrote:
wsprintf(BUFF, "Version is %d",LOBYTE(LOWORD(pvi->dwProductVersionLS)),HIBYTE(LOWORD(pvi->dwProductVersionMS)));
To match the Details tab of the Properties dialog, I'd think you'd want something similar to:
wsprintf(BUFF, _T("File version is %u.%u.%u.%u"), HIWORD(pvi->dwFileVersionMS), LOWORD(pvi->dwFileVersionMS), HIWORD(pvi->dwFileVersionLS), LOWORD(pvi->dwFileVersionLS));
…
wsprintf(BUFF, _T("Product version is %u.%u.%u.%u"), HIWORD(pvi->dwProductVersionMS), LOWORD(pvi->dwProductVersionMS), HIWORD(pvi->dwProductVersionLS), LOWORD(pvi->dwProductVersionLS));"One man's wage rise is another man's price increase." - Harold Wilson
"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons
"You can easily judge the character of a man by how he treats those who can do nothing for him." - James D. Miles
-
GESY wrote:
char *FDBUF = new char[dwSize];
If
dwSizeis0, this allocation is pointless. In other words, don't continue ifGetFileVersionInfoSize()did not return anything useful.GESY wrote:
wsprintf(BUFF, "Version is %d",LOBYTE(LOWORD(pvi->dwProductVersionLS)),HIBYTE(LOWORD(pvi->dwProductVersionMS)));
To match the Details tab of the Properties dialog, I'd think you'd want something similar to:
wsprintf(BUFF, _T("File version is %u.%u.%u.%u"), HIWORD(pvi->dwFileVersionMS), LOWORD(pvi->dwFileVersionMS), HIWORD(pvi->dwFileVersionLS), LOWORD(pvi->dwFileVersionLS));
…
wsprintf(BUFF, _T("Product version is %u.%u.%u.%u"), HIWORD(pvi->dwProductVersionMS), LOWORD(pvi->dwProductVersionMS), HIWORD(pvi->dwProductVersionLS), LOWORD(pvi->dwProductVersionLS));"One man's wage rise is another man's price increase." - Harold Wilson
"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons
"You can easily judge the character of a man by how he treats those who can do nothing for him." - James D. Miles
I tested your lines of code, and was great, finally I can see what I was looking for !!! I also thanks to the code you give me, I understand better that " wsprintf " function. Now front the programmers point of view, if you testing for a particular dll that you need to be some specific version, which one would you use? Using dwFileVersionMS, The result was 5.82 Using dwProductVersionMS The result was 6.1 And 1000 of thanks again!!! :-D
-
I tested your lines of code, and was great, finally I can see what I was looking for !!! I also thanks to the code you give me, I understand better that " wsprintf " function. Now front the programmers point of view, if you testing for a particular dll that you need to be some specific version, which one would you use? Using dwFileVersionMS, The result was 5.82 Using dwProductVersionMS The result was 6.1 And 1000 of thanks again!!! :-D
GESY wrote:
...which one would you use?
That would depend on if I wanted to know the product's version or the file's version. They're two different things.
"One man's wage rise is another man's price increase." - Harold Wilson
"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons
"You can easily judge the character of a man by how he treats those who can do nothing for him." - James D. Miles
-
You are using the wrong fields to get the values. The versions are stored in the following way:
dwProductVersionMS, contains the major fields, HIWORD, LOWORD e.g. 10, 0
dwProductVersionLS, contains the minor fields as above, e.g. 17134, 48Also you are only printing one number, but passing two values in your wsprintf statement. So it should be:
wsprintf(BUFF, "Version is %d.%d",HIWORD(pvi->dwProductVersionMS), LOWORD(pvi->dwProductVersionMS));
I tested your lines of code, and now I can see what I was looking for! Well done, plus you even give an explanation of the fields and what they do. ( You told me: dwProductVersionMS, contains the major fields, HIWORD, LOWORD e.g. 10, 0 dwProductVersionLS, contains the minor fields as above, e.g. 17134, 48 ) Excellent! I must ask you, you using %d but I had seen %u I believe one is for a integer and the other for a long ? Which one is correct or does that matter based on the function we testing? And finally in programming which value would you do a test for? Using dwFileVersionMS, The result was 5.82 Using dwProductVersionMS The result was 6.1 And before I go...... 1000 of thanks !!
-
I tested your lines of code, and now I can see what I was looking for! Well done, plus you even give an explanation of the fields and what they do. ( You told me: dwProductVersionMS, contains the major fields, HIWORD, LOWORD e.g. 10, 0 dwProductVersionLS, contains the minor fields as above, e.g. 17134, 48 ) Excellent! I must ask you, you using %d but I had seen %u I believe one is for a integer and the other for a long ? Which one is correct or does that matter based on the function we testing? And finally in programming which value would you do a test for? Using dwFileVersionMS, The result was 5.82 Using dwProductVersionMS The result was 6.1 And before I go...... 1000 of thanks !!
GESY wrote:
I must ask you, you using %d but I had seen %u I believe one is for a integer and the other for a long ?
%dis for a signed int and%uis for an unsigned int. SinceDWORDs andWORDs are both unsigned,%uis preferred."One man's wage rise is another man's price increase." - Harold Wilson
"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons
"You can easily judge the character of a man by how he treats those who can do nothing for him." - James D. Miles
-
I tested your lines of code, and now I can see what I was looking for! Well done, plus you even give an explanation of the fields and what they do. ( You told me: dwProductVersionMS, contains the major fields, HIWORD, LOWORD e.g. 10, 0 dwProductVersionLS, contains the minor fields as above, e.g. 17134, 48 ) Excellent! I must ask you, you using %d but I had seen %u I believe one is for a integer and the other for a long ? Which one is correct or does that matter based on the function we testing? And finally in programming which value would you do a test for? Using dwFileVersionMS, The result was 5.82 Using dwProductVersionMS The result was 6.1 And before I go...... 1000 of thanks !!
GESY wrote:
using %d but I had seen %u
That is for signed (
%d) or unsigned (%u) integers. For a long value you need to add the prefixlthus:long longValue = 1000000;
printf("long value: %ld\n", longValue);These format characters are explained in the MSDN documentation at Format Specification Syntax: printf and wprintf Functions[^].
Quote:
dwFileVersionMSordwProductVersionMS?Well it depends what you are testing for. The documentation for the specific product or library should tell you which one they are referring to, as they are usually different.
GESY wrote:
1000 of thanks
Happy to help, and I learned a few useful things in the process; so we both benefit.
-
GESY wrote:
using %d but I had seen %u
That is for signed (
%d) or unsigned (%u) integers. For a long value you need to add the prefixlthus:long longValue = 1000000;
printf("long value: %ld\n", longValue);These format characters are explained in the MSDN documentation at Format Specification Syntax: printf and wprintf Functions[^].
Quote:
dwFileVersionMSordwProductVersionMS?Well it depends what you are testing for. The documentation for the specific product or library should tell you which one they are referring to, as they are usually different.
GESY wrote:
1000 of thanks
Happy to help, and I learned a few useful things in the process; so we both benefit.
Hi, I had make a lot of test and learn a lot thanks to your help, I also testing now how to work with those values. And I was wondering is there a way to return the HIWORD(pvi->dwFileVersionMS) and LOWORD(pvi->dwFileVersionMS) as a single long value instead of converting to a string and then back to a number, the reason I said that is because I have been testing with this code below... // wsprintf(BUFF,("%u.%u"),HIWORD(pvi->dwProductVersionMS), LOWORD(pvi->dwProductVersionMS)); // double RTVAL=atof(BUFF); // if(RTVAL==6.1) MessageBox(hwnd,"It is 6.1","atof return",MB_OK); // Tested OK RTVAL was 6.1 // return RTVA; Thanks
-
GESY wrote:
using %d but I had seen %u
That is for signed (
%d) or unsigned (%u) integers. For a long value you need to add the prefixlthus:long longValue = 1000000;
printf("long value: %ld\n", longValue);These format characters are explained in the MSDN documentation at Format Specification Syntax: printf and wprintf Functions[^].
Quote:
dwFileVersionMSordwProductVersionMS?Well it depends what you are testing for. The documentation for the specific product or library should tell you which one they are referring to, as they are usually different.
GESY wrote:
1000 of thanks
Happy to help, and I learned a few useful things in the process; so we both benefit.
I posted to you, but I think I put it on the wrong place, here is the post... Hi, I had make a lot of test and learn a lot thanks to your help, I also testing now how to work with those values. And I was wondering is there a way to return the HIWORD(pvi->dwFileVersionMS) and LOWORD(pvi->dwFileVersionMS) as a single long value instead of converting to a string and then back to a number, the reason I said that is because I have been testing with this code below... // wsprintf(BUFF,("%u.%u"),HIWORD(pvi->dwProductVersionMS), LOWORD(pvi->dwProductVersionMS)); // double RTVAL=atof(BUFF); // if(RTVAL==6.1) MessageBox(hwnd,"It is 6.1","atof return",MB_OK); // Tested OK RTVAL was 6.1 // return RTVA; Thanks