You've got to be kidding me
-
So, my client purchased the DevExpress "experience" thing with source. So for giggles, I pick the TreeList control to look at. 189K in one .cs file. That's the first warning sign. And in that 189K, there is one single comment. The copyright notice/warning/threat. You're kidding me, right? I mean, this isn't the same code that they maintain inhouse, right? Please tell me it ain't so!!! They strip out all the comments when they ship the code, right? Christ. And people say open source is bad. I'll tell you something, open source is WAY BETTER than 189K in one .cs file that is TOTALLY UNDOCUMENTED. :omg: :wtf: X| :sigh: Marc
Some people believe what the bible says. Literally. At least [with Wikipedia] you have the chance to correct the wiki -- Jörgen Sigvardsson
People are just notoriously impossible. --DavidCrow
Marc Clifton wrote:
I'll tell you something, open source is WAY BETTER than 189K in one .cs file that is TOTALLY UNDOCUMENTED.
you are in grave danger! happy coding...when i have joined my company a year back... i have to go through over 4 lakhs line of c++ code with no design document.. no inline or un useful comment.. :(.. you can understand your tention :)
"Opinions are neither right nor wrong. I cannot change your opinion. I can, however, change what influences your opinion." - David Crow
cheers, Alok Gupta VC Forum Q&A :- I/ IV Support CRY- Child Relief and You
-
So, my client purchased the DevExpress "experience" thing with source. So for giggles, I pick the TreeList control to look at. 189K in one .cs file. That's the first warning sign. And in that 189K, there is one single comment. The copyright notice/warning/threat. You're kidding me, right? I mean, this isn't the same code that they maintain inhouse, right? Please tell me it ain't so!!! They strip out all the comments when they ship the code, right? Christ. And people say open source is bad. I'll tell you something, open source is WAY BETTER than 189K in one .cs file that is TOTALLY UNDOCUMENTED. :omg: :wtf: X| :sigh: Marc
Some people believe what the bible says. Literally. At least [with Wikipedia] you have the chance to correct the wiki -- Jörgen Sigvardsson
People are just notoriously impossible. --DavidCrow
Probably due to the code generator they use to convert from Java :)
Rocky <>< Latest Post: ASP.NET HttpException - Cannot use leading "..".. Blog: www.RockyMoore.com/TheCoder/[^]
-
If the code is clear, well formatted and well written, who cares? I've found modifying third party libraries generally a bad idea anyway since it makes merging patches and new versions a nightmare.
Anyone who thinks he has a better idea of what's good for people than people do is a swine. - P.J. O'Rourke
Joe Woodbury wrote:
If the code is clear, well formatted and well written, who cares?
There's NO excuse for not commenting your code.
"Why don't you tie a kerosene-soaked rag around your ankles so the ants won't climb up and eat your candy ass..." - Dale Earnhardt, 1997
-----
"...the staggering layers of obscenity in your statement make it a work of art on so many levels." - Jason Jystad, 10/26/2001 -
If the code is clear, well formatted and well written, who cares? I've found modifying third party libraries generally a bad idea anyway since it makes merging patches and new versions a nightmare.
Anyone who thinks he has a better idea of what's good for people than people do is a swine. - P.J. O'Rourke
Joe Woodbury wrote:
well formatted
It uses the style where you put the opening brace on the same line as the method, if, for, while, etc. Which is a style I threw out 20 years ago.
Joe Woodbury wrote:
well written
I'd say no. There methods with multiple return points. No assertions, no tests on parameters in public methods (take your pick on which philosophy you like, but I would expect at least one of these techniques to be utilized). There's probably more, but not worth investigating. Marc
Some people believe what the bible says. Literally. At least [with Wikipedia] you have the chance to correct the wiki -- Jörgen Sigvardsson
People are just notoriously impossible. --DavidCrow
-
If the code is clear, well formatted and well written, who cares? I've found modifying third party libraries generally a bad idea anyway since it makes merging patches and new versions a nightmare.
Anyone who thinks he has a better idea of what's good for people than people do is a swine. - P.J. O'Rourke
Joe Woodbury wrote:
If the code is clear, well formatted and well written, who cares?
Clear and well formatted according to whose coding standards and experience? For example, I have seen tons of older code from older Unix side, "Maddog-looking" developers with math degrees that looks completely clear and well written to them, but looks like pages of complex mathematical formulas to me due to the formatting and terse identifier names...! Also, you could have clear, well formatted, and "well written" code that is absolutely incorrect and buggy as hell. Without comments, how do you know what the code is supposed to be doing? Simply looking at raw code just tells you what the code is doing and how it is doing it, but not what it is supposed to be doing. Also, not everyone understands that
itermay be a prefix for an STL iterator, and it may not be clear if the increment operator being applied in a particular situation is supposed to be prefix, or if it is supposed to be postfix. Comments, when properly used to explain and/or describe the intent of the code, allow things like this to be spotted quickly and easily. Of course, this assumes that the comments are correct and written in accordance with whatever language is common for the target audience, but that is another problem in itself! :) :) Note: John "Maddog" Hall is a well-known Linux evangelist who used to work near me at DEC. I mean no offense to him, I have lots of respect for him, but if you have ever met him, you know what I mean by "Maddog-looking". Peace!-=- James
If you think it costs a lot to do it right, just wait until you find out how much it costs to do it wrong!
Avoid driving a vehicle taller than you and remember that Professional Driver on Closed Course does not mean your Dumb Ass on a Public Road!
DeleteFXPFiles & CheckFavorites (Please rate this post!) -
Without comments, it compiles faster. Have you ever looked at STL sources? :rolleyes:
Some of us walk the memory lane, others plummet into a rabbit hole
Tree in C# || Fold With Us! || sighistNo, it pre-processes faster! :) :laugh: :-D (Yes, I know that the two normally go hand-in-hand.) Peace!
-=- James
If you think it costs a lot to do it right, just wait until you find out how much it costs to do it wrong!
Avoid driving a vehicle taller than you and remember that Professional Driver on Closed Course does not mean your Dumb Ass on a Public Road!
DeleteFXPFiles & CheckFavorites (Please rate this post!) -
No, it pre-processes faster! :) :laugh: :-D (Yes, I know that the two normally go hand-in-hand.) Peace!
-=- James
If you think it costs a lot to do it right, just wait until you find out how much it costs to do it wrong!
Avoid driving a vehicle taller than you and remember that Professional Driver on Closed Course does not mean your Dumb Ass on a Public Road!
DeleteFXPFiles & CheckFavorites (Please rate this post!)James R. Twine wrote:
No, it pre-processes faster!
There is no pre-processor in C# But not having comments will make code (any language) compile or pre-process faster (i.e. less characters to look at, smaller files) Not that that is a good reason to not add comments...
-
So, my client purchased the DevExpress "experience" thing with source. So for giggles, I pick the TreeList control to look at. 189K in one .cs file. That's the first warning sign. And in that 189K, there is one single comment. The copyright notice/warning/threat. You're kidding me, right? I mean, this isn't the same code that they maintain inhouse, right? Please tell me it ain't so!!! They strip out all the comments when they ship the code, right? Christ. And people say open source is bad. I'll tell you something, open source is WAY BETTER than 189K in one .cs file that is TOTALLY UNDOCUMENTED. :omg: :wtf: X| :sigh: Marc
Some people believe what the bible says. Literally. At least [with Wikipedia] you have the chance to correct the wiki -- Jörgen Sigvardsson
People are just notoriously impossible. --DavidCrow
switch to opensource and linux then.
-
James R. Twine wrote:
No, it pre-processes faster!
There is no pre-processor in C# But not having comments will make code (any language) compile or pre-process faster (i.e. less characters to look at, smaller files) Not that that is a good reason to not add comments...
Yes, I was referring to C/C++-kind of setups where a seperate preprocessor step is used. And yes, I know that the lexing of the contents of a file is faster without ignored content (like comments or whitespace for that matter). (Actually, that is an interesting thought - comments are used by Intellisense/Codesense-type features...) Peace!
-=- James
If you think it costs a lot to do it right, just wait until you find out how much it costs to do it wrong!
Avoid driving a vehicle taller than you and remember that Professional Driver on Closed Course does not mean your Dumb Ass on a Public Road!
DeleteFXPFiles & CheckFavorites (Please rate this post!) -
switch to opensource and linux then.
Varindir Rajesh Mahdihar wrote:
switch to opensource and linux then.
The point is, I expected better source code quality from a toolkit one spends over a thousand of dollars on, per developer. I expected to learn neato things. As usual, my expectations lead to disappointments. Marc
Some people believe what the bible says. Literally. At least [with Wikipedia] you have the chance to correct the wiki -- Jörgen Sigvardsson
People are just notoriously impossible. --DavidCrow
There's NO excuse for not commenting your code. -- John Simmons / outlaw programmer -
No, it pre-processes faster! :) :laugh: :-D (Yes, I know that the two normally go hand-in-hand.) Peace!
-=- James
If you think it costs a lot to do it right, just wait until you find out how much it costs to do it wrong!
Avoid driving a vehicle taller than you and remember that Professional Driver on Closed Course does not mean your Dumb Ass on a Public Road!
DeleteFXPFiles & CheckFavorites (Please rate this post!):doh: you are right. 5 :)
Some of us walk the memory lane, others plummet into a rabbit hole
Tree in C# || Fold With Us! || sighist -
Varindir Rajesh Mahdihar wrote:
switch to opensource and linux then.
The point is, I expected better source code quality from a toolkit one spends over a thousand of dollars on, per developer. I expected to learn neato things. As usual, my expectations lead to disappointments. Marc
Some people believe what the bible says. Literally. At least [with Wikipedia] you have the chance to correct the wiki -- Jörgen Sigvardsson
People are just notoriously impossible. --DavidCrow
There's NO excuse for not commenting your code. -- John Simmons / outlaw programmerNow come one it cant be that bad, show the code to us ;) :P
-
Now come one it cant be that bad, show the code to us ;) :P
Here you go:
#region Copyright (c) 2000-2006 Developer Express Inc.
/*
{*******************************************************************}
{ }
{ Developer Express .NET Component Library }
{ XtraTreeList }
{ }
{ Copyright (c) 2000-2006 Developer Express Inc. }
{ ALL RIGHTS RESERVED }
{ }
{ The entire contents of this file is protected by U.S. and }
{ International Copyright Laws. Unauthorized reproduction, }
{ reverse-engineering, and distribution of all or any portion of }
{ the code contained in this file is strictly prohibited and may }
{ result in severe civil and criminal penalties and will be }
{ prosecuted to the maximum extent possible under the law. }
{ }
{ RESTRICTIONS }
{ }
{ THIS SOURCE CODE AND ALL RESULTING INTERMEDIATE FILES }
{ ARE CONFIDENTIAL AND PROPRIETARY TRADE }
{ SECRETS OF DEVELOPER EXPRESS INC. THE REGISTERED DEVELOPER IS }
{ LICENSED TO DISTRIBUTE THE PRODUCT AND ALL ACCOMPANYING .NET }
{ CONTROLS AS PART OF AN EXECUTABLE PROGRAM ONLY. }
{ }
{ THE SOURCE CODE CONTAINED WITHIN THIS FILE AND ALL RELATED }
{ FILES OR ANY PORTION OF ITS CONTENTS SHALL AT NO TIME BE }
{ COPIED, TRANSFERRED, SOLD, DISTRIBUTED, OR OTHERWISE MADE }
{ AVAILABLE TO OTHER INDIVIDUALS WITHOUT EXPRESS WRITTEN CONSENT }
{ AND PERMISSION FROM DEVELOPER EXPRESS INC. }
{ }
{ CONSULT THE END USER LICENSE AGREEMENT FOR INFORMATION ON }
{ ADDITIONAL RESTRICTIONS. }
{ }
{*******************************************************************}
*/
#endregion Copyright (c) 2000-2006 Developer Express Inc.;P Marc
-
Well.... I guess that depends ;-) There is a nice, fully managed, TreeControl which appeared recently on CodeProject! Otherwise I could email you mine too if you want. The one on code project has nice already build cell and a columned mode, whereas mine handle gracefully variable size cell.
Super Lloyd wrote:
The one on code project has nice already build cell and a columned mode
Yeah, I'm actually using it on a project. It's very cool.
Super Lloyd wrote:
whereas mine handle gracefully variable size cell.
I'd love to take a look. email away! :-D Marc
Some people believe what the bible says. Literally. At least [with Wikipedia] you have the chance to correct the wiki -- Jörgen Sigvardsson
People are just notoriously impossible. --DavidCrow
There's NO excuse for not commenting your code. -- John Simmons / outlaw programmer -
Super Lloyd wrote:
The one on code project has nice already build cell and a columned mode
Yeah, I'm actually using it on a project. It's very cool.
Super Lloyd wrote:
whereas mine handle gracefully variable size cell.
I'd love to take a look. email away! :-D Marc
Some people believe what the bible says. Literally. At least [with Wikipedia] you have the chance to correct the wiki -- Jörgen Sigvardsson
People are just notoriously impossible. --DavidCrow
There's NO excuse for not commenting your code. -- John Simmons / outlaw programmerFired to your GMail address!! The project might some clean up.... ;) It was ... planned!
