Get rid of this programmer

[Nemanja Trifunovic]

TheCoolestDudeInComputerWorld wrote:

if this is c++ why didn't he just go int_i++ its a lot faster then inc(int_i) (assuming he had his datatypes spelled right)

This is not C++. The private keyword cannot precede a function like this in C++. Looks like some C#/VB hybrid to me ;P But if it was C++, this function would most probably be optimized away by the compiler, so there would be no performance penalty.

---

Programming Blog utf8-cpp

[John R Shaw]

:laugh::laugh::laugh::laugh:

INTP "Program testing can be used to show the presence of bugs, but never to show their absence."Edsger Dijkstra

[Dave Kreskowiak]

It's entirely C#, not a hybrid.

Dave Kreskowiak Microsoft MVP Visual Developer - Visual Basic
     2006, 2007

[John R Shaw]

I would have to see the rest of their work before deciding, unless they where expected to work alone. A degree does not guarantee that someone is a programmer, only that they are capable of learning. Until recently I did not have a degree and I have been a programmer for years. I did already have an associates degree in electronics, but I was not a technician long enough to claim it as a profession. Here is an idea: Give them a personality test, that way you will have a better idea of how good a programmer they have the potential of becoming.

INTP "Program testing can be used to show the presence of bugs, but never to show their absence."Edsger Dijkstra

[Mike Dimmick]

C# doesn't have an integer keyword - it's Java. I'm fairly sure that java.lang.Integer is a class, not a straightforward value type - that's still called int. That would make an Integer the equivalent of a boxed int in C#/.NET.

Stability. What an interesting concept. -- Chris Maunder

[Shog9 0]

More proof that an idiot can make any language look like VB... ;P

----

It appears that everybody is under the impression that I approve of the documentation. You probably also blame Ken Burns for supporting slavery.

--Raymond Chen on MSDN

[Dave Kreskowiak]

Whoops! Missed that one. Comes from using primarily VB.NET to do all my work.

Dave Kreskowiak Microsoft MVP Visual Developer - Visual Basic
     2006, 2007

[Nemanja Trifunovic]

Mike Dimmick wrote:

C# doesn't have an integer keyword - it's Java.

Just like C#, Java doesn't have integer keyword. Here is the list of Java keywords.[^]

---

Programming Blog utf8-cpp

[StevenWalsh]

I didn't consider the possibility, maybe he just had a brain fart? I can remember writing what i was thinking one or two times. Granted he SHOULD have read over his code before presenting it... I can say I've presented code to my boss without fully testing it out of stupid young confidence.

[Teashirt2]

Bunch of bruts aren't you. Have some mercy for the young and inexperienced. In my work I sometimes see more creative work from people you would have fired.

[John R Shaw]

That was more than a brain fart, but it would have done what it was designed to do. It was just a foolish thing to do. I have never had a boss that could really understand the code without me explaining it to him. Matter of fact I cust one for saying I did not understand the question, when the fact was he did not understand the answer. Of course they had just hired him and he eventialy learned that I knew what I was doing.

INTP "Program testing can be used to show the presence of bugs, but never to show their absence."Edsger Dijkstra

[PIEBALDconsult]

May have used # define integer int or typedef

[alex barylski]

Did you offer him/her constructive criticism? :) Otherwise they'll continue writing bad code. IMHO it's not really bad code as from what I can tell it looks valid. More bad practice, which is something only experience can teach you - at least osmething that trivial as I don't think Fowler, etc address those kind of design choices. :P

I'm finding the only constant in software development is change it self.

[Nemanja Trifunovic]

PIEBALDconsult wrote:

May have used # define integer int or typedef

C# does not have them although using can be used for that purpose in a file scope, but I honestly think that the OP made a typo. Maybe he should be fired, rather than the poor beginner programmer :)

---

Programming Blog utf8-cpp

[Lost User]

eunderwo00 wrote:

I hired a programmer right out of school.

Right out of Jr. High? :laugh: How did the "programmer" pass his classes with skills like that?

█▒▒▒▒▒██▒█▒██ █▒█████▒▒▒▒▒█ █▒██████▒█▒██ █▒█████▒▒▒▒▒█ █▒▒▒▒▒██▒█▒██

[asifali]

I think he should be informed of his mistake, encouragement might help him to overcome his deficiencies. A.A.

asif

[sprint_sport]

So what is wrong with it? Use of private before a return declaration? I'm unfamiliar with this syntax. In C++, private and public are used in the class declaration, not the function definitions.

[Marcus J Smith]

eunderwo00 wrote:

private integer inc(integer int_i) { integer int_j=int_i+1; return int_j; }

Ok this is an unnecessary function but what is the reason you let him go?

---

CleaKO

"I think you'll be okay here, they have a thin candy shell. 'Surprised you didn't know that.'" - Tommy (Tommy Boy)
"Fill it up again! Fill it up again! Once it hits your lips, it's so good!" - Frank the Tank (Old School)

[Dave Kreskowiak]

I'm wondering if he wrote additional functions for the remaining operators.

Dave Kreskowiak Microsoft MVP Visual Developer - Visual Basic
     2006, 2007

[Rei Miyasaka]

Nah, it's valid pseudo-pseudocode.