Get rid of this programmer

[Shog9 0]

More proof that an idiot can make any language look like VB... ;P

----

It appears that everybody is under the impression that I approve of the documentation. You probably also blame Ken Burns for supporting slavery.

--Raymond Chen on MSDN

[Dave Kreskowiak]

Whoops! Missed that one. Comes from using primarily VB.NET to do all my work.

Dave Kreskowiak Microsoft MVP Visual Developer - Visual Basic
     2006, 2007

[Nemanja Trifunovic]

Mike Dimmick wrote:

C# doesn't have an integer keyword - it's Java.

Just like C#, Java doesn't have integer keyword. Here is the list of Java keywords.[^]

---

Programming Blog utf8-cpp

[StevenWalsh]

I didn't consider the possibility, maybe he just had a brain fart? I can remember writing what i was thinking one or two times. Granted he SHOULD have read over his code before presenting it... I can say I've presented code to my boss without fully testing it out of stupid young confidence.

[Teashirt2]

Bunch of bruts aren't you. Have some mercy for the young and inexperienced. In my work I sometimes see more creative work from people you would have fired.

[John R Shaw]

That was more than a brain fart, but it would have done what it was designed to do. It was just a foolish thing to do. I have never had a boss that could really understand the code without me explaining it to him. Matter of fact I cust one for saying I did not understand the question, when the fact was he did not understand the answer. Of course they had just hired him and he eventialy learned that I knew what I was doing.

INTP "Program testing can be used to show the presence of bugs, but never to show their absence."Edsger Dijkstra

[PIEBALDconsult]

May have used # define integer int or typedef

[alex barylski]

Did you offer him/her constructive criticism? :) Otherwise they'll continue writing bad code. IMHO it's not really bad code as from what I can tell it looks valid. More bad practice, which is something only experience can teach you - at least osmething that trivial as I don't think Fowler, etc address those kind of design choices. :P

I'm finding the only constant in software development is change it self.

[Nemanja Trifunovic]

PIEBALDconsult wrote:

May have used # define integer int or typedef

C# does not have them although using can be used for that purpose in a file scope, but I honestly think that the OP made a typo. Maybe he should be fired, rather than the poor beginner programmer :)

---

Programming Blog utf8-cpp

[Lost User]

eunderwo00 wrote:

I hired a programmer right out of school.

Right out of Jr. High? :laugh: How did the "programmer" pass his classes with skills like that?

█▒▒▒▒▒██▒█▒██ █▒█████▒▒▒▒▒█ █▒██████▒█▒██ █▒█████▒▒▒▒▒█ █▒▒▒▒▒██▒█▒██

[asifali]

I think he should be informed of his mistake, encouragement might help him to overcome his deficiencies. A.A.

asif

[sprint_sport]

So what is wrong with it? Use of private before a return declaration? I'm unfamiliar with this syntax. In C++, private and public are used in the class declaration, not the function definitions.

[Marcus J Smith]

eunderwo00 wrote:

private integer inc(integer int_i) { integer int_j=int_i+1; return int_j; }

Ok this is an unnecessary function but what is the reason you let him go?

---

CleaKO

"I think you'll be okay here, they have a thin candy shell. 'Surprised you didn't know that.'" - Tommy (Tommy Boy)
"Fill it up again! Fill it up again! Once it hits your lips, it's so good!" - Frank the Tank (Old School)

[Dave Kreskowiak]

I'm wondering if he wrote additional functions for the remaining operators.

Dave Kreskowiak Microsoft MVP Visual Developer - Visual Basic
     2006, 2007

[Rei Miyasaka]

Nah, it's valid pseudo-pseudocode.

[John M Drescher]

Captain See Sharp wrote:

How did the "programmer" pass his classes with skills like that?

To me this code shows that the programmer does not know c++ java or has not used it in a very long time.

Last modified: 2hrs 11mins after originally posted --

John

[sprint_sport]

I can only think that int_j should be explicitly assigned a value at declaration, before actual use in case int_i is passed unassigned, hence : private integer inc(integer int_i) { integer int_j=0; int_j=int_i+1; return int_j; }

[Marcus J Smith]

sprint_sport wrote:

I can only think that int_j should be explicitly assigned a value at declaration, before actual use in case int_i is passed unassigned, hence : private integer inc(integer int_i) { integer int_j=0; int_j=int_i+1; return int_j; }

Integers by default are 0 when declared just as booleans are false, strings are nothing, etc...

---

CleaKO

"I think you'll be okay here, they have a thin candy shell. 'Surprised you didn't know that.'" - Tommy (Tommy Boy)
"Fill it up again! Fill it up again! Once it hits your lips, it's so good!" - Frank the Tank (Old School)

[GTuritto]

Regarding the language used by the programmer. I don't see anything bad with the code, at least he had the concept of private. Also this in reality doesn't speak so good from you and not from the "programmer right out from school". Are many thing to take in consideration. He probably thought it will impress you doing this, or he didn't realize what he did. Also one of the obligation of seasoned Developers, is help the new generations to going the right direction. Are thousands more other aspects that I take in consideration to say if someone it's or not a good programmer, than simple review his code.

[Dave Kreskowiak]

GTuritto wrote:

I don't see anything bad with the code,

Can you name just a single use for this function that isn't covered by the "+" operator?

Dave Kreskowiak Microsoft MVP Visual Developer - Visual Basic
     2006, 2007