Brace style
-
Which one you prefer ?
if{
//do something
}Or
if
{
//do something
}
printf("Navaneeth!!") www.w3hearts.com
Navaneeth.Which one you prefer ? if{//do something} Or if{//do something}
Actually, I prefer: if (condition == true) { // do something }
WE ARE DYSLEXIC OF BORG. Refutance is systile. Your a$$ will be laminated.
-
Some years ago I had an application switch over to me so I could fix all the (major) problems with it. By the time I was through all the problems where fixed and all the files where reformatted to my liking. I was still maintaining that code and adding to it till the day I walked out, and it has not been changed since.
INTP "Program testing can be used to show the presence of bugs, but never to show their absence."Edsger Dijkstra
if you left how do you know the code never was changed since then?
-- You have to explain to them [VB coders] what you mean by "typed". their first response is likely to be something like, "Of course my code is typed. Do you think i magically project it onto the screen with the power of my mind?" --- John Simmons / outlaw programmer
-
The latter. The former is used only by miscreants and rogues. :suss:
----
i hope you are feeling sleepy for people not calling you by the same.
--BarnaKol on abusive words
Personally, I think it's a question of who really cares as long as you can read the thing and it kinda depends on what language I'm working with. For C# I pretty much go with the second example but as a complete heretic who occasionally finds himself coding Perl in a hurry, I've been known to chuck both examples and go with the following blasphemy:
do something if true;Or even (gasp!):do something unless true;Both of which eliminate the braces altogether... :-D -
Wrap it in pre tags to keep the formatting intact.
-- You have to explain to them [VB coders] what you mean by "typed". their first response is likely to be something like, "Of course my code is typed. Do you think i magically project it onto the screen with the power of my mind?" --- John Simmons / outlaw programmer
dan neely wrote:
Wrap it in pre tags to keep the formatting intact.
:doh: I put   in for spaces. BTW, it was fun getting the   to print out!
WE ARE DYSLEXIC OF BORG. Refutance is systile. Your a$$ will be laminated.
-
I agree with this. if (...) { DoThis(); } ...is just so much more readable when I've got a fairly long and complicated function. I also really despise this: if (...) { DoThis(); } else if { DoThat(); } else { DoThose(); } Extend the DoThis(), DoThat(), and DoThose() to something long, and you'll be going "huh? where the hell are my opening and closing braces?"
That speaks louder than anything I could say on the subject. I have actually seen that done and was quick to untie the knots so I could understand what it was supposed to be doing. :laugh:
INTP "Program testing can be used to show the presence of bugs, but never to show their absence."Edsger Dijkstra
-
I like the latter as well, but I don't feel I am in any position to say it's more 'proper'. I would confine my public opinion of what is proper programming is only to ensure all braces match.
As far as "proper" I sorta meant it as a tongue in cheek remark. The style to which one uses brace formatting is really up to the user. It has its merits either way.
All things being equal, tommorrow will never equal today
-
If you keep the lines short then the former works just fine (experience), but the longer the lines get the more likely it is that you will fail to notice the opening brace. Modern environments allow you to place the cursor at a brace and use a key combination to find the other one, but you should not need to do that. If you failed to place the brace after the test statement then you may be confused as to why the compiler generated and error until you search for the missing brace, provided you realize that is the problem. Indention tells you it is supposed to be a block but the compiler does not recognize your intensions, only the facts. When you look at a test statement with an opening brace following it on the next line, you know that it is being blocked out. Of course symmetry also helps when reading the code. I resonantly spent a lot of time programming in ‘.Net’ and the default code generation produced very long lines and it is even hard to stay away from them in standard C++. Which means that unless you start wrapping your test statements to the next line (which I do and hate doing), then the opening brace may not be visible (if you use the former style). If you look at it from a strictly indention point of view then the brace would be in the wrong place because it would be inconsistent with the rest of the code. What all that bull amounts to is that the latter makes it easier to read and debug the code, and I have done enough of both to drive myself a little crazy.
INTP "Program testing can be used to show the presence of bugs, but never to show their absence."Edsger Dijkstra
I whole heartedly agree with you. I personally feel that code like
if (something == true)
{
// blah blah
// blah blah blah
do
{
// blabbity blab
// ditto
if (somthingelse == false)
{
// initialize the flux capacitor
}
} while (somecodition == true);
}makes the blocks of code more clear. Just my personal preference. ;)
WE ARE DYSLEXIC OF BORG. Refutance is systile. Your a$$ will be laminated.
-
You said it about a lot of contractors there - no-brainer.:laugh: Mind you, I must admit that I cheat - I let the IDE take care of it for me. BTW - my personal preference is braces on a new line.
Deja View - the feeling that you've seen this post before.
-
I have never written anything significant in Perl.
You're not missing anything. Dreadful language.
Kevin
-
if you left how do you know the code never was changed since then?
-- You have to explain to them [VB coders] what you mean by "typed". their first response is likely to be something like, "Of course my code is typed. Do you think i magically project it onto the screen with the power of my mind?" --- John Simmons / outlaw programmer
Because I lied, there were some minor changes. I know because I was contracted to make them. One of the reasons I left was because they did not really need a full time coder any more, they just did not know it. They did not hire anyone to take my place and any time there is a question or they need something modified they call me. About the only thing that took more than a couple of hours to do was when a third party control failed to work on XP and I had to write a replacement from scratch (the 3rd party did not exist any more). Now if only they would contract me to produce a modern version of the two main programs I would be a happy camper, because they would not let me do it when I worked there.
INTP "Program testing can be used to show the presence of bugs, but never to show their absence."Edsger Dijkstra
-
Which one you prefer ?
if{
//do something
}Or
if
{
//do something
}
printf("Navaneeth!!") www.w3hearts.com
http://astyle.sourceforge.net/[^] because I prefer:
style=ansi indent-namespacesand one of the senior programmers keeps us from having a style guide by demandingstyle=ansi indent-bracketsOf course there is programmer brawl number #2342: how do you make a header comment (I was told yesterday there is one and only one way). :)_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb)
-
Which one you prefer ?
if{
//do something
}Or
if
{
//do something
}
printf("Navaneeth!!") www.w3hearts.com
God of course intended that there be only one bracing style. All other expose one as a programmer who has fallen from the path. The pattern for an 'if' is as follows:
if (conditional) { // waste not, want not: don't waste vertical space
statement(s) // note the indention, this clearly identifies these statements as
// belonging to the if
} // note the indention again, this closes the if logic, it is the
// end of the existing block, not the beginning of a new oneOf course heritics abound, but my place in "code vault store" is assured (ya have to be a fan of STTNG Klingon afterlife to get that one). Go forth and spread the glad tiding and good bracings and do not hesitate to cntl-K cntl-D the code of the unbelievers. ;):laugh: Brace Zealot -- modified at 11:16 Thursday 17th May, 2007
-
Which one you prefer ?
if{
//do something
}Or
if
{
//do something
}
printf("Navaneeth!!") www.w3hearts.com
if
{
//lalala
//doing_stuff
}old fashioned i guess
Ericos Georgiades
-
God of course intended that there be only one bracing style. All other expose one as a programmer who has fallen from the path. The pattern for an 'if' is as follows:
if (conditional) { // waste not, want not: don't waste vertical space
statement(s) // note the indention, this clearly identifies these statements as
// belonging to the if
} // note the indention again, this closes the if logic, it is the
// end of the existing block, not the beginning of a new oneOf course heritics abound, but my place in "code vault store" is assured (ya have to be a fan of STTNG Klingon afterlife to get that one). Go forth and spread the glad tiding and good bracings and do not hesitate to cntl-K cntl-D the code of the unbelievers. ;):laugh: Brace Zealot -- modified at 11:16 Thursday 17th May, 2007
grgran wrote:
Of course heritics abound, but my place in "code vault store"
Brandishes steel cored foam cluebat. *BIFFF* *BIFFF* *BIFFF* *BIFFF* *BIFFF* *BIFFF* *BIFFF* *BIFFF*
-- You have to explain to them [VB coders] what you mean by "typed". their first response is likely to be something like, "Of course my code is typed. Do you think i magically project it onto the screen with the power of my mind?" --- John Simmons / outlaw programmer
-
Pete O`Hanlon wrote:
BTW - my personal preference is braces on a new line
We agree on something then;)
.net is a box of never ending treasures, every day I get find another gem.
I'm even more anal about bracing. I use if(blah) { stuff even if only one line. Notice the indent; } That way I can line up the if, else etc and eyeball for closing braces to see which block the code is in. I find: if(blah) { dgf dfd df df fdf dfdf } else { dfd df df dsf dg } method annoying. You are forced to look at the first character of each line to see if it is the brace your looking for, rather than scan down the column where the brace your looking for should be.
-
I'm even more anal about bracing. I use if(blah) { stuff even if only one line. Notice the indent; } That way I can line up the if, else etc and eyeball for closing braces to see which block the code is in. I find: if(blah) { dgf dfd df df fdf dfdf } else { dfd df df dsf dg } method annoying. You are forced to look at the first character of each line to see if it is the brace your looking for, rather than scan down the column where the brace your looking for should be.
-
Oh crap, I got slaughtered by white space removal. The buggers ;) Corrected
if(blah) { stuff even if one line. Notice the indent. } -
This is interesting, I myself used the latter, but in the programming course Ive done they teach using the former, although Ive gotten used to programming like that i still dont like it and prefer having the extra line breaks
-
Which one you prefer ?
if{
//do something
}Or
if
{
//do something
}
printf("Navaneeth!!") www.w3hearts.com
Prefer? My preference is irrelevant. The ancients said it best.. when in Rome, do as the Romans. When in someone else's code, match their style. Unless you're writing C#, in which case, Caesar Gates's cronies have decreed how we will all do our braces, spacing and indentation. Fine, whatever, we've all got more important things to do than to fight it anyway.. right? After 20 or so years of reading all different brace styles, you'll pretty much cease to see them anyway.. as long as it is consistent throughout a file. Remember, Rome-Romans. What should you do in completely new files? Sure, fine, whatever. Which do I do in new files? The second one. Why? Because I was asked to. Why was I asked to? I dunno, probably because someone had a harder time of understanding the code with the first one. Why do I bother to comply? Because they claim it helps them.
patbob
-
Which one you prefer ?
if{
//do something
}Or
if
{
//do something
}
printf("Navaneeth!!") www.w3hearts.com
How about letting the development environment decide based on who you are... that way if you like it one way and your colleague likes it formatted another way, you both can have your cake and eat it too.