whats is the mistacks in code thats insert data in oracle with vb.net

[idsanjeevjha]

Code for data insertion is not work reported error

<script runat="server">

Sub submit(sender As Object, e As EventArgs)
dim dbconn,sql,dbcomm,dbread
dbconn=New ODbcConnection("dsn=oracle;uid=starter;pwd=starter;")
dbconn.Open()
sql="SELECT \* FROM students"
dbcomm=New ODbcCommand(sql,dbconn)
dbread=dbcomm.ExecuteReader()
customers.DataSource=dbread
customers.DataBind()
dbread.Close()
dim isql,idbread,idbcomm
isql="Insert Into students(id,first\_name,last\_name,major) values (@fname,@id,@lname,@major)"
idbcomm=new odbccommand(isql,dbconn)
idbcomm.Parameters.Add( "@fname",fname.text)
idbcomm.Parameters.Add( "@id",id.Text)
idbcomm.Parameters.Add( "@lname",lname.Text)
idbcomm.Parameters.Add( "@major",major.Text)
idbcomm.ExecuteNonQuery()

dbconn.Close()	
End Sub

</script>

but this code is excuted success fully

<script runat="server">
Sub submit(sender As Object, e As EventArgs)
Dim strConnectionString As String
strConnectionString = "Dsn=oracle;uid=gatepass;pwd=gp"
Dim pConn As New OdbcConnection(strConnectionString)
'Dim pSELECTQUERY As String = "SELECT *from students"
Dim pSELECTQUERY As String = "SELECT distinct PassMaster.*,passarea_dtls.passarea,empmaster.empname,visitormaster.visitorname FROM PassMaster, VisitorMaster,passarea_dtls,empmaster where passmaster.authorisationby=empmaster.empno and passmaster.passareacode=passarea_dtls.passareacode and PassMaster.PassIssueDt + PassMaster.validity -1 >= trunc(sysdate) and PassMaster.PassID = VisitorMaster.PassID and PassMaster.AuthorisationStatus = 'YES' and passmaster.PASSISSUESTATUS not like 'YES' order by PassMaster.PassID"
Dim adapter As New OdbcDataAdapter(pSELECTQUERY, pConn)
Dim DS As DataSet = New DataSet()
adapter.Fill(DS)
Repeater1.DataSource = ds
pConn.Close()
adapter.Dispose()
Repeater1.DataBind()
End Sub
</script>

i don't know whats is the reason any help ?

sanjeev

[Chinners]

try changing

isql="Insert Into students(id,first_name,last_name,major) values (@fname,@id,@lname,@major)"

to

isql="Insert Into students(id,first_name,last_name,major) values (@id,@fname,@lname,@major)"

[idsanjeevjha]

Thanks for your reply Please see my last post where i already changed some code problems in commented code is not worked but other code thats is not commented is inserted data successfully. so i wants to know whats is the mistakes in my commented code thanks

sanjeev

[Chinners]

Yep. I spotted that after I had posted the Q.