Simple loop problems ??
-
Hi folks !! I'm new here and am trying to teach myself (and loving it) c# !! Can anyone please give me an insght as to why the two loops i've listed only ever seem to execute once ? I've put message boxes in to see how many times it's going round and it always seems to show 0 ? I'm confused !! Many thanks (i think you'll all be seeing a LOT more of me ! Neil
//first loop
int tempnum = 0;
while (tempnum < 10)
{
newLoc.X = oldLocation.X + 5;
newLoc.Y = oldLocation.Y;if (newLoc.X >= (250))
{
newLoc = oldLocation;
}// close inner if statement
cat.Location = newLoc;
tempnum = tempnum + 1;
MessageBox.Show(tempnum.ToString());
}//second loop
for (int i = 0; i < 20; i++)
{
newLoc.Y = oldLocation.Y - 5;
newLoc.X = oldLocation.X;if (newLoc.Y <= (2))
{
newLoc = oldLocation;
}// close inner if statement
cat.Location = newLoc;
MessageBox.Show("" + i);
} -
Hi folks !! I'm new here and am trying to teach myself (and loving it) c# !! Can anyone please give me an insght as to why the two loops i've listed only ever seem to execute once ? I've put message boxes in to see how many times it's going round and it always seems to show 0 ? I'm confused !! Many thanks (i think you'll all be seeing a LOT more of me ! Neil
//first loop
int tempnum = 0;
while (tempnum < 10)
{
newLoc.X = oldLocation.X + 5;
newLoc.Y = oldLocation.Y;if (newLoc.X >= (250))
{
newLoc = oldLocation;
}// close inner if statement
cat.Location = newLoc;
tempnum = tempnum + 1;
MessageBox.Show(tempnum.ToString());
}//second loop
for (int i = 0; i < 20; i++)
{
newLoc.Y = oldLocation.Y - 5;
newLoc.X = oldLocation.X;if (newLoc.Y <= (2))
{
newLoc = oldLocation;
}// close inner if statement
cat.Location = newLoc;
MessageBox.Show("" + i);
}Welcome! Quickly looking, nothing in the code you provided seems to create such effect. Perhaps there's something you didn't include. Anyway, use debugger to see what actually happens and watches to observe the value of tempnum. Mika
The need to optimize rises from a bad design. My articles[^]
-
Hi folks !! I'm new here and am trying to teach myself (and loving it) c# !! Can anyone please give me an insght as to why the two loops i've listed only ever seem to execute once ? I've put message boxes in to see how many times it's going round and it always seems to show 0 ? I'm confused !! Many thanks (i think you'll all be seeing a LOT more of me ! Neil
//first loop
int tempnum = 0;
while (tempnum < 10)
{
newLoc.X = oldLocation.X + 5;
newLoc.Y = oldLocation.Y;if (newLoc.X >= (250))
{
newLoc = oldLocation;
}// close inner if statement
cat.Location = newLoc;
tempnum = tempnum + 1;
MessageBox.Show(tempnum.ToString());
}//second loop
for (int i = 0; i < 20; i++)
{
newLoc.Y = oldLocation.Y - 5;
newLoc.X = oldLocation.X;if (newLoc.Y <= (2))
{
newLoc = oldLocation;
}// close inner if statement
cat.Location = newLoc;
MessageBox.Show("" + i);
}This is horrible code. The while loop is pointless, just use a for loop. Also, comments like 'close inner if statement' are ridiculous.
nlowdon wrote:
newLoc.Y <= (2)
(2) is superfluous, just 2 is fine.
nlowdon wrote:
"" + i)
Use i.ToString() There is no way I can see for that second loop to not run 20 times. The first loop also looks fine, but the code is obviously harder to read.
Christian Graus Driven to the arms of OSX by Vista.
-
Welcome! Quickly looking, nothing in the code you provided seems to create such effect. Perhaps there's something you didn't include. Anyway, use debugger to see what actually happens and watches to observe the value of tempnum. Mika
The need to optimize rises from a bad design. My articles[^]
Another Welcome :) I agree with Mr. Mika ... really there is nothing in your code should produce such behaviour ... showing 0 (for first loop for example) means that the
tempnum = tempnum + 1;statement is not executed and in such a case you will loop for infinity ! and each time the box will show you 0 !!! and will not show once as you mentioned ..!Sincerely Samer Abu Rabie Note: Please remember to rate this post to help others whom reading it.
-
This is horrible code. The while loop is pointless, just use a for loop. Also, comments like 'close inner if statement' are ridiculous.
nlowdon wrote:
newLoc.Y <= (2)
(2) is superfluous, just 2 is fine.
nlowdon wrote:
"" + i)
Use i.ToString() There is no way I can see for that second loop to not run 20 times. The first loop also looks fine, but the code is obviously harder to read.
Christian Graus Driven to the arms of OSX by Vista.
Thanks for the 1st two replys guys - as for the 3rd ?? Like i said - i am new to this and statements like "this is horrble code" doesn't really help ! Anyway, it maybe something to do with where or how the method is being called ? I'll keep trying !! Thanks again
-
Thanks for the 1st two replys guys - as for the 3rd ?? Like i said - i am new to this and statements like "this is horrble code" doesn't really help ! Anyway, it maybe something to do with where or how the method is being called ? I'll keep trying !! Thanks again
nlowdon wrote:
statements like "this is horrble code" doesn't really help
While the statement may not have been very diplomatic, it is helpful once you push a bruised ego out of the way. Christian did point out area where the code could be improved. Yes, the
whileloop in this instance would be better served as afor(;;)loop. The comment on "close inner if statement" isn't as useful as it might appear. A more normal practice is to repeat the condition if you are going to have a comment there so you know what that code block was doing. However, if you need to do that then you might want to think about refactoring your code. If your code blocks are so long that you can no longer see the orginal opening condition then it is an indication that the code is poorly written. Also, tools such as DevExpress's CodeRush and Refactor will decorate your IDE so it makes it very clear what bracket belongs to what if/while/using/method/class/namespace/etc. The issue regarding the brackets around the 2 is also valid. If it was a more complex expression and you wanted to be explicit about the order of precidence then fair enough, however for a simple literal value it is overkill. If you've moved from a language that needed that then it will take a little time to get used to not needing it. It took me some time to move from some habits I picked up over the years when writing C++ code after I moved to C#. Finally the issue over"" + iis also valid. It reminds me of when I first started programming and I wanted a negative number I would write0 - 10until I realised I could just write-10. Don't take the comments too personally, Christian is trying to help in his own way.Developer Day Scotland 2 - Free community conference Recent blog posts: *Throwing Exceptions *Training Developers * Method hiding or overriding - or the difference between new and virtual
-
nlowdon wrote:
statements like "this is horrble code" doesn't really help
While the statement may not have been very diplomatic, it is helpful once you push a bruised ego out of the way. Christian did point out area where the code could be improved. Yes, the
whileloop in this instance would be better served as afor(;;)loop. The comment on "close inner if statement" isn't as useful as it might appear. A more normal practice is to repeat the condition if you are going to have a comment there so you know what that code block was doing. However, if you need to do that then you might want to think about refactoring your code. If your code blocks are so long that you can no longer see the orginal opening condition then it is an indication that the code is poorly written. Also, tools such as DevExpress's CodeRush and Refactor will decorate your IDE so it makes it very clear what bracket belongs to what if/while/using/method/class/namespace/etc. The issue regarding the brackets around the 2 is also valid. If it was a more complex expression and you wanted to be explicit about the order of precidence then fair enough, however for a simple literal value it is overkill. If you've moved from a language that needed that then it will take a little time to get used to not needing it. It took me some time to move from some habits I picked up over the years when writing C++ code after I moved to C#. Finally the issue over"" + iis also valid. It reminds me of when I first started programming and I wanted a negative number I would write0 - 10until I realised I could just write-10. Don't take the comments too personally, Christian is trying to help in his own way.Developer Day Scotland 2 - Free community conference Recent blog posts: *Throwing Exceptions *Training Developers * Method hiding or overriding - or the difference between new and virtual
Hi There, Thanks for the reply, a little 'diplomacy' goes a long way. In my original posting there was actually 2 instances of a similar loop - the 2nd being a 'for' loop. Unfortunately that doesn't work either :confused: The extensive commenting of code mearly helps me at the moment as i am very new to this (as the simple coding may suggest - lol) Anyway - tried lots now and still no joy - the execution of the method is called by a timer which i've slowed right down also - no joy. Thanks again for the post - nice to see a fellow 'Jock' ??
-
Hi folks !! I'm new here and am trying to teach myself (and loving it) c# !! Can anyone please give me an insght as to why the two loops i've listed only ever seem to execute once ? I've put message boxes in to see how many times it's going round and it always seems to show 0 ? I'm confused !! Many thanks (i think you'll all be seeing a LOT more of me ! Neil
//first loop
int tempnum = 0;
while (tempnum < 10)
{
newLoc.X = oldLocation.X + 5;
newLoc.Y = oldLocation.Y;if (newLoc.X >= (250))
{
newLoc = oldLocation;
}// close inner if statement
cat.Location = newLoc;
tempnum = tempnum + 1;
MessageBox.Show(tempnum.ToString());
}//second loop
for (int i = 0; i < 20; i++)
{
newLoc.Y = oldLocation.Y - 5;
newLoc.X = oldLocation.X;if (newLoc.Y <= (2))
{
newLoc = oldLocation;
}// close inner if statement
cat.Location = newLoc;
MessageBox.Show("" + i);
} -
Hi folks !! I'm new here and am trying to teach myself (and loving it) c# !! Can anyone please give me an insght as to why the two loops i've listed only ever seem to execute once ? I've put message boxes in to see how many times it's going round and it always seems to show 0 ? I'm confused !! Many thanks (i think you'll all be seeing a LOT more of me ! Neil
//first loop
int tempnum = 0;
while (tempnum < 10)
{
newLoc.X = oldLocation.X + 5;
newLoc.Y = oldLocation.Y;if (newLoc.X >= (250))
{
newLoc = oldLocation;
}// close inner if statement
cat.Location = newLoc;
tempnum = tempnum + 1;
MessageBox.Show(tempnum.ToString());
}//second loop
for (int i = 0; i < 20; i++)
{
newLoc.Y = oldLocation.Y - 5;
newLoc.X = oldLocation.X;if (newLoc.Y <= (2))
{
newLoc = oldLocation;
}// close inner if statement
cat.Location = newLoc;
MessageBox.Show("" + i);
}}// close inner if statement
cat.Location = newLoc;
MessageBox.Show("" + i);Should be
("" + i.ToString()); -
Hi folks !! I'm new here and am trying to teach myself (and loving it) c# !! Can anyone please give me an insght as to why the two loops i've listed only ever seem to execute once ? I've put message boxes in to see how many times it's going round and it always seems to show 0 ? I'm confused !! Many thanks (i think you'll all be seeing a LOT more of me ! Neil
//first loop
int tempnum = 0;
while (tempnum < 10)
{
newLoc.X = oldLocation.X + 5;
newLoc.Y = oldLocation.Y;if (newLoc.X >= (250))
{
newLoc = oldLocation;
}// close inner if statement
cat.Location = newLoc;
tempnum = tempnum + 1;
MessageBox.Show(tempnum.ToString());
}//second loop
for (int i = 0; i < 20; i++)
{
newLoc.Y = oldLocation.Y - 5;
newLoc.X = oldLocation.X;if (newLoc.Y <= (2))
{
newLoc = oldLocation;
}// close inner if statement
cat.Location = newLoc;
MessageBox.Show("" + i);
}Maybe there are some exception? just check it!