A real Mess

PIEBALDconsult

Yeah, so it's long and wide, some methods have to be; what have you replaced it with?

peterchen

:rolleyes:

Don't attribute to stupidity what can be equally well explained by buerocracy.
My latest article | Linkify!| FoldWithUs! | sighist

Thomas Weller 0

So what? As far as I've seen it, all the magic numbers are commented (not totally sure, somewhere in the middle my eyes began to bleed)... :laugh: Regards Thomas

www.thomas-weller.de Programming today is a race between software engineers striving to build bigger and better idiot-proof programs, and the Universe trying to produce bigger and better idiots. So far, the Universe is winning.
Programmer - an organism that turns coffee into software.

Bernard Laplace

Nothing yet, the problem is the whole application is badly design, so from my point of view it is better to build a new application from scratch.

Dave Kreskowiak

:WTF: is your problem?? All I did was bring up something I saw in a documentery about artillery and it's reliablilty and maintainability, and you think I'm picking on the Germans? Dude, back then, during the war, they tended to over-engineer their weapons. That's all I'm saying...

A guide to posting questions on CodeProject[^]
Dave Kreskowiak Microsoft MVP Visual Developer - Visual Basic
2006, 2007, 2008

ed welch

Well, that code brings me back to the 90's. Typical "journeyman programmer" production. The journeyman programmer doesn't care about software engineering or improving the skills in their trade, just hack away until it works... eventually they work up their way to be project manager and leave the crap to someone else to maintain X|. Don't let it get to you too much the first 20 years are the worse :laugh:

NormDroid

Very well put :) I wouldn't even use the word 'programmer' in the same sense as VB, more like 'user'. VB - curse of many bad project implementations.

Software Kinetics (requires SL3 beta) - Moving software

Bernard Laplace

Hoorray! I fixed it!!!! Well when the procedure found a time over 4 hours for a day it used to skip the next records for that day :doh: I am so proud that I can not resist to post the fixed method :-D

Sub GridView1_RowDataBound(ByVal sender As Object, ByVal e As GridViewRowEventArgs)
Dim i As Integer
Dim r As Integer
Dim sEmployeeID As String
Dim dDateFrom As DateTime = Convert.ToDateTime(DateFrom.Text)
Dim dDateTo As DateTime = Convert.ToDateTime(DateTo.Text)
Dim dDateCurrent As Date = dDateFrom
Dim sConsultantInfoDay As String = ""
Dim sProjectInfo1 As String = ""
Dim sProjectInfo2 As String = ""
Dim sProject As String = ""
Dim DateEnd As Object
Dim DaysNoticeExt As Object
Dim sColor1 As String = "#FFFFFF"
Dim sColor2 As String = "#FFFFFF"
Dim PreviousColor As String = "#FFFFFF"
Dim hl As New HyperLink
Dim lb As New Label
Dim lb2 As New Label
Dim iDayofWeek As Integer
Dim sDayName As String
Dim sExit As String
Dim bgColor As Drawing.Color
Dim sColorProject As String = "#FFFFFF"
Dim bTSClosed As Boolean
Dim Hours As Double
Dim HoursClientMonth As Double
Dim HoursMonth As Double
Dim HoursTBPMonth As Double
Dim HoursInternalMonth As Double
Dim DailyHoursTBP As Double
Dim TSID As Integer
Dim oEmpDateStart As Object
Dim oEmpDateEnd As Object
Dim bClientProject As Boolean = False
Dim bProjectFoundMonth As Boolean = False
Dim WorkPerc As Double
Dim sHoliday As String
Dim ProjectID As Integer
Dim TotalHoursMonth As Double
Dim dteRenewal, dteCurrentNotification, dteCurrentEndProj As DateTime
Dim intRenewalCpt As Integer = -1
Dim blnIsFirstTime As Boolean = True
Dim intRenewsEachNbMonths As Integer

	Select Case e.Row.RowType
		Case DataControlRowType.Header
			Dim iMonth As Integer
			e.Row.Cells(0).Visible = False
			e.Row.Cells(1).Visible = False
			e.Row.Cells(2).Visible = False
			e.Row.Cells(3).Visible = False
			e.Row.Cells(iColDaysStart - 1).Width = ConsultantColWidth
			e.Row.Cells(iColDaysStart - 1).Text = sEmployeeHeader
			e.Row.Cells(iColDaysStart - 1).Font.Size = iFontSizeEmployees
			e.Row.Cells(iColDaysStart - 1).Font.Bold = True
			e.Row.Cells(iColDaysStart - 1).ForeColor = Drawing.Color.White
			e.Row.Cells(iColDaysStart - 1).BackColor = Drawing.Color.DarkBlue

			i = iColDaysStart
			Do While dDateCurrent <= dDateTo
				iMonth = dDateCurrent.Month
				sDayName = WeekdayName(DatePart("w", dDateCurrent), True, Microsoft.V

sucram

I got a headache after the word Sub in line 1 and stopped reading. :laugh:

Vita est usquequaque virtus victus ut plenus. Ego non sum semper iustus tamen Ego sum nunquam nefas!

DoctorMick

In fairness, a lot of bad implementations are done in other languages, I dare say there are as many shocking apps developed in C# as there are VB.Net.

Alessandro Bernardi

I agree with you ;) And what's about an italian like me? Would you like me to speak about spaghetti code? :laugh: Luckly italian people does not always write spaghetti as they eat!! :P

Vozzie2

14 more to go, i hope i'll make it... :~

It feels good to learn and achieve

Jeroen De Dauw

Did the author die? ;P

GSoC 2009 student for SMW! --- My little forums: http://code.bn2vs.com --- 70 72 6F 67 72 61 6D 6D 69 6E 67 20 34 20 6C 69 66 65!

0x3c0

That depends. Did the person who maintained the code have his home address?

Between the idea And the reality Between the motion And the act Falls the Shadow

Bernard Laplace

Well I have his home address, but I believe he's already dead, at least his brain was when he 'coded' this.

Bernard Laplace

French code smells cheese and has blue spots... :laugh:

Lost User

I have seen worse Russian code. Best thing to do with monster code is to use some reflections on it.

Lost User

LMAO! :laugh: Ever here the American sing-a-long: 'On top of old meatball...'

Dan Neely

Arnaud Lhopiteau wrote:

I am so proud that I can not resist to post the fixed method Big Grin

No, 571 line long method can be considered non-broken.

It is a truth universally acknowledged that a zombie in possession of brains must be in want of more brains. -- Pride and Prejudice and Zombies

Bernard Laplace

Well I can see I am not the only one practicing irony here, am I?