How to get today's date
-
I've inherited one of the worst code-bases I've ever seen in 9 years of .netting. I've spotted this little gem scattered like gingerbread-crumbs thoughout the code:
DateTime date = DateTime.Parse(DateTime.Now.Date.ToString("dd/MM/yyyy"));
To make it worse this code is repeated not just in different classes but in the same class :wtf: To add piquancy, the variable being set is just called date, not today or todaysDate or something bit more sensible, so I had to work out what it did. I still can't work out why, I only know it makes my eyes bleed....
-
I've inherited one of the worst code-bases I've ever seen in 9 years of .netting. I've spotted this little gem scattered like gingerbread-crumbs thoughout the code:
DateTime date = DateTime.Parse(DateTime.Now.Date.ToString("dd/MM/yyyy"));
To make it worse this code is repeated not just in different classes but in the same class :wtf: To add piquancy, the variable being set is just called date, not today or todaysDate or something bit more sensible, so I had to work out what it did. I still can't work out why, I only know it makes my eyes bleed....
Amazing bad code!!!!!!
-
I've inherited one of the worst code-bases I've ever seen in 9 years of .netting. I've spotted this little gem scattered like gingerbread-crumbs thoughout the code:
DateTime date = DateTime.Parse(DateTime.Now.Date.ToString("dd/MM/yyyy"));
To make it worse this code is repeated not just in different classes but in the same class :wtf: To add piquancy, the variable being set is just called date, not today or todaysDate or something bit more sensible, so I had to work out what it did. I still can't work out why, I only know it makes my eyes bleed....
One thing it will do is break if you run it in America. If the date is 5th March 2009, the ToString conversion will give you 05/03/2009. But because no format is specified on the Parse method, it will assume the default date format, which in America is MM/dd/yyyy. So 05/03/2009 will get converted to 3rd May 2009. My guess would be this is someone from a Java background because java.util.Date doesn't have an equivalent to .NET's DateTime.Date property, and it's not so easy to strip off the time part. The correct way to do it in Java is with java.util.Calendar, but lots of people use this sort of clumsy format/parse approach.
-
One thing it will do is break if you run it in America. If the date is 5th March 2009, the ToString conversion will give you 05/03/2009. But because no format is specified on the Parse method, it will assume the default date format, which in America is MM/dd/yyyy. So 05/03/2009 will get converted to 3rd May 2009. My guess would be this is someone from a Java background because java.util.Date doesn't have an equivalent to .NET's DateTime.Date property, and it's not so easy to strip off the time part. The correct way to do it in Java is with java.util.Calendar, but lots of people use this sort of clumsy format/parse approach.
Yup, a java-based programmer was involved, I did suspect something like that (there is lots of other Java-inspired "Goodness" in the code). I would have excused him, but he did manage to use DateTime.Now.Date as part of this coding beauty. Ho hum.
-
Yup, a java-based programmer was involved, I did suspect something like that (there is lots of other Java-inspired "Goodness" in the code). I would have excused him, but he did manage to use DateTime.Now.Date as part of this coding beauty. Ho hum.
Tell him about properties; people unfamiliar with Windows are propably not familiar with properties either. Java didn't have them when I used it. :)
Luc Pattyn [Forum Guidelines] [My Articles]
The quality and detail of your question reflects on the effectiveness of the help you are likely to get. Show formatted code inside PRE tags, and give clear symptoms when describing a problem.
-
Yup, a java-based programmer was involved, I did suspect something like that (there is lots of other Java-inspired "Goodness" in the code). I would have excused him, but he did manage to use DateTime.Now.Date as part of this coding beauty. Ho hum.
It happens both ways round. Because the syntax for Java and C# is very similar, it's easy to switch between the two languages and end up coding things inappropriately.
-
Tell him about properties; people unfamiliar with Windows are propably not familiar with properties either. Java didn't have them when I used it. :)
Luc Pattyn [Forum Guidelines] [My Articles]
The quality and detail of your question reflects on the effectiveness of the help you are likely to get. Show formatted code inside PRE tags, and give clear symptoms when describing a problem.
Java still does not have properties. There was a big argument about whether they should be added to Java 7 or not (the next version due next year) and in the end they were not included. Personally, I don't miss properties in Java, possibly because I write mostly server-side Java apps, and properties are more useful for simple binding to UI controls. You can do that with Java beans and Swing but it's a bit messy.
-
I've inherited one of the worst code-bases I've ever seen in 9 years of .netting. I've spotted this little gem scattered like gingerbread-crumbs thoughout the code:
DateTime date = DateTime.Parse(DateTime.Now.Date.ToString("dd/MM/yyyy"));
To make it worse this code is repeated not just in different classes but in the same class :wtf: To add piquancy, the variable being set is just called date, not today or todaysDate or something bit more sensible, so I had to work out what it did. I still can't work out why, I only know it makes my eyes bleed....
Ha, I come from a Java background so my first thought was "What's wrong with it" :) I switched over to .NET about 7 years ago. so now I would write it like this:
DateTime.Now.Date.ToShortDateString() -
Ha, I come from a Java background so my first thought was "What's wrong with it" :) I switched over to .NET about 7 years ago. so now I would write it like this:
DateTime.Now.Date.ToShortDateString()7 years of .NET experience and you don't see what's wrong with it? Or is there a joke in there that I'm missing? (Monday morning, brain not fully engaged yet)
-
Ha, I come from a Java background so my first thought was "What's wrong with it" :) I switched over to .NET about 7 years ago. so now I would write it like this:
DateTime.Now.Date.ToShortDateString()Actually
DateTime date = DateTime.Parse(DateTime.Now.Date.ToString("dd/MM/yyyy"));can be written asDateTime date = DateTime.Now.Date;No strings involved! You'll also notice that the original coder acutally had the "DateTime.Now.Date" bit, which they then cast to a string (in UK date format) that is subsequently parsed back to a DateTime. -
7 years of .NET experience and you don't see what's wrong with it? Or is there a joke in there that I'm missing? (Monday morning, brain not fully engaged yet)
Drink some coffee, it was a joke :laugh:
-
Actually
DateTime date = DateTime.Parse(DateTime.Now.Date.ToString("dd/MM/yyyy"));can be written asDateTime date = DateTime.Now.Date;No strings involved! You'll also notice that the original coder acutally had the "DateTime.Now.Date" bit, which they then cast to a string (in UK date format) that is subsequently parsed back to a DateTime.In some parts of the world the original statement and yours will not yield the same result. And the original may throw an exception, yours wouldn't. So we need to see the specs first. :)
Luc Pattyn [Forum Guidelines] [My Articles]
The quality and detail of your question reflects on the effectiveness of the help you are likely to get. Show formatted code inside PRE tags, and give clear symptoms when describing a problem.
-
I've inherited one of the worst code-bases I've ever seen in 9 years of .netting. I've spotted this little gem scattered like gingerbread-crumbs thoughout the code:
DateTime date = DateTime.Parse(DateTime.Now.Date.ToString("dd/MM/yyyy"));
To make it worse this code is repeated not just in different classes but in the same class :wtf: To add piquancy, the variable being set is just called date, not today or todaysDate or something bit more sensible, so I had to work out what it did. I still can't work out why, I only know it makes my eyes bleed....
TimeSpan keyDays = new TimeSpan(this.FooLicenceKeyHolder.FooLicence.Licence.LicenceExpiryDate.Ticks);
TimeSpan nowDays = new TimeSpan(System.DateTime.Now.Ticks);int daysLeft = keyDays.Days - nowDays.Days;
xacc.ide
IronScheme - 1.0 beta 4 - out now!
((λ (x) `(,x ',x)) '(λ (x) `(,x ',x))) -
TimeSpan keyDays = new TimeSpan(this.FooLicenceKeyHolder.FooLicence.Licence.LicenceExpiryDate.Ticks);
TimeSpan nowDays = new TimeSpan(System.DateTime.Now.Ticks);int daysLeft = keyDays.Days - nowDays.Days;
xacc.ide
IronScheme - 1.0 beta 4 - out now!
((λ (x) `(,x ',x)) '(λ (x) `(,x ',x)))LOL. That example makes me want to fold. :)
Chris Meech I am Canadian. [heard in a local bar] In theory there is no difference between theory and practice. In practice there is. [Yogi Berra]
-
LOL. That example makes me want to fold. :)
Chris Meech I am Canadian. [heard in a local bar] In theory there is no difference between theory and practice. In practice there is. [Yogi Berra]
Chris Meech wrote:
makes me want to fold.
Head-slamming the desk is a form of folding, not? (but seriously, that code still exists in our code base, not wrong, but funny ;P )
xacc.ide
IronScheme - 1.0 beta 4 - out now!
((λ (x) `(,x ',x)) '(λ (x) `(,x ',x))) -
I've inherited one of the worst code-bases I've ever seen in 9 years of .netting. I've spotted this little gem scattered like gingerbread-crumbs thoughout the code:
DateTime date = DateTime.Parse(DateTime.Now.Date.ToString("dd/MM/yyyy"));
To make it worse this code is repeated not just in different classes but in the same class :wtf: To add piquancy, the variable being set is just called date, not today or todaysDate or something bit more sensible, so I had to work out what it did. I still can't work out why, I only know it makes my eyes bleed....
-
TimeSpan keyDays = new TimeSpan(this.FooLicenceKeyHolder.FooLicence.Licence.LicenceExpiryDate.Ticks);
TimeSpan nowDays = new TimeSpan(System.DateTime.Now.Ticks);int daysLeft = keyDays.Days - nowDays.Days;
xacc.ide
IronScheme - 1.0 beta 4 - out now!
((λ (x) `(,x ',x)) '(λ (x) `(,x ',x)))For a moment there I thought you were measuring your licence expiry in ticks. "This evaluation licence will expire in 342,827,400 nanoseconds."
-
TimeSpan keyDays = new TimeSpan(this.FooLicenceKeyHolder.FooLicence.Licence.LicenceExpiryDate.Ticks);
TimeSpan nowDays = new TimeSpan(System.DateTime.Now.Ticks);int daysLeft = keyDays.Days - nowDays.Days;
xacc.ide
IronScheme - 1.0 beta 4 - out now!
((λ (x) `(,x ',x)) '(λ (x) `(,x ',x))):wtf: :omg: :-D Yep, that takes the biscuit. What's the conversion rate of Idiotions into Imbiciles (our local dim-wit currency)?
-
Actually
DateTime date = DateTime.Parse(DateTime.Now.Date.ToString("dd/MM/yyyy"));can be written asDateTime date = DateTime.Now.Date;No strings involved! You'll also notice that the original coder acutally had the "DateTime.Now.Date" bit, which they then cast to a string (in UK date format) that is subsequently parsed back to a DateTime.Well spotted. Have some brick points.
-
I've inherited one of the worst code-bases I've ever seen in 9 years of .netting. I've spotted this little gem scattered like gingerbread-crumbs thoughout the code:
DateTime date = DateTime.Parse(DateTime.Now.Date.ToString("dd/MM/yyyy"));
To make it worse this code is repeated not just in different classes but in the same class :wtf: To add piquancy, the variable being set is just called date, not today or todaysDate or something bit more sensible, so I had to work out what it did. I still can't work out why, I only know it makes my eyes bleed....
:omg: My jaw hurts from having it smack the desktop.