what counts for bad code? finding its level...... [modified]

[Dario Solera]

As a start, bad code is code that contains grammar errors in comments. Also, code that is ugly formatted is really bad.

If you truly believe you need to pick a mobile phone that "says something" about your personality, don't bother. You don't have a personality. A mental illness, maybe - but not a personality. - Charlie Brooker My Photos/CP Flickr Group - ScrewTurn Wiki

[DaveyM69]

Dario Solera wrote:

code that contains grammar errors in comments.

I came across one of these the other day from MS in all the OnEvent methods in the BackgroundWorker (C# at least), for the e parameter: "An System.EventArgs that contains the event data."

Dave
Generic BackgroundWorker - My latest article!
BTW, in software, hope and pray is not a viable strategy. (Luc Pattyn)
Why are you using VB6? Do you hate yourself? (Christian Graus)

[0x3c0]

*twitch* That's really annoying, and incredibly obvious. It just makes me want to fly to the USA and beat Microsoft over the head with a dictionary.

OSDev

[Dan_Martin]

Clearly the decision to fully qualify the names was taken after the comment was written and possibly done automatically.

[OriginalGriff]

See TWOTD just above this thread, search for 502. That's the difference between good and bad code!

No trees were harmed in the sending of this message; however, a significant number of electrons were slightly inconvenienced. This message is made of fully recyclable Zeros and Ones

[Kevin McFarlane]

Dario Solera wrote:

code that contains grammar errors in comments

That applies to almost all code I see - assuming it has comments at all. ;P

Kevin

[Russell Jones]

You might be looking for easy refactoring wins and take out the worst of the worst first. Or you might decide to do some "feelgood" improvements and stay clear of the total nightmares.

[majee]

DaveyM69 wrote:

"An System.EventArgs that contains the event data."

Outsourced to "CODZ PLZ" programmer?

[BonshatS]

I find the level of code badness directly proportional to the number of 3:00 am wake up calls I get because of it.

[AndyInUK]

Ravi Sant wrote:

Coding is my birth-right and bugs are part of feature my code has!

Coders who think this way doesn't get good rating aswell. May be 3 out of 10

[Kevin McFarlane]

Well, as far as understandability and maintainability are concerned try running some code metrics over any piece of code you see. I use a tool that displays real-time cyclomatic and maintenance complexity (dynamically updated as you type). Low figures won't necessarily indicate good code but high figures definitely indicate bad code, at least with respect to understandability and maintainability. (The code might otherwise be correct and performant for all I know.)

Kevin

[Lost User]

consider for example: all programmers write as per standards, use proper css for looks, use proper logic, even then code is said to be bad, when some change so called big changes of scalability, or increase in users or feature rich functionality add-on........ code is always blamed to be badly written over a period of time. is readability of code measure of time....or there are techniques to help ur self with better coding.....?

Ravie Busie Coding is my birth-right and bugs are part of feature my code has!

[Kevin McFarlane]

Ravi Sant wrote:

when some change so called big changes of scalability, or increase in users or feature rich functionality add-on........ code is always blamed to be badly written over a period of time.

The best thing to do is to apply a code metrics tool every so often. If the numbers are bad then do some refactoring. However, this depends on the context, e.g., how much time and freedom you have for refactoring, whether the code base has unit tests so you can perform it more safely and so on. It's also easier to do refactoring with the help of software such as ReSharper or Refactor! Though, as always, you still need to keep your brain engaged. A few years ago I was specifically assigned a bug fix, feature enhancement and refactoring project. So I was able to apply a code metrics tool and then refactor until the bar charts decreased sufficiently. :)

Kevin

[DaveyM69]

That would make sense. A very simple vowel search in the algorithm would have prevented it - but heigh ho, that's probably why I don't work for MS.

Dave
Generic BackgroundWorker - My latest article!
BTW, in software, hope and pray is not a viable strategy. (Luc Pattyn)
Why are you using VB6? Do you hate yourself? (Christian Graus)

[Rage]

Here you go[^]

[Lost User]

:laugh:

Ravie Busie Coding is my birth-right and bugs are part of feature my code has!

[Zhat]

Beat me to it...8-)

[Rama Krishna Vavilala]

Ravi Sant wrote:

how do u rate it as bad..... from 1 to 10

Bad when:

Ravi Sant wrote:

bugs are part of feature my code has

Good When: Bugs are not feature and are not a part of the code.

[Marc Clifton]

Code is only bad if it needs to be touched after it's been written. And then, any code is bad. ;) Marc

Will work for food. Interacx

I'm not overthinking the problem, I just felt like I needed a small, unimportant, uninteresting rant! - Martin Hart Turner

[Fatbuddha 1]

here you see :laugh: Cheers

You have the thought that modern physics just relay on assumptions, that somehow depends on a smile of a cat, which isn’t there.( Albert Einstein)