Skip to content
  • Categories
  • Recent
  • Tags
  • Popular
  • World
  • Users
  • Groups
Skins
  • Light
  • Cerulean
  • Cosmo
  • Flatly
  • Journal
  • Litera
  • Lumen
  • Lux
  • Materia
  • Minty
  • Morph
  • Pulse
  • Sandstone
  • Simplex
  • Sketchy
  • Spacelab
  • United
  • Yeti
  • Zephyr
  • Dark
  • Cyborg
  • Darkly
  • Quartz
  • Slate
  • Solar
  • Superhero
  • Vapor

  • Default (No Skin)
  • No Skin
Collapse
Code Project
  1. Home
  2. The Lounge
  3. Good Practise?

Good Practise?

Scheduled Pinned Locked Moved The Lounge
question
25 Posts 13 Posters 0 Views 1 Watching
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • P Pete OHanlon

    Douglas Troy wrote:

    everything is in a source control system

    Versioning is for the weak of memory.

    "WPF has many lovers. It's a veritable porn star!" - Josh Smith

    As Braveheart once said, "You can take our freedom but you'll never take our Hobnobs!" - Martin Hughes.

    My blog | My articles | MoXAML PowerToys | Onyx

    D Offline
    D Offline
    Dalek Dave
    wrote on last edited by
    #9

    Better solution?

    ------------------------------------ I will never again mention that I was the poster of the One Millionth Lounge Post, nor that it was complete drivel. Dalek Dave

    A 1 Reply Last reply
    0
    • D Dalek Dave

      When you alter/edit/revise code, which is better, to delete the old code or to comment it out so you can see the evolution when you go back some time later?

      ------------------------------------ I will never again mention that I was the poster of the One Millionth Lounge Post, nor that it was complete drivel. Dalek Dave

      T Offline
      T Offline
      TheGreatAndPowerfulOz
      wrote on last edited by
      #10

      Delete! To see the evolution, look in source repository!

      Fight Big Government:
      http://obamacareclassaction.com/
      http://obamacaretruth.org/

      D 1 Reply Last reply
      0
      • T TheGreatAndPowerfulOz

        Delete! To see the evolution, look in source repository!

        Fight Big Government:
        http://obamacareclassaction.com/
        http://obamacaretruth.org/

        D Offline
        D Offline
        Dalek Dave
        wrote on last edited by
        #11

        seems to be the concensus.

        ------------------------------------ I will never again mention that I was the poster of the One Millionth Lounge Post, nor that it was complete drivel. Dalek Dave

        1 Reply Last reply
        0
        • D Dalek Dave

          Better solution?

          ------------------------------------ I will never again mention that I was the poster of the One Millionth Lounge Post, nor that it was complete drivel. Dalek Dave

          A Offline
          A Offline
          AspDotNetDev
          wrote on last edited by
          #12

          I'm fairly certain he's joking. :)

          [Forum Guidelines]

          D 1 Reply Last reply
          0
          • A AspDotNetDev

            I'm fairly certain he's joking. :)

            [Forum Guidelines]

            D Offline
            D Offline
            Dalek Dave
            wrote on last edited by
            #13

            They don't have sarcasm on my planet.

            ------------------------------------ I will never again mention that I was the poster of the One Millionth Lounge Post, nor that it was complete drivel. Dalek Dave

            A 1 Reply Last reply
            0
            • D Dalek Dave

              They don't have sarcasm on my planet.

              ------------------------------------ I will never again mention that I was the poster of the One Millionth Lounge Post, nor that it was complete drivel. Dalek Dave

              A Offline
              A Offline
              AspDotNetDev
              wrote on last edited by
              #14

              Really? What planet are you from?

              [Forum Guidelines]

              D L 2 Replies Last reply
              0
              • A AspDotNetDev

                Really? What planet are you from?

                [Forum Guidelines]

                D Offline
                D Offline
                Dalek Dave
                wrote on last edited by
                #15

                Fintlewoodlewix

                ------------------------------------ I will never again mention that I was the poster of the One Millionth Lounge Post, nor that it was complete drivel. Dalek Dave

                1 Reply Last reply
                0
                • A AspDotNetDev

                  The code should reflect the most recent functionality, and comments should describe what the code is intended to do. Use version control (e.g., Subversion and TortoiseSVN) to keep track of changes to code. Do not leave old code commented out in your new code. Delete it.

                  [Forum Guidelines]

                  L Offline
                  L Offline
                  Luc Pattyn
                  wrote on last edited by
                  #16

                  right. keeping old code, even in comment, confuses the reader, results in false search hits, and in general has no use at all. Less is definitely more. and that also applies to old comments! :)

                  Luc Pattyn [Forum Guidelines] [Why QA sucks] [My Articles]


                  Prolific encyclopedia fixture proof-reader browser patron addict?
                  We all depend on the beast below.


                  1 Reply Last reply
                  0
                  • A AspDotNetDev

                    Really? What planet are you from?

                    [Forum Guidelines]

                    L Offline
                    L Offline
                    Luc Pattyn
                    wrote on last edited by
                    #17

                    I guess DD is from Dark Drivelus, an obscure nebula beyond Orion; some call it Skaro. :)

                    Luc Pattyn [Forum Guidelines] [Why QA sucks] [My Articles]


                    Prolific encyclopedia fixture proof-reader browser patron addict?
                    We all depend on the beast below.


                    1 Reply Last reply
                    0
                    • D Dalek Dave

                      When you alter/edit/revise code, which is better, to delete the old code or to comment it out so you can see the evolution when you go back some time later?

                      ------------------------------------ I will never again mention that I was the poster of the One Millionth Lounge Post, nor that it was complete drivel. Dalek Dave

                      C Offline
                      C Offline
                      Chris Austin
                      wrote on last edited by
                      #18

                      Delete it and preserve the history in your revision control system. Lots of commented out code looks extremely unprofessional in a production code base IMO.

                      And above all things, never think that you're not good enough yourself. A man should never think that. My belief is that in life people will take you at your own reckoning. --Isaac Asimov Avoid the crowd. Do your own thinking independently. Be the chess player, not the chess piece. --Ralph Charell

                      1 Reply Last reply
                      0
                      • P Pete OHanlon

                        Douglas Troy wrote:

                        everything is in a source control system

                        Versioning is for the weak of memory.

                        "WPF has many lovers. It's a veritable porn star!" - Josh Smith

                        As Braveheart once said, "You can take our freedom but you'll never take our Hobnobs!" - Martin Hughes.

                        My blog | My articles | MoXAML PowerToys | Onyx

                        C Offline
                        C Offline
                        Chris Austin
                        wrote on last edited by
                        #19

                        Pete O'Hanlon wrote:

                        Versioning is for the weak of memory.

                        That would be me. :) As my wife likes to teas me the most common phrase I say to her is "What are we taking about?"

                        And above all things, never think that you're not good enough yourself. A man should never think that. My belief is that in life people will take you at your own reckoning. --Isaac Asimov Avoid the crowd. Do your own thinking independently. Be the chess player, not the chess piece. --Ralph Charell

                        R 1 Reply Last reply
                        0
                        • D Dalek Dave

                          When you alter/edit/revise code, which is better, to delete the old code or to comment it out so you can see the evolution when you go back some time later?

                          ------------------------------------ I will never again mention that I was the poster of the One Millionth Lounge Post, nor that it was complete drivel. Dalek Dave

                          D Offline
                          D Offline
                          dybs
                          wrote on last edited by
                          #20

                          As many have already said, delete it and use your source control system to be able to get back to it if needed. I would also add, decent log messages for commits are a big plus - makes it a lot easier to find that old code! Dybs

                          The shout of progress is not "Eureka!" it's "Strange... that's not what i expected". - peterchen

                          1 Reply Last reply
                          0
                          • D Dalek Dave

                            Thank you. As many know I am an accountant by trade, not a developer, but learning quickly and it is little things like this that help. Thanks for your time.

                            ------------------------------------ I will never again mention that I was the poster of the One Millionth Lounge Post, nor that it was complete drivel. Dalek Dave

                            R Offline
                            R Offline
                            RichardM1
                            wrote on last edited by
                            #21

                            Well, when you went back and cooked the books to be right, did you leave the old, wrong entries, or did you make it look like it had been right the whole time? ;P

                            Opacity, the new Transparency.

                            1 Reply Last reply
                            0
                            • C Chris Austin

                              Pete O'Hanlon wrote:

                              Versioning is for the weak of memory.

                              That would be me. :) As my wife likes to teas me the most common phrase I say to her is "What are we taking about?"

                              And above all things, never think that you're not good enough yourself. A man should never think that. My belief is that in life people will take you at your own reckoning. --Isaac Asimov Avoid the crowd. Do your own thinking independently. Be the chess player, not the chess piece. --Ralph Charell

                              R Offline
                              R Offline
                              RichardM1
                              wrote on last edited by
                              #22

                              If my memory were longer, how much I forget would frighten me.:~

                              Opacity, the new Transparency.

                              1 Reply Last reply
                              0
                              • D Dalek Dave

                                When you alter/edit/revise code, which is better, to delete the old code or to comment it out so you can see the evolution when you go back some time later?

                                ------------------------------------ I will never again mention that I was the poster of the One Millionth Lounge Post, nor that it was complete drivel. Dalek Dave

                                E Offline
                                E Offline
                                Ennis Ray Lynch Jr
                                wrote on last edited by
                                #23

                                First time around I leave the code in using comments pending the code review so what has been done can be compared to what has previously been done. After review and stable build, release, I routinely remove the old code because, as others have said, that is what source control is for. Also, keep in mind, this is why comments in source control check-ins are CRUCIAL, yet so many are way too lazy to bother.

                                Need custom software developed? I do custom programming based primarily on MS tools with an emphasis on C# development and consulting. A man said to the universe: "Sir I exist!" "However," replied the universe, "The fact has not created in me A sense of obligation." --Stephen Crane

                                1 Reply Last reply
                                0
                                • D Dalek Dave

                                  When you alter/edit/revise code, which is better, to delete the old code or to comment it out so you can see the evolution when you go back some time later?

                                  ------------------------------------ I will never again mention that I was the poster of the One Millionth Lounge Post, nor that it was complete drivel. Dalek Dave

                                  M Offline
                                  M Offline
                                  moon_stick
                                  wrote on last edited by
                                  #24

                                  <pedant>Good Practice?</pedant> While I'm actually working on changes, I'll tend to comment out historic code and add the new lot in. Once I've run my unit tests and everything is ready to check in, I'll go through and clean up the comments and code, relying on source control to maintain a history.

                                  Sarchasm : The gulf between the author of sarcastic wit and the person who doesn't get it.

                                  1 Reply Last reply
                                  0
                                  • D Dalek Dave

                                    When you alter/edit/revise code, which is better, to delete the old code or to comment it out so you can see the evolution when you go back some time later?

                                    ------------------------------------ I will never again mention that I was the poster of the One Millionth Lounge Post, nor that it was complete drivel. Dalek Dave

                                    D Offline
                                    D Offline
                                    Dan Neely
                                    wrote on last edited by
                                    #25

                                    The only time I leave old code behind is either when something is being pulled/disabled temporarily and will be restored in the near future, or when something confusingish is going on and the comment I have includes an explanation of why the old version isn't actually correct, even if at first glance, it appears to do the same thing.

                                    3x12=36 2x12=24 1x12=12 0x12=18

                                    1 Reply Last reply
                                    0
                                    Reply
                                    • Reply as topic
                                    Log in to reply
                                    • Oldest to Newest
                                    • Newest to Oldest
                                    • Most Votes


                                    • Login

                                    • Don't have an account? Register

                                    • Login or register to search.
                                    • First post
                                      Last post
                                    0
                                    • Categories
                                    • Recent
                                    • Tags
                                    • Popular
                                    • World
                                    • Users
                                    • Groups