Skip to content
  • Categories
  • Recent
  • Tags
  • Popular
  • World
  • Users
  • Groups
Skins
  • Light
  • Cerulean
  • Cosmo
  • Flatly
  • Journal
  • Litera
  • Lumen
  • Lux
  • Materia
  • Minty
  • Morph
  • Pulse
  • Sandstone
  • Simplex
  • Sketchy
  • Spacelab
  • United
  • Yeti
  • Zephyr
  • Dark
  • Cyborg
  • Darkly
  • Quartz
  • Slate
  • Solar
  • Superhero
  • Vapor

  • Default (No Skin)
  • No Skin
Collapse
Code Project
  1. Home
  2. The Lounge
  3. Coding pet hates

Coding pet hates

Scheduled Pinned Locked Moved The Lounge
jsonquestion
58 Posts 27 Posters 0 Views 1 Watching
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • L Lost User

    Near the top of my list of pet hates is unnecessary white space changes. You're looking at a piece of code thinking *why?*, so you go and look who last touched the line. Then you look at the rest of that check in and think this is totally unrelated. So you go and look at what they actually changed in the line of code only to find they added a tab on the end. Arrrrhhhhhgggggg. Start again with revision number-- What gives you the shits on a friday afternoon?

    R Offline
    R Offline
    ragnaroknrol
    wrote on last edited by
    #11

    I found this gem today.

    //Initializes the component
    InitializeComponent();

    REALLY?!?! I am so glad you put this comment in here, I never would have guessed this. Of course in the component block we get follow ups...

    //btnSave
    //
    this.btnSave.Anchor = ...

    Every section is done like this and the only comment is something I can read if I look ater this. in the code... about the only useful comment in the entire 1400 lines of code is this gem

    // I hope this works

    Right before a try. I don't know who put that in there, but my follow up comment made me feel better. //If the catch does something useful it does.

    If I have accidentally said something witty, smart, or correct, it is purely by mistake and I apologize for it.

    N 1 Reply Last reply
    0
    • L Lost User

      Near the top of my list of pet hates is unnecessary white space changes. You're looking at a piece of code thinking *why?*, so you go and look who last touched the line. Then you look at the rest of that check in and think this is totally unrelated. So you go and look at what they actually changed in the line of code only to find they added a tab on the end. Arrrrhhhhhgggggg. Start again with revision number-- What gives you the shits on a friday afternoon?

      P Offline
      P Offline
      Peter Mulholland
      wrote on last edited by
      #12

      The rats nest of C++ driver code i inherited when i started here. It had passed through 3 other hands before i got it. Some of those hands did not belong to software developers. It usually breaks every time i make a change.

      Pete

      1 Reply Last reply
      0
      • N NormDroid

        My pet hate is this

        if () {
        }

        Two heads are better than one.

        K Offline
        K Offline
        kinar
        wrote on last edited by
        #13

        5 :thumbsup:

        1 Reply Last reply
        0
        • I Ian Shlasko

          Ah, I remember those days, working for a big team... SourceSafe was our first poison, followed by ClearCase. By the time I transferred out of that department, I think we were developing three branches simultaneously, so every bugfix had to be done three times... One branch for the upcoming build, one for the next build after that, and I forget what the third was.... Now I'm a solo developer... Things are much simpler now.

          Proud to have finally moved to the A-Ark. Which one are you in?
          Author of the Guardians Saga (Sci-Fi/Fantasy novels)

          E Offline
          E Offline
          Electron Shepherd
          wrote on last edited by
          #14

          Ian Shlasko wrote:

          we were developing three branches simultaneously

          Ian Shlasko wrote:

          so every bugfix had to be done three times

          Not sure about SourceSafe, but ClearCase lets you merge branches. I've done three-way merges with ClearCase before now. Keeping track of which changes need to go where can be tricky, but it's doable.

          Server and Network Monitoring

          I 1 Reply Last reply
          0
          • E Electron Shepherd

            Ian Shlasko wrote:

            we were developing three branches simultaneously

            Ian Shlasko wrote:

            so every bugfix had to be done three times

            Not sure about SourceSafe, but ClearCase lets you merge branches. I've done three-way merges with ClearCase before now. Keeping track of which changes need to go where can be tricky, but it's doable.

            Server and Network Monitoring

            I Offline
            I Offline
            Ian Shlasko
            wrote on last edited by
            #15

            Yeah, you CAN merge branches, but that wasn't how the project managers decided to do it.

            Proud to have finally moved to the A-Ark. Which one are you in?
            Author of the Guardians Saga (Sci-Fi/Fantasy novels)

            1 Reply Last reply
            0
            • N NormDroid

              My pet hate is this

              if () {
              }

              Two heads are better than one.

              N Offline
              N Offline
              Nemanja Trifunovic
              wrote on last edited by
              #16

              Depends on the language. K&R style is standard in C, C++ (except with Windows API / MFC for some reason), Perl and Java. In C# it is not. Forgot about JavaScript :~ My rule is: follow the style of the standard library for the language you use.

              utf8-cpp

              N 1 Reply Last reply
              0
              • N Nemanja Trifunovic

                Depends on the language. K&R style is standard in C, C++ (except with Windows API / MFC for some reason), Perl and Java. In C# it is not. Forgot about JavaScript :~ My rule is: follow the style of the standard library for the language you use.

                utf8-cpp

                N Offline
                N Offline
                NormDroid
                wrote on last edited by
                #17

                I couldn't give a flying fuck what the standard is :), it makes code less easy to read, just because somebody creates a standard it don't mean it's any good.

                Two heads are better than one.

                N R 2 Replies Last reply
                0
                • R ragnaroknrol

                  I found this gem today.

                  //Initializes the component
                  InitializeComponent();

                  REALLY?!?! I am so glad you put this comment in here, I never would have guessed this. Of course in the component block we get follow ups...

                  //btnSave
                  //
                  this.btnSave.Anchor = ...

                  Every section is done like this and the only comment is something I can read if I look ater this. in the code... about the only useful comment in the entire 1400 lines of code is this gem

                  // I hope this works

                  Right before a try. I don't know who put that in there, but my follow up comment made me feel better. //If the catch does something useful it does.

                  If I have accidentally said something witty, smart, or correct, it is purely by mistake and I apologize for it.

                  N Offline
                  N Offline
                  NormDroid
                  wrote on last edited by
                  #18
                  //Initializes the component
                  InitializeComponent();
                  

                  I know it's ghastly.

                  Two heads are better than one.

                  R 1 Reply Last reply
                  0
                  • L Lost User

                    Near the top of my list of pet hates is unnecessary white space changes. You're looking at a piece of code thinking *why?*, so you go and look who last touched the line. Then you look at the rest of that check in and think this is totally unrelated. So you go and look at what they actually changed in the line of code only to find they added a tab on the end. Arrrrhhhhhgggggg. Start again with revision number-- What gives you the shits on a friday afternoon?

                    M Offline
                    M Offline
                    Marc Clifton
                    wrote on last edited by
                    #19

                    I have a few, but at the top of the list are using "this." to get Intellisense to trigger, which is an obsolete habit from older IDE's. My other is when people pay no attention to the structure of the code and put fields, properties, public and private methods into an unorganized pile of dung. Yes, obviously the compiler couldn't care less, but we're writing code for each other, and I like a certain structure to my classes. So, my other pet pieve is when people, who come into a project and should be humble and respectful to the work others have already done, totally ignore it, not just structure but naming conventions, indentation conventions, etc. I can write coding standards until I'm blue in the face and their still ignored, but the code itself shows what the standards are if people just took the time to look at it and left their egos at the door. There should be a new branch of psychology for programmers. So, is it possible that your use of underscores is because you feel inadequate with your partner? Are you placing fields willy-nilly in the class because you were bottle fed and lack the ability to empathize with your fellow human being? Do you use lowercase method names because you were taunted by your peers as a child? Marc

                    OriginalGriffO S J N N 5 Replies Last reply
                    0
                    • N NormDroid

                      I couldn't give a flying fuck what the standard is :), it makes code less easy to read, just because somebody creates a standard it don't mean it's any good.

                      Two heads are better than one.

                      N Offline
                      N Offline
                      Nemanja Trifunovic
                      wrote on last edited by
                      #20

                      Norm .net wrote:

                      it makes code less easy to read, just because somebody creates a standard it don't mean it's any good.

                      When in Rome, do as the Romans do. Seriously, it is just a matter of habit. If you ever work on Java project, you'd better use the K&R style or you'll get into trouble with the coworkers.

                      utf8-cpp

                      N L 2 Replies Last reply
                      0
                      • N NormDroid

                        My pet hate is this

                        if () {
                        }

                        Two heads are better than one.

                        OriginalGriffO Offline
                        OriginalGriffO Offline
                        OriginalGriff
                        wrote on last edited by
                        #21

                        :thumbsup: I prefer

                        if ()
                        {
                        ...
                        }

                        But what annoys me is

                        if(condition) statement;

                        because I expect to see the following statement(s) as the conditionally executed ones. Though to be honest, I'll stick with anything consistent - it better than a mix of styles. That's one of the things I like about VS - it can reformat the code to match your personal preference. Unfortunately, that counts as a change for SVN...

                        I have learnt that you can not make someone love you, all you can do is stalk them and hope they panic and give in. Apathy Error: Don't bother striking any key.

                        "I have no idea what I did, but I'm taking full credit for it." - ThisOldTony
                        "Common sense is so rare these days, it should be classified as a super power" - Random T-shirt

                        I M H 3 Replies Last reply
                        0
                        • N NormDroid
                          //Initializes the component
                          InitializeComponent();
                          

                          I know it's ghastly.

                          Two heads are better than one.

                          R Offline
                          R Offline
                          ragnaroknrol
                          wrote on last edited by
                          #22

                          I totally wouldn't have known!!! /facepalm

                          If I have accidentally said something witty, smart, or correct, it is purely by mistake and I apologize for it.

                          1 Reply Last reply
                          0
                          • M Marc Clifton

                            I have a few, but at the top of the list are using "this." to get Intellisense to trigger, which is an obsolete habit from older IDE's. My other is when people pay no attention to the structure of the code and put fields, properties, public and private methods into an unorganized pile of dung. Yes, obviously the compiler couldn't care less, but we're writing code for each other, and I like a certain structure to my classes. So, my other pet pieve is when people, who come into a project and should be humble and respectful to the work others have already done, totally ignore it, not just structure but naming conventions, indentation conventions, etc. I can write coding standards until I'm blue in the face and their still ignored, but the code itself shows what the standards are if people just took the time to look at it and left their egos at the door. There should be a new branch of psychology for programmers. So, is it possible that your use of underscores is because you feel inadequate with your partner? Are you placing fields willy-nilly in the class because you were bottle fed and lack the ability to empathize with your fellow human being? Do you use lowercase method names because you were taunted by your peers as a child? Marc

                            OriginalGriffO Offline
                            OriginalGriffO Offline
                            OriginalGriff
                            wrote on last edited by
                            #23

                            Marc Clifton wrote:

                            when people pay no attention to the structure of the code and put fields, properties, public and private methods into an unorganized pile of dung.

                            Yep. I modified the default classes to provide #region commands for Fields, Properties, enums, event handlers, event constructors, etc., etc. to make it easier to do.

                            I have learnt that you can not make someone love you, all you can do is stalk them and hope they panic and give in. Apathy Error: Don't bother striking any key.

                            "I have no idea what I did, but I'm taking full credit for it." - ThisOldTony
                            "Common sense is so rare these days, it should be classified as a super power" - Random T-shirt

                            I 1 Reply Last reply
                            0
                            • L Lost User

                              Near the top of my list of pet hates is unnecessary white space changes. You're looking at a piece of code thinking *why?*, so you go and look who last touched the line. Then you look at the rest of that check in and think this is totally unrelated. So you go and look at what they actually changed in the line of code only to find they added a tab on the end. Arrrrhhhhhgggggg. Start again with revision number-- What gives you the shits on a friday afternoon?

                              OriginalGriffO Offline
                              OriginalGriffO Offline
                              OriginalGriff
                              wrote on last edited by
                              #24

                              In addition to that little lot: "I'll come back and comment it later, when I get it working." Oh no you won't you lazy little ****! You'll move on to something more interesting, and to hell with the maintenance...

                              I have learnt that you can not make someone love you, all you can do is stalk them and hope they panic and give in. Apathy Error: Don't bother striking any key.

                              "I have no idea what I did, but I'm taking full credit for it." - ThisOldTony
                              "Common sense is so rare these days, it should be classified as a super power" - Random T-shirt

                              1 Reply Last reply
                              0
                              • L Lost User

                                Near the top of my list of pet hates is unnecessary white space changes. You're looking at a piece of code thinking *why?*, so you go and look who last touched the line. Then you look at the rest of that check in and think this is totally unrelated. So you go and look at what they actually changed in the line of code only to find they added a tab on the end. Arrrrhhhhhgggggg. Start again with revision number-- What gives you the shits on a friday afternoon?

                                J Offline
                                J Offline
                                John M Drescher
                                wrote on last edited by
                                #25

                                Using 4 external libraries in a project and each library implements its own extended string class and also its own smart pointers which are incompatible with the other 3 libraries.

                                John

                                1 Reply Last reply
                                0
                                • N NormDroid

                                  My pet hate is this

                                  if () {
                                  }

                                  Two heads are better than one.

                                  J Offline
                                  J Offline
                                  JHizzle
                                  wrote on last edited by
                                  #26

                                  I had a similar one the other day that had me staring at the screen for 5 minutes, calling someone else over to check I wasn't hallucinating:

                                  if (a == b)
                                  {
                                  somevalue = x;
                                  }
                                  else
                                  {
                                  somevalue = x;
                                  }

                                  1 Reply Last reply
                                  0
                                  • OriginalGriffO OriginalGriff

                                    :thumbsup: I prefer

                                    if ()
                                    {
                                    ...
                                    }

                                    But what annoys me is

                                    if(condition) statement;

                                    because I expect to see the following statement(s) as the conditionally executed ones. Though to be honest, I'll stick with anything consistent - it better than a mix of styles. That's one of the things I like about VS - it can reformat the code to match your personal preference. Unfortunately, that counts as a change for SVN...

                                    I have learnt that you can not make someone love you, all you can do is stalk them and hope they panic and give in. Apathy Error: Don't bother striking any key.

                                    I Offline
                                    I Offline
                                    Ian Shlasko
                                    wrote on last edited by
                                    #27

                                    Bah, I do that all the time... I really don't want to read stuff like this:

                                    if (flag)
                                    {
                                    x = 1;
                                    }

                                    It's just a waste of space...

                                    if (flag) x = 1;

                                    ...is much cleaner. And if it was a little bit more complicated, but still one line...

                                    if (flag & (otherThing | somethingElse))
                                    x = 9387523 / blah + 34028;

                                    Sticking to a coding style is one thing... Unneeded braces are another.

                                    Proud to have finally moved to the A-Ark. Which one are you in?
                                    Author of the Guardians Saga (Sci-Fi/Fantasy novels)

                                    R 1 Reply Last reply
                                    0
                                    • N Nemanja Trifunovic

                                      Norm .net wrote:

                                      it makes code less easy to read, just because somebody creates a standard it don't mean it's any good.

                                      When in Rome, do as the Romans do. Seriously, it is just a matter of habit. If you ever work on Java project, you'd better use the K&R style or you'll get into trouble with the coworkers.

                                      utf8-cpp

                                      N Offline
                                      N Offline
                                      NormDroid
                                      wrote on last edited by
                                      #28

                                      Nemanja Trifunovic wrote:

                                      If you ever work on Java project,

                                      Don't worry they'll be no chance of that happening. :)

                                      Two heads are better than one.

                                      1 Reply Last reply
                                      0
                                      • M Marc Clifton

                                        I have a few, but at the top of the list are using "this." to get Intellisense to trigger, which is an obsolete habit from older IDE's. My other is when people pay no attention to the structure of the code and put fields, properties, public and private methods into an unorganized pile of dung. Yes, obviously the compiler couldn't care less, but we're writing code for each other, and I like a certain structure to my classes. So, my other pet pieve is when people, who come into a project and should be humble and respectful to the work others have already done, totally ignore it, not just structure but naming conventions, indentation conventions, etc. I can write coding standards until I'm blue in the face and their still ignored, but the code itself shows what the standards are if people just took the time to look at it and left their egos at the door. There should be a new branch of psychology for programmers. So, is it possible that your use of underscores is because you feel inadequate with your partner? Are you placing fields willy-nilly in the class because you were bottle fed and lack the ability to empathize with your fellow human being? Do you use lowercase method names because you were taunted by your peers as a child? Marc

                                        S Offline
                                        S Offline
                                        Simon P Stevens
                                        wrote on last edited by
                                        #29

                                        Check out Regionerate[^]. It re-orders all you class members, properties, methods etc, into a specified order. Supports with and without regions modes.

                                        Simon

                                        M W 2 Replies Last reply
                                        0
                                        • M Marc Clifton

                                          I have a few, but at the top of the list are using "this." to get Intellisense to trigger, which is an obsolete habit from older IDE's. My other is when people pay no attention to the structure of the code and put fields, properties, public and private methods into an unorganized pile of dung. Yes, obviously the compiler couldn't care less, but we're writing code for each other, and I like a certain structure to my classes. So, my other pet pieve is when people, who come into a project and should be humble and respectful to the work others have already done, totally ignore it, not just structure but naming conventions, indentation conventions, etc. I can write coding standards until I'm blue in the face and their still ignored, but the code itself shows what the standards are if people just took the time to look at it and left their egos at the door. There should be a new branch of psychology for programmers. So, is it possible that your use of underscores is because you feel inadequate with your partner? Are you placing fields willy-nilly in the class because you were bottle fed and lack the ability to empathize with your fellow human being? Do you use lowercase method names because you were taunted by your peers as a child? Marc

                                          J Offline
                                          J Offline
                                          Jpuckett
                                          wrote on last edited by
                                          #30

                                          Marc Clifton wrote:

                                          So, is it possible that your use of underscores is because you feel inadequate with your partner? Are you placing fields willy-nilly in the class because you were bottle fed and lack the ability to empathize with your fellow human being? Do you use lowercase method names because you were taunted by your peers as a child?

                                          I do believe I have a man-crush now. Best. Comment. Ever.

                                          1 Reply Last reply
                                          0
                                          Reply
                                          • Reply as topic
                                          Log in to reply
                                          • Oldest to Newest
                                          • Newest to Oldest
                                          • Most Votes


                                          • Login

                                          • Don't have an account? Register

                                          • Login or register to search.
                                          • First post
                                            Last post
                                          0
                                          • Categories
                                          • Recent
                                          • Tags
                                          • Popular
                                          • World
                                          • Users
                                          • Groups