Reviewing code...

[Hosey]

An old-skool legacy im trying to get rectified. But its a large code-base, and wont get changed overnight :) Personally use C# in all my "pet-projects" but have to stick to VB at the office. Worth sharing, just to make people cringe, but we still have a business critical application (used daily and directly linked to our revenues) that was written in VB 6 over 12 yrs ago... still going... Dont have the time to re-write it at the moment, and if it aint broke, dont fix it... :)

[Hosey]

HAHAH wasnt thinking outside the box like that... good man! ;P :-D

[NormDroid]

Hosey^ wrote:

and if it aint broke, dont fix it...

VB code is always broke ;)

Two heads are better than one.

[Pualee]

If the code was C and there were poorly managed global variables you could not otherwise control... I can understand why.

[Amar Chaudhary]

Have fun :)

List<List<urlKeeper>> PhraseResultSet = new List<List<urlKeeper>>();
c.Urls = u.AltavistaScrapper(c.Url);
for (int i = 0; i < uniqueKeywords.Count; i++)
{
PhraseResultSet.Add(u.AltavistaPhraseScrapper(uniqueKeywords[i]));

        // get ranking for comps 
        c.Competitors.FindAll(delegate(Competitors x)
        {
            return uniqueKeywords\[i\] == x.Phrase;
        }).ForEach(delegate(Competitors x)
        {
            PhraseResultSet\[i\].Sort(new Comparison<urlKeeper>(delegate(urlKeeper obj1, urlKeeper obj2)
            {
                return obj1.Rank.CompareTo(obj2.Rank);
            }));

            int index = PhraseResultSet\[i\].FindIndex(delegate(urlKeeper y)
            {
                return (y.HostName.ToUpper().Replace("HTTP://", "")
                                            .Replace("HTTPS://", "")
                                            .Replace("WWW.", "")
                    == x.Url.ToUpper().Replace("HTTP://", "")
                                      .Replace("HTTPS://", "")
                                      .Replace("WWW.", ""));
            });
            if (index >= 0)
                x.Rank = PhraseResultSet\[i\]\[index\].Rank;
            else
                x.Rank = -1;

        }); ;
    }

My Startup!!!!
Profile@Elance - feedback available too

[Lost User]

Often such strange things are the result of tweaking the code until it finally worked and not taking the time to clean up the debris from all this trial and error.

A while ago he asked me what he should have printed on my business cards. I said 'Wizard'. I read books which nobody else understand. Then I do something which nobody understands. After that the computer does something which nobody understands. When asked, I say things about the results which nobody understand. But everybody expects miracles from me on a regular basis. Looks to me like the classical definition of a wizard.

[George Carmichael]

I'm astounded that people will criticize code, but make spelling mistakes during their public diatribe ("embaressed").

GC

[Tomz_KV]

True. In many cases, if a page shows up without a significant delay, its code might not be looked at again.

TOMZ_KV

[Jason Christian]

I think my favorite was an Access program (yes, there are things worse than VB), where most of the logic was in nested IIfs within queries. After copying them into a text editor so I could separate them out enough to see what was going on, I discovered that the last 3 or 4 of the 10-15 nested IIfs all =0 for the true result. There were 4-5 query columns like this. So the last 3 or 4 conditions didn't need to be checked because they would all result in 0. If a, then 0, else if b, then 0, else if c then 0. Lovely code.

[Kirk Wood]

For the last 18 months I have been stuck with maintaining a 2500 line if statement. (I have never managed to actually count how deep the layers get.) And, to make matters worse there is no means of unit testing available. Thank goodness the replacement system is in place.

[the Kris]

What about the next piece of code, which was endorsed by the product manager :

while ( true)
{
if( formName == Evita.GuiCommon.Constants.GuiScreens.STARTING_UP)
{
this.mExeStartingUpHandler.Display();
break;
}
if( formName == Evita.GuiCommon.Constants.GuiScreens.Exe.ADD_CLEANING_STATION)
{
this.mExeAddCleaningStationHandler.Display(this.mTcpIpMessages);
break;
}
else if( formName == Evita.GuiCommon.Constants.GuiScreens.Exe.ADD_DRIVER)
{
this.mExeAddDriverHandler.Display(this.mTcpIpMessages);
break;
}
else if (...)
...
}

The reason for doing the while loop with the breaks : it runs faster than if-else-if without it. Also note there was no final break, so if the loop was entered with an unknown 'formName', it would loop forever. Countless arguments against doing things like this came to my mind, but they were all disregarded and this was the way to do it. Then they wondered why some people started to rebel.

[Lost User]

It has happened to everyone, I guess. Be it that, you had only little time or the next emergency had to be taken care of. Whatever happened, you simply forgot to clean up.

A while ago he asked me what he should have printed on my business cards. I said 'Wizard'. I read books which nobody else understand. Then I do something which nobody understands. After that the computer does something which nobody understands. When asked, I say things about the results which nobody understand. But everybody expects miracles from me on a regular basis. Looks to me like the classical definition of a wizard.

[Tomz_KV]

Totally agree with you.

TOMZ_KV

[Hosey]

Thats the reason im not a teacher... The code i posted is the reason some people should rethink being a developer ;)

[Hosey]

There are always some gems somewhere... I think back to some of my early code that I found a year or so later, and nearly died on the spot.. :D