Adding Attributes to XML node using VBA

priyaahh

Hi Dave, Thanks again!.. Here is the code i am using for conversion. Function fGenerateXML(rngData As Range, rootNodeName As String, sn As Integer, ts As Integer) As String On Error Resume Next '=============================================================== ' XML Tags ' Table Const HEADER As String = "<?xml version=""1.0""?>" Dim TAG_BEGIN As String Dim TAG_END As String 'Dim strTAG_END As String Const NODE_DELIMITER As String = "/" '=============================================================== Dim intColCount As Integer Dim intRowCount As Integer Dim intColCounter As Integer Dim intRowCounter As Integer Dim rngCell As Range Dim strXML As String 'Dim str As String 'str = "" 'strTAG_END = "" ' Initial table tag... Dim rNode() As String rNode = Split(rootNodeName, NODE_DELIMITER) If sn = 0 Then TAG_BEGIN = vbCrLf & "<" & rNode(0) & ">" & vbCrLf & "<" & rNode(1) & ">" Else TAG_BEGIN = vbCrLf & "<" & rNode(1) & ">" & vbCrLf End If 'determining if it is final sheet for concatenation If sn = ts Then TAG_END = vbCrLf & "</" & rNode(1) & ">" & vbCrLf & "</" & rNode(0) & ">" Else TAG_END = vbCrLf & "</" & rNode(1) & ">" & vbCrLf End If 'TAG_BEGIN = vbCrLf & "<" & rootNodeName & ">" & vbCrLf 'TAG_END = vbCrLf & "</" & rootNodeName & ">" & vbCrLf If sn = 0 Then strXML = HEADER End If strXML = strXML & TAG_BEGIN With rngData ' Discover dimensions of the data we ' will be dealing with... intColCount = .Columns.Count intRowCount = .Rows.Count Dim strColNames() As String ReDim strColNames(intColCount) ' First Row is the Field/Tag names If intRowCount >= 1 Then ' Loop accross columns... For intColCounter = 1 To intColCount ' Mark the cell under current scrutiny by setting ' an object variable... Set rngCell = .Cells(1, intColCounter) '

DaveAuld

can you edit your message and put the code in a code block with an attribute lang="vb", so it formats something more readable! 2) Do not user On Error Resume Next, how else will you trap problems Change to On Error Goto ERROR_HANDLER, then at the end of the function put;

' Return the HTML string...
fGenerateXML = strXML
Exit Function

ERROR_HANDLER:

MSGBOX "Error: " & Err.description

End Function

You are doing far too much in the single function, split it up into smaller helper functions, one to create nodes, one to add attributes etc. It will be easier to program and follow. Dave Don't forget to rate messages!
Find Me On: Web|Facebook|Twitter|LinkedIn
Waving? dave.m.auld[at]googlewave.com

priyaahh

Hi Dave, Ya sure I will split this function. I wanted to add attribute which i have posted in my first post to the tags highlighted in bold. Appreaciate u lot..pls help..its urgent..

Function fGenerateXML(rngData As Range, rootNodeName As String, sn As Integer, ts As Integer) As String
On Error Resume Next
'===============================================================
' XML Tags
' Table

Const HEADER As String = "<?xml version=""1.0""?>"
Dim TAG_BEGIN As String
Dim TAG_END As String
'Dim strTAG_END As String
Const NODE_DELIMITER As String = "/"

'===============================================================

Dim intColCount As Integer
Dim intRowCount As Integer
Dim intColCounter As Integer
Dim intRowCounter As Integer

Dim rngCell As Range

Dim strXML As String
'Dim str As String
'str = ""
'strTAG_END = ""

' Initial table tag...
Dim rNode() As String
rNode = Split(rootNodeName, NODE_DELIMITER)

If sn = 0 Then
TAG_BEGIN = vbCrLf & "<" & rNode(0) & ">" & vbCrLf & "<" & rNode(1) & ">"
Else
TAG_BEGIN = vbCrLf & "<" & rNode(1) & ">" & vbCrLf
End If

'determining if it is final sheet for concatenation
If sn = ts Then
TAG_END = vbCrLf & "</" & rNode(1) & ">" & vbCrLf & "</" & rNode(0) & ">"
Else
TAG_END = vbCrLf & "</" & rNode(1) & ">" & vbCrLf
End If

'TAG_BEGIN = vbCrLf & "<" & rootNodeName & ">" & vbCrLf
'TAG_END = vbCrLf & "</" & rootNodeName & ">" & vbCrLf

If sn = 0 Then
strXML = HEADER
End If
strXML = strXML & TAG_BEGIN

With rngData

' Discover dimensions of the data we
' will be dealing with...
intColCount = .Columns.Count

intRowCount = .Rows.Count

Dim strColNames() As String

ReDim strColNames(intColCount)

' First Row is the Field/Tag names
If intRowCount >= 1 Then

' Loop accross columns...
For intColCounter = 1 To intColCount

' Mark the cell under current scrutiny by setting
' an object variable...
Set rngCell = .Cells(1, intColCounter)

' Is the cell merged?..
If Not rngCell.MergeArea.Address = _
rngCell.Address Then

MsgBox ("!! Cell Merged ... Invalid format")
Exit Function

End If

'Sangeetha
strColNames(intColCounter) = rngCell.Text

'loop thro the sheets for header
If rNode(1) = "Actual_Loss_History" Or rNode(1) = "As_If_Loss_History" Then

If strColNames(intColCounter) = "Policy Years

DaveAuld

You have some wierdness going on around your arrays, either i am missing something or your code is wrong, here are all the NodeStack references; Line 141: Dim NodeStack() as String Line 168: ReDim NodeStack(0) Line 229:

For i = 1 To UBound(Nodes)
If i <= UBound(NodeStack) Then
If Trim(Nodes(i)) <> Trim(NodeStack(i)) Then
'not match
'MsgBox (Nodes(i) & "," & NodeStack(i))
MatchAll = False
Exit For
End If
Else
MatchAll = False
Exit For
End If
Next

Up until this point NodeStack does not contain any values, it is a completly empty array, but yet you are trying to compare values etc from it. It is not until later in your code that you give it any values by NodeStack = Nodes, and that is only if Nodes does actually contain values. I suspect your code is throwing exceptions, but because you current On Error Resume Next you are not seeing them.

Dave Don't forget to rate messages!
Find Me On: Web|Facebook|Twitter|LinkedIn
Waving? dave.m.auld[at]googlewave.com

priyaahh

Hi, Code is working fine. I tried by removing on error resume next. Problem is that if i add attribute to that tags which is like Attribute="1,1,1,..." then it is giving error. I am not sure the way to keep the attributes there. Or is there any way after generation of an xml, can we open that xml file and add attributes to that? Regards, Priya.

DaveAuld

I had a think about what i had written, and no it won't throw an excpetion, All that will happen is MatchAll will always be False so that code is effectively doing nothing (because 1 or higher is always greater than 0). All you are doing is generating a bunch of strings and bolting them altogether. After you generate the xml and the function exits, have you had a look at the XML file to see what it looks like?

Dave Don't forget to rate messages!
Find Me On: Web|Facebook|Twitter|LinkedIn
Waving? dave.m.auld[at]googlewave.com

priyaahh

Hi Dave, Thanks. Yes XML looks good. Regards, Priya.

DaveAuld

In that case all you are doing now then is adding the attributes to the node. Create a helper function like; getNodeAttributes(node as integer) as string In it, test node to see which attributes you need to build, then return them in the function, if the node does not need any attributes, then return an empty string. Then modify; strXML = strXML & "<" & Nodes(t) & ">" to strXML = strXML & "<" & Nodes(t) & getNodeAttributes(t) & ">" simples........

Dave Don't forget to rate messages!
Find Me On: Web|Facebook|Twitter|LinkedIn
Waving? dave.m.auld[at]googlewave.com

priyaahh

Hi Dave, Thanks lot. I tried adding the funtion like :

Function getNodeAttributes(node As String) As String
Dim str_att As String
If node = "Policy_Years" Then
str_att = "Attribute=" & "1,1,0,1,16711680,2,0,0,1,16711680,0,0,0,0,0,0.5,10,Arial,1"" Attribute2="""
End If
End Function

and also changed

strXML = strXML & "<" & Nodes(t) & getNodeAttributes(Nodes(t)) & ">"

Just tried assigning attribute to only one node. But I am not getting any in the output for the tag Policy_Years. Please Help.. Regards, Priya.

DaveAuld

Of course you wont, your passing across the node index not the node name;

priyaahh wrote:

strXML = strXML & "<" & Nodes(t) & getNodeAttributes(Nodes(t)) & ">"

change to; strXML = strXML & "<" & Nodes(t) & getNodeAttributes("Policy_Years") & ">"

Dave Don't forget to rate messages!
Find Me On: Web|Facebook|Twitter|LinkedIn
Waving? dave.m.auld[at]googlewave.com

priyaahh

Hi Dave, Still no its not showing... :-( Is there any other way to implement this? Regards, Priya.

DaveAuld

Well i fail to see what you are doing wrong. Don't give in! At the end of the day, all you are doing is simple string manipulation, it doesn't matter if it is in XML format or any other text based format. If your output XML file shows the attributes after your text generation then it is working. If your output does not show the attributes, then your code is wrong. You maybe need to start putting in extra breakpoints, debug.print(), or message boxes statements through your code until you can find out what is going on. everytime you generate a node or an attribute use these statements to see what the string is before and after. That way you will be able to see what you are getting versus what you are expecting at each stage. This is basic troubleshooting. As i have stated before your function is way to big, and you really need to restructure and break out lots of smaller helper functions which can then be called to piece the final text XML string. As i say, this is basic string manipulation, so something obvious is wrong somewhere!

Dave Don't forget to rate messages!
Find Me On: Web|Facebook|Twitter|LinkedIn
Waving? dave.m.auld[at]googlewave.com

priyaahh

Hi Dave, Thanks really!... I am planning another way. TO open the xml file generated and then adding attributes to elements. If you dont mind can you please give me example for this. Yes i remember, you have sent me the reference to DOM Methods for implementing this. But at this point of time with so much stress i cannt think of anything and this have to completed asap i do not have even hours of time...pls pls help.. Thanks in advance..reply if ur online Regards, Priya

DaveAuld

No that is not the way to go, you are making things harder for your self, you will then have to read, parse, inject , save strings. You have already got a function that generates a valid XML file, so you are 99% of the way there. Have you done what i have suggested with regards to breakpoints and or debug statements? strategically place them in your code, and you will see where the attributes you have added are then disappearing (if they are disappearing at all that is). Also, in the previous message did you replace both instances of the code where you inject the attribute function? you have 2 lines that do it depending on the state of some value. Did you please a debug statement in your attribute function to prove it is being called? Did you add a debug.print statement to see what it was adding to the string?

Dave Don't forget to rate messages!
Find Me On: Web|Facebook|Twitter|LinkedIn
Waving? dave.m.auld[at]googlewave.com

priyaahh

Dave, <pre attribute="vb"> Yes I did debut and breakpoints. Actually I have to keep getNodeAttribute function in the first set not in the second set. I examined that. During call of the above function i print the var in immediate window. it is printing like : Attribute=1,1,0,1,16711680,2,0,0,1,16711680,0,0,0,0,0,0.5,10,Arial,1" Attribute2=" but when it go back to the main line from where are calling the function it is not returning anything.. Hope u might got my explanation..pls help This is my function: Function getNodeAttributes(node As String) As String dim str_att as string If node = "Policy_Years" Then str_att = "Attribute=" & "1,1,0,1,16711680,2,0,0,1,16711680,0,0,0,0,0,0.5,10,Arial,1"" Attribute2=""" ElseIf node = "Loss_Descriptions" Then str_att = "Attribute=" & "1,1,0,1,16711680,2,0,0,1,16711680,0,0,0,0,0,0.5,10,Arial,1"" Attribute2=""" Debug.Print str_att End If End Function Calling the above function from the below line: strXML = strXML & "<" & Nodes(t) & getNodeAttributes(Nodes(t)) & ">" I wanted output like: <Adjusted_Loss_PD Attribute="1,1,0,1,16711680,2,0,0,1,16711680,0,0,0,0,0,0.5,10,Arial,1" Attribute2=""> <Adjusted_Loss_PD-1 /> <Adjusted_Loss_PD-2 /> <Adjusted_Loss_PD-3 /> <Adjusted_Loss_PD-4 /> <Adjusted_Loss_PD-5 /> <Adjusted_Loss_PD-6 /> <Adjusted_Loss_PD-7 /> <Adjusted_Loss_PD-8 /> <Adjusted_Loss_PD-9 /> <Adjusted_Loss_PD-10 /> </Adjusted_Loss_PD> </pre>

DaveAuld

It looks like you are missing quotes from the output string. As you already know, you have to increase the number of quotes if you want to add quotes to the output, you are only doing this in some of your code.

priyaahh wrote:

str_att = "Attribute=" & "1,1,0,1,16711680,2,0,0,1,16711680,0,0,0,0,0,0.5,10,Arial,1"" Attribute2="""

Look at the code after "Attribute=" the opening value only has a single double quote, which will result in Attribute=1,1,....etc. and not Attribute="1,1,...etc. yet at the end you correctly add the extra quotes. you can always consider user Char(34) in you string generator so you can see where you want to add the quote to the output e.g. (34 is the ASCII value for a double quote, look at asciitable[^]) str_Att = "Attribute1=" & chr(34) & "1,1,0,1,16711680,2,0,0,1,16711680,0,0,0,0,0,0.5,10,Arial,1" & chr(34) & " Attribute2=" & chr(34) & "some value" & chr(34)

Dave Don't forget to rate messages!
Find Me On: Web|Facebook|Twitter|LinkedIn
Waving? dave.m.auld[at]googlewave.com

priyaahh

Hi Dave, Yes I have noticed that and changed...but why the function is not returning anything. Regards, Priya.

DaveAuld

Because you haven't returned a value yet! remember you need to set the function name to the value you want to return;

Function getNodeAttributes(node As String) As String

'Do whatever you need

'Return the output to the caller
getNodeAttributes = str_att

End Function

Dave Don't forget to rate messages!
Find Me On: Web|Facebook|Twitter|LinkedIn
Waving? dave.m.auld[at]googlewave.com

priyaahh

Hi Dave, Thank you so much for ur kind and immediate reply...it worked. :-) Regards, Priya.