Because THAT'S what we should be worrying about...
-
Okay, so been at the new job for about 6 months. Oracle is not my favorite, but it's work. I sent some code to the "code review" group and our very cranky DBA said she did not approve it because it had...drumroll...TOO MANY COMMENTS. WTF? Comments in code up until now has been non-existent and she's worried that too many comments will just fill up the server. This coming from an Oracle DBA who has not recreated any indexes on tables in over 6 years (oh and I've found dozens that need it) and this is what she wants to kvetch about? Has anyone ever run across "too many comments" before? I've only heard "not enough" in the past.
Yeah, I need to update this. Darn Judge Judy reruns! http://CraptasticNation.blogspot.com/[^]
I ran into it one time. It was about twenty years ago and I was doing a contract job to port a chunk of code to another platform. I commented all of the tweaks I did to accommodate the new platform and the customer promptly removed them all when I gave them the code. I can't remember the exact reason now but I remember thinking it was ridiculous at the time.
-
I ran into it one time. It was about twenty years ago and I was doing a contract job to port a chunk of code to another platform. I commented all of the tweaks I did to accommodate the new platform and the customer promptly removed them all when I gave them the code. I can't remember the exact reason now but I remember thinking it was ridiculous at the time.
The reason was so that somebody could now say they editted your code. :)
Chris Meech I am Canadian. [heard in a local bar] In theory there is no difference between theory and practice. In practice there is. [Yogi Berra]
-
Okay, so been at the new job for about 6 months. Oracle is not my favorite, but it's work. I sent some code to the "code review" group and our very cranky DBA said she did not approve it because it had...drumroll...TOO MANY COMMENTS. WTF? Comments in code up until now has been non-existent and she's worried that too many comments will just fill up the server. This coming from an Oracle DBA who has not recreated any indexes on tables in over 6 years (oh and I've found dozens that need it) and this is what she wants to kvetch about? Has anyone ever run across "too many comments" before? I've only heard "not enough" in the past.
Yeah, I need to update this. Darn Judge Judy reruns! http://CraptasticNation.blogspot.com/[^]
You get that from DBAs all the time. At one of my past jobs, I got the same thing, and coincidentally, it was from an Oracle DBA.
.45 ACP - because shooting twice is just silly
-----
"Why don't you tie a kerosene-soaked rag around your ankles so the ants won't climb up and eat your candy ass..." - Dale Earnhardt, 1997
-----
"The staggering layers of obscenity in your statement make it a work of art on so many levels." - J. Jystad, 2001 -
Okay, so been at the new job for about 6 months. Oracle is not my favorite, but it's work. I sent some code to the "code review" group and our very cranky DBA said she did not approve it because it had...drumroll...TOO MANY COMMENTS. WTF? Comments in code up until now has been non-existent and she's worried that too many comments will just fill up the server. This coming from an Oracle DBA who has not recreated any indexes on tables in over 6 years (oh and I've found dozens that need it) and this is what she wants to kvetch about? Has anyone ever run across "too many comments" before? I've only heard "not enough" in the past.
Yeah, I need to update this. Darn Judge Judy reruns! http://CraptasticNation.blogspot.com/[^]
-
Okay, so been at the new job for about 6 months. Oracle is not my favorite, but it's work. I sent some code to the "code review" group and our very cranky DBA said she did not approve it because it had...drumroll...TOO MANY COMMENTS. WTF? Comments in code up until now has been non-existent and she's worried that too many comments will just fill up the server. This coming from an Oracle DBA who has not recreated any indexes on tables in over 6 years (oh and I've found dozens that need it) and this is what she wants to kvetch about? Has anyone ever run across "too many comments" before? I've only heard "not enough" in the past.
Yeah, I need to update this. Darn Judge Judy reruns! http://CraptasticNation.blogspot.com/[^]
leckey wrote:
Has anyone ever run across "too many comments" before? I've only heard "not enough" in the past.
Yes. I see comments like this all the time:
// Add some trees to the forest
forest.Add(someTrees);They don't help anyone understand what's going on anymore than the code already does, so I would classify them as "too many comments." I think it boils down to quality vs. quantity. I could riddle my code with comments like those above but they wouldn't help anyone. I could put a few well placed comments that describe how the algorithms in the code work and they would be much more useful. Cheers, Drew.
-
Maybe you should remove any whitespaces that are not necessary (like, who needs indention). Could save some bytes...
-
Okay, so been at the new job for about 6 months. Oracle is not my favorite, but it's work. I sent some code to the "code review" group and our very cranky DBA said she did not approve it because it had...drumroll...TOO MANY COMMENTS. WTF? Comments in code up until now has been non-existent and she's worried that too many comments will just fill up the server. This coming from an Oracle DBA who has not recreated any indexes on tables in over 6 years (oh and I've found dozens that need it) and this is what she wants to kvetch about? Has anyone ever run across "too many comments" before? I've only heard "not enough" in the past.
Yeah, I need to update this. Darn Judge Judy reruns! http://CraptasticNation.blogspot.com/[^]
hey there - nice to see you're still around - I looked at your blog last night and it hadnt been updated in a while : How's Kori and the menagerie ? anyway, I thought of this http://xkcd.com/327/[^] when I read your post .. ie 'I bet they dont sanitize their input either' be well G
-
Your statement on quality is kind of how I feel, but did not say (write) aloud. And comments are not even a standard here! After the discussion the standards were updated with "comments should be kept to a minimum." That's helpful.
Yeah, I need to update this. Darn Judge Judy reruns! http://CraptasticNation.blogspot.com/[^]
leckey wrote:
After the discussion the standards were updated with "comments
Unbelievable this is so stupid it defies reason. It is the exact opposite of what a good shop should require, and they call them standards. Sorry kiddo but you are working with a complete idiot and the real frightener is that she has the ability to influence "standards".
Never underestimate the power of human stupidity RAH
-
Okay, so been at the new job for about 6 months. Oracle is not my favorite, but it's work. I sent some code to the "code review" group and our very cranky DBA said she did not approve it because it had...drumroll...TOO MANY COMMENTS. WTF? Comments in code up until now has been non-existent and she's worried that too many comments will just fill up the server. This coming from an Oracle DBA who has not recreated any indexes on tables in over 6 years (oh and I've found dozens that need it) and this is what she wants to kvetch about? Has anyone ever run across "too many comments" before? I've only heard "not enough" in the past.
Yeah, I need to update this. Darn Judge Judy reruns! http://CraptasticNation.blogspot.com/[^]
Had a contractor work for me once, who was removing comments from existing code. He didn't like to see comments because, if they don't get updated when the code does, they can be confusing. While what he says is true, I rather felt that updating the comments may be more useful than deleting them.
___________________________________________ .\\axxx (That's an 'M')
-
Okay, so been at the new job for about 6 months. Oracle is not my favorite, but it's work. I sent some code to the "code review" group and our very cranky DBA said she did not approve it because it had...drumroll...TOO MANY COMMENTS. WTF? Comments in code up until now has been non-existent and she's worried that too many comments will just fill up the server. This coming from an Oracle DBA who has not recreated any indexes on tables in over 6 years (oh and I've found dozens that need it) and this is what she wants to kvetch about? Has anyone ever run across "too many comments" before? I've only heard "not enough" in the past.
Yeah, I need to update this. Darn Judge Judy reruns! http://CraptasticNation.blogspot.com/[^]
leckey wrote:
Has anyone ever run across "too many comments" before?
I've seen too many comments, but it was one comment line, followed by exactly one code line including incrementing a loop variable. Comments should document why, not common language idioms.
I can imagine the sinking feeling one would have after ordering my book, only to find a laughably ridiculous theory with demented logic once the book arrives - Mark McCutcheon
