My friend has written a function 831 lines long.
-
Hoornet@Job wrote: Do u know a longer function? no but I bet when you find it its written in VB
Stupidity dies. The end of future offspring. Evolution wins. - A Darwin Awards Haiku
Actually, I found one that was at least a thousand lines long. It was written in VC++, but it was really just FORTRAN code "ported" over. (To be fair, eventually that whole design was re-worked, and the function that took its place was less than 100 lines long. :-D ) Even a broken clock is right twice a day.
-
I've got a couple methods that are more than 500 lines long, therefore, I ask "So?" and as an argument, to consider that if it's commented, nicely formatted, and it makes sense, then there shouldn't be any problems with the code, as examplified by a common requirement that I have, in which I write a lot of analysis routines where performance is THE issue and the performance hit of a function call is unacceptable (and the compiler won't inline it), which results in very long functions. And run-on sentences. Marc Help! I'm an AI running around in someone's f*cked up universe simulator.
-
Hoornet@Job wrote: Do u know a longer function? A contracter did an ASP page for us once. It had to Add, Edit and Delete some records. He put everything into one page and repeated all the HTML for each function. The page is 5423 lines long. When I press page down in VS.NET it takes 5 seconds before the screen updates! Suffice to say we deleted the page and re-did it, because trying to edit that monster would have taken longer.
Paul Watson
Bluegrass
Cape Town, South AfricaColin Davies wrote: ...can you imagine a John Simmons stalker !
I worked with someone that did that. The page was at least 5000 lines. I also worked with someone that used multiple connection objects in an ASP page to run multiple queries. A new connection for every query, and there were quite a few queries. It was all connecting to the same database. Quite sad actually. Jason Gerard "This almost never matters, except quite often."
-
Navin wrote: Just buy a faster machine. Ah yes, the perfect solution. I'm going to tell my client to buy 2500 new machines so they can run my poorly written code ;P ... Performance in code is still important, even with the machines we have today. Don't want to end up as a VB "programmer" that writes poor code... ----------------------- New and improved: kwakkelflap.com My first CP article: Pseudoregisters[^] "When I hear of Schrödinger's cat, I reach for my gun." - Stephen Hawking
-
In my company i got the task to modify something in my friend Visual C code. Imagine my surprise when I saw a function 831 linel long!!! Do u know a longer function? Love is the law, love under will.
Sorry guys, but I've got you all beat. I only heard about this after the fact but a colleague of mine in another department was given the task of writting a function which, given one "name" would return a shorter equivalent. Weeks later he emerged triumphant and presented the world with a VB function which consisted of one long Select statement. I dont know how many lines long the function was, but we printed it out onto A4 sheets. It took over half an hour and the stack was 2 inches thick. Now thats a function! Needless to say, someone wrote a 5 line equivalent that just did a look up in an Access table. Pete
Insert Sig. Here!
-
In my company i got the task to modify something in my friend Visual C code. Imagine my surprise when I saw a function 831 linel long!!! Do u know a longer function? Love is the law, love under will.
Sure. I've just finished consulting at a large company that has a VB class over 10,000 lines long and with some functions well over 1500 lines long. How's them apples? Cheers, Simon "From now on, if rogue states want to buy weapons of mass destruction, they're going to have to go on eBay," Mr. Bezos said.
-
In my company i got the task to modify something in my friend Visual C code. Imagine my surprise when I saw a function 831 linel long!!! Do u know a longer function? Love is the law, love under will.
Longest I've seen: around 7400 lines. It's a c++ function to parse a string using a state machine / huge switch (with other switches in the cases). ----------------------- New and improved: kwakkelflap.com My first CP article: Pseudoregisters[^] "When I hear of Schrödinger's cat, I reach for my gun." - Stephen Hawking
-
Longest I've seen: around 7400 lines. It's a c++ function to parse a string using a state machine / huge switch (with other switches in the cases). ----------------------- New and improved: kwakkelflap.com My first CP article: Pseudoregisters[^] "When I hear of Schrödinger's cat, I reach for my gun." - Stephen Hawking
Kwakkie wrote: around 7400 lines :wtf:
Simon Walton
Sonork: 10024P
-
I worked with someone that did that. The page was at least 5000 lines. I also worked with someone that used multiple connection objects in an ASP page to run multiple queries. A new connection for every query, and there were quite a few queries. It was all connecting to the same database. Quite sad actually. Jason Gerard "This almost never matters, except quite often."
Jason Gerard wrote: I also worked with someone that used multiple connection objects in an ASP page to run multiple queries. A new connection for every query, and there were quite a few queries. It was all connecting to the same database. Quite sad actually. If he closed the connection right after using it, sorry to say, but he was right. The IIS will manage a ADO connection pool and "closing" a connection returns it more quickly to the pool. My latest article: SQL Server DO's and DONT's[^]
-
In my company i got the task to modify something in my friend Visual C code. Imagine my surprise when I saw a function 831 linel long!!! Do u know a longer function? Love is the law, love under will.
We have a bought in third party control, functions regulary reach 3k lines. But a trainer came in one time, and scared us senseless with a story of a function witten at HP which was 20k lines long. :wtf: if(E_NOINTERFACE == pThat->QueryInterface(IID_IUnknown,(void**)&pUnk)) { // I aint no pUnk bitch! }
-
Longest I've seen: around 7400 lines. It's a c++ function to parse a string using a state machine / huge switch (with other switches in the cases). ----------------------- New and improved: kwakkelflap.com My first CP article: Pseudoregisters[^] "When I hear of Schrödinger's cat, I reach for my gun." - Stephen Hawking
Nah, code generated by YACC doesn't count :) My latest article: SQL Server DO's and DONT's[^]
-
In my company i got the task to modify something in my friend Visual C code. Imagine my surprise when I saw a function 831 linel long!!! Do u know a longer function? Love is the law, love under will.
Hoornet@Job wrote: In my company i got the task to modify something in my friend Visual C code. Imagine my surprise when I saw a function 831 linel long!!! The worst kind of code is when you see a big function calling several other fellow big functions :) My latest article: SQL Server DO's and DONT's[^]
-
Nah, code generated by YACC doesn't count :) My latest article: SQL Server DO's and DONT's[^]
LOL. Well, it isn't. Count exactly: 7428 lines... (and growing). How on earth can you get 7400 lines function of YACC generated code. Our generated code is split up nicely in different functions (although we have big tables of course). Won't try to read it though... ----------------------- New and improved: kwakkelflap.com My first CP article: Pseudoregisters[^] "When I hear of Schrödinger's cat, I reach for my gun." - Stephen Hawking
-
Hoornet@Job wrote: In my company i got the task to modify something in my friend Visual C code. Imagine my surprise when I saw a function 831 linel long!!! The worst kind of code is when you see a big function calling several other fellow big functions :) My latest article: SQL Server DO's and DONT's[^]
-
Jason Gerard wrote: I also worked with someone that used multiple connection objects in an ASP page to run multiple queries. A new connection for every query, and there were quite a few queries. It was all connecting to the same database. Quite sad actually. If he closed the connection right after using it, sorry to say, but he was right. The IIS will manage a ADO connection pool and "closing" a connection returns it more quickly to the pool. My latest article: SQL Server DO's and DONT's[^]
Well, I don't recall everything about the page, this was about 2 years ago. I know I trashed it and rewrote it with just one object and it went from taking 30+ seconds to load to just under 1-3 seconds. Jason Gerard "This almost never matters, except quite often."
-
Sorry guys, but I've got you all beat. I only heard about this after the fact but a colleague of mine in another department was given the task of writting a function which, given one "name" would return a shorter equivalent. Weeks later he emerged triumphant and presented the world with a VB function which consisted of one long Select statement. I dont know how many lines long the function was, but we printed it out onto A4 sheets. It took over half an hour and the stack was 2 inches thick. Now thats a function! Needless to say, someone wrote a 5 line equivalent that just did a look up in an Access table. Pete
Insert Sig. Here!
And the amazing thing is that the database server actually accepted and parsed it???? :omg: Marc Help! I'm an AI running around in someone's f*cked up universe simulator.
-
And the amazing thing is that the database server actually accepted and parsed it???? :omg: Marc Help! I'm an AI running around in someone's f*cked up universe simulator.
Marc Clifton wrote: the database server actually accepted and parsed it ? If you're asking how we generated the Access table, its pretty easy to write a parser for such a small set of language.
Case "Peter" GetShortName = "Pete" Case "Joeseph" GetShortName = "Joe"Then just put the "Case" token in the LongName column and the "GetShortName" token in the ShortName column. Horrible! Oh, it just makes me cringe every time I think of it...Uuuugggghghhh... Pete
Insert Sig. Here!
-
Hoornet@Job wrote: Do u know a longer function? A contracter did an ASP page for us once. It had to Add, Edit and Delete some records. He put everything into one page and repeated all the HTML for each function. The page is 5423 lines long. When I press page down in VS.NET it takes 5 seconds before the screen updates! Suffice to say we deleted the page and re-did it, because trying to edit that monster would have taken longer.
Paul Watson
Bluegrass
Cape Town, South AfricaColin Davies wrote: ...can you imagine a John Simmons stalker !
No, he's talking about program code. Writing HTML pages is NOT programming. ------- signature starts "...the staggering layers of obscenity in your statement make it a work of art on so many levels." - Jason Jystad, 10/26/2001 Please review the Legal Disclaimer in my bio. ------- signature ends
-
Jason Gerard wrote: I also worked with someone that used multiple connection objects in an ASP page to run multiple queries. A new connection for every query, and there were quite a few queries. It was all connecting to the same database. Quite sad actually. If he closed the connection right after using it, sorry to say, but he was right. The IIS will manage a ADO connection pool and "closing" a connection returns it more quickly to the pool. My latest article: SQL Server DO's and DONT's[^]
Daniel Turini wrote: If he closed the connection right after using it, sorry to say, but he was right. The IIS will manage a ADO connection pool and "closing" a connection returns it more quickly to the pool. I think Jason meant there was a connection object for each query, not one re-used connection object. e.g.
set oconn1 = server.create....
set rs1 = server.create...set oconn2 = server.create....
set rs2 = server.create...set oconn3 = server.create....
set rs3 = server.create...That surely cannot be right.
Paul Watson
Bluegrass
Cape Town, South AfricaColin Davies wrote: ...can you imagine a John Simmons stalker !
-
In my company i got the task to modify something in my friend Visual C code. Imagine my surprise when I saw a function 831 linel long!!! Do u know a longer function? Love is the law, love under will.
Not only have I come across functions with a greater number of lines, how's about what the functions were to do! I took over a DB reporting app that had a CView derived class that generated SQL on the fly, queried the database, built a huge array of strings to hold all the data. Only problem was it did this all in the OnDraw() method. Guess what happened whenever you tried to scroll the window? :) Or printed a report. Chris Meech "what makes CP different is the people and sense of community, things people will only discover if they join up and join in." Christian Graus Nov 14, 2002. "AAAAAAAAAHHHHHH!!!!! Those leaks are driving me crazy! How does one finds a memory leak in a garbage collected environment ??! Daniel Turini Nov. 2, 2002.
