Recent two hours in work
-
My most recent two hours spent in work (Java Dev.) - Holy crap, what a mess... - refactor, refactor, refactor, refactor (after 1.5h) - Aww.. - revert, revert, revert, revert Some of you probably know my pain... X|
Greetings - Jacek
Jacek Gajek wrote:
Some of you probably know my pain..
Many of us will probably know your pain. Ok I'll get back to work now. Refactor, refactor, refactor, refactor....
The funniest thing about this particular signature is that by the time you realise it doesn't say anything it's too late to stop reading it.
-
My most recent two hours spent in work (Java Dev.) - Holy crap, what a mess... - refactor, refactor, refactor, refactor (after 1.5h) - Aww.. - revert, revert, revert, revert Some of you probably know my pain... X|
Greetings - Jacek
-
My most recent two hours spent in work (Java Dev.) - Holy crap, what a mess... - refactor, refactor, refactor, refactor (after 1.5h) - Aww.. - revert, revert, revert, revert Some of you probably know my pain... X|
Greetings - Jacek
I spent the day up to now in a similar fashion, only that I did not have to do any refactoring. It was our Padawan who I had to coach through refactoring his code. He invented some absolutely new and never before seen patterns along the way. But now we finally agreed on the right way again :)
"I just exchanged opinions with my boss. I went in with mine and came out with his." - me, 2011 ---
I am endeavoring, Madam, to construct a mnemonic memory circuit using stone knives and bearskins - Mr. Spock 1935 and me 2011 -
it could be worse, you could have found out your refactoring broke a module that should not even be aware of your refactoring...
And that is why we have unit tests :-).
Sort of a cross between Lawrence of Arabia and Dilbert.[^]
-Or-
A Dead ringer for Kate Winslett[^] -
And that is why we have unit tests :-).
Sort of a cross between Lawrence of Arabia and Dilbert.[^]
-Or-
A Dead ringer for Kate Winslett[^]yeah, the system in question has those, over 10,000 of them in fact. there's just one problem, the team that produced those code gems went about and "fixed" the unit tests so they would never fail... (i'd kill em, but none of them is working for the company any more...)
-
My most recent two hours spent in work (Java Dev.) - Holy crap, what a mess... - refactor, refactor, refactor, refactor (after 1.5h) - Aww.. - revert, revert, revert, revert Some of you probably know my pain... X|
Greetings - Jacek
Ah, the Java way: take out one simple 20 lines long function and make it a class with reflection instead of function arguments, extract an interface from the new class and implement it, create some base class from our class (yes, not the other way around) and if you feel like it, make it abstract now put all this crap in three different files and make some utter useless java docs for it. Since you are on it, create unit tests classes for your classes and import log4j engine into all your classes to log some meaningless sh!ts coming from the pile of exceptions you are using instead of conditional statements. :-D
There is only one Ashley Judd and Salma Hayek is her prophet! Advertise here – minimum three posts per day are guaranteed.
-
yeah, the system in question has those, over 10,000 of them in fact. there's just one problem, the team that produced those code gems went about and "fixed" the unit tests so they would never fail... (i'd kill em, but none of them is working for the company any more...)
randprin wrote:
none of them is working for the company any more...)
That shouldn't stop you.
Software Zen:
delete this; -
And that is why we have unit tests :-).
Sort of a cross between Lawrence of Arabia and Dilbert.[^]
-Or-
A Dead ringer for Kate Winslett[^] -
Ah, the Java way: take out one simple 20 lines long function and make it a class with reflection instead of function arguments, extract an interface from the new class and implement it, create some base class from our class (yes, not the other way around) and if you feel like it, make it abstract now put all this crap in three different files and make some utter useless java docs for it. Since you are on it, create unit tests classes for your classes and import log4j engine into all your classes to log some meaningless sh!ts coming from the pile of exceptions you are using instead of conditional statements. :-D
There is only one Ashley Judd and Salma Hayek is her prophet! Advertise here – minimum three posts per day are guaranteed.
Yeah it's something like this. Without any exaggeration. One thing is different, though. The project had started in 2008 and there wasn't any unit tests made since then. They would take too much time, you know. There is 16,0 MB of pure source code and 3344 classes. I suppose it's worth to mention that there are two people assigned to it. One of them is me, a student who comes here two times a week... :wtf:
Greetings - Jacek
-
Jacek Gajek wrote:
Some of you probably know my pain..
Many of us will probably know your pain. Ok I'll get back to work now. Refactor, refactor, refactor, refactor....
The funniest thing about this particular signature is that by the time you realise it doesn't say anything it's too late to stop reading it.
Abhinav S wrote:
Ok I'll get back to work now.
Refactor, refactor, refactor, refactor....Yeah cool, but my work is to implement a specific feature. I though: OK I will fix this design a little and get back to work. Nope, the codebase told to me.
Greetings - Jacek