Bug of the day

[edmurphy99]

well I see this has already been answered but I like to use print to see what variables really are

DECLARE @SuppressionMethod varchar(20)

-- ... lots of code...

SET @SuppressionMethod = 'SkipSuppressedMembers'
print @SuppressionMethod
--returns SkipSuppressedMember

[YvesDaoust]

In this case, blame can be put on the programming language: it should have warned you of the string overflow. Computers are ill-mannered when they do not tell us about our mistakes that they have spotted.

[Fabio Franco]

It's to mask the fact they are worse on everything else.

"To alcohol! The cause of, and solution to, all of life's problems" - Homer Simpson

[Victor Ulloa]

SkipSuppressedMembers has 21 chars, not 20. You're comparing lower('SkipSuppressedMember') against skipsuppressedmembers

[Kabwla Phone]

To feed the trolls and have the string fit in the variable, you might consider increasing the length of said troll variable. Other problems in the code, using 'lower' to do a string comparission in SQL, which is case insensitive (unless you start toying with the collation).

[agolddog]

How about varchar(more)?

[BrainiacV]

It should be a SELECT, not a SET?.

Psychosis at 10 Film at 11 Those who do not remember the past, are doomed to repeat it. Those who do not remember the past, cannot build upon it.

[Chris Maunder]

No. Take a look at the other zillion responses :)

cheers, Chris Maunder The Code Project | Co-founder Microsoft C++ MVP

[User 8347395]

After fixing the size of the SuppressionMethod, it seems like you will also have a problem with the "if" in that, you are assigning the values, not really checking to see if it is... If lower(@SuppressionMethod) = 'skipsuppressedmembers' Begin Should be... [IMHO] if lower(@SuppressionMethod) == 'skipsuppressedmembers' Begin Just a thought.

[BarrRobot]

I first saw a bug like that in the 1980s, in Fortran. The system fell over on startup on Monday, 2nd September. Hint 1: The office was closed and the system shut down over the weekend. Hint 2: Which month has the longest name (it was English)? (And it wasn't me who did it!)

[Mel Padden]

Member 8382884 wrote:

if lower(@SuppressionMethod) == 'skipsuppressedmembers'
Begin

Have you tried entering that in an SQL editor and running it? Just a thought.

Beautiful is better than ugly. Explicit is better than implicit. Simple is better than complex. Complex is better than complicated. Flat is better than nested. Sparse is better than dense. In the face of ambiguity, refuse the temptation to guess.

[RDSchaefer]

Well, aside from the obvious which everyone else has commented on, my first question would be "Why is he checking a value that he just set in the previous statement?" Was there some other code that you omitted?

[Chris Maunder]

RDSchaefer wrote:

Was there some other code that you omitted?

I want to say "yes, obviously" but maybe it wasn't obvious. I didn't see the need to include all my code when showing an example.

cheers, Chris Maunder The Code Project | Co-founder Microsoft C++ MVP

[Earl Truss]

Yes, I can. It took about thirty seconds.

[Virendra Deshmukh]

first line varchar(21) becoz string contains 21 chars