Not programming, but a preference question.
-
Dang, maybe I should have clarified. I meant Hungarian Notation "style", not strictly varName, etc. Example:
var BeginDate = item.GetType().GetProperty("BeginDate");
var Locations = item.GetType().GetProperty("Locations");I would prefer to be
var propBeginDate = item.GetType().GetProperty("BeginDate");
var propLocations = item.GetType().GetProperty("Locations");or something like that. This is more of an example of what I meant. I guess I should have initially said, am I dick for changing variables to make more sense?
-
I use Refactor! Pro[^]. Right click on the offending var declared varable and choose 'Make explicit' and there I have a decently declared varable. I'm pretty sure other refactoring tools have a similar feature.
Espen Harlinn Principal Architect, Software - Goodtech Projects & Services AS My LinkedIn Profile
-
varreminds me to VB'sDimand is - from the engineering perspective - a regression. For me it's a good practice to document/describe which type of variable you are working.Cheers, Jani Giannoudis Meerazo.com - Resource Sharing Made Easy | Co-founder
-
There are no errors, just confusion for the abuse of var keyword. The types instantiated are fully qualified types, you just don't see them in the left hand side because the var keyword was used.
To alcohol! The cause of, and solution to, all of life's problems - Homer Simpson ---- Our heads are round so our thoughts can change direction - Francis Picabia
Compile Colin's code "as is," and examine the errors. best, Bill
"The greatest mystery is not that we have been flung at random between the profusion of matter and of the stars, but that within this prison we can draw from ourselves images powerful enough to deny our nothingness." Andre Malraux
-
Collin Jasnoch wrote:
var component = new ThirdPartyNameSpace.RequiredComponent(); var diffComponent = new DifferentThirdPartyNameSpace.RequiredComponent();
I read this and thought: "What the hell is the type returned by this methods?" "Oh wait, these are not methods, these are fully qualified types." Can you picture the ammount of unnecessary confusion created by this code when someone else try to read it? Or even your self after sometime? This easy to write and terrible to read. If you inherit a code that has a lot of vars good luck sweeping the code to understand its purpose. If you have a printed copy of the code, well then there is no way to understand the code.
Collin Jasnoch wrote:
ThirdPartyNameSpace.RequiredComponent ewComponent = new ThirdPartyNameSpace.RequiredComponent();
That's what the "#using" directive is for, then you would have:
RequiredComponent notEwAtAllComponent = new RequiredComponent()
Now you have a very readable code and intellisense made it not hard to type, magic heh? When looking at the code from a mostly left to right culture I can instantly identify the type being declared. Second, if you have components with same names and different namespaces, you can make it much shorter also with the "#using" directive: #using ThirdPartyNameSpace; #using diffNS = DifferentThirdPartyNameSpace;
diffNS.RequiredComponent diffComponent = diffNS.RequiredComponent();
Lastly, var should be used for anonymous types. That's the real good use of it and shouldn't be abused like I often see. Your particular example is a hell to review.
To alcohol! The cause of, and solution to, all of life's problems - Homer Simpson ---- Our heads are round so our thoughts can change direction - Francis Picabia
How is:
diffNS.RequiredComponent diffComponent = new diffNS.RequiredComponent();
// WTF? I can't find the "diffNS" namespace anywhere in the code!
// Oh, wait - it's hidden in a "using" statement somewhere else in the file.
// I'll just scan *the entire file* to find out what it really is, then.any easier to read than:
var diffComponent = new DifferentThirdPartyNameSpace.RequiredComponent();
// What? .......... Ah, I see! It's a DifferentThirdPartyNameSpace.RequiredComponent:confused:?
"These people looked deep within my soul and assigned me a number based on the order in which I joined." - Homer
-
ahmed zahmed wrote:
var should only be used where the type can be easily ascertained
No, that's wrong -- it should only be used when the developer can't know the type, as in
ahmed zahmed wrote:
when using LINQ
PIEBALDconsult wrote:
it should only be used when the developer can't know the type
No, that's wrong. ;P
// Wrong! BAD developer!
Dictionary<string, Tuple<Customer, List<Order>>> customerOrdersCache = new Dictionary<string, Tuple<Customer, List<Order>>>();// Much better! Have a banana!
var customerOrdersCache = new Dictionary<string, Tuple<Customer, List<Order>>>();
"These people looked deep within my soul and assigned me a number based on the order in which I joined." - Homer
-
Compile Colin's code "as is," and examine the errors. best, Bill
"The greatest mystery is not that we have been flung at random between the profusion of matter and of the stars, but that within this prison we can draw from ourselves images powerful enough to deny our nothingness." Andre Malraux
Yeah, I know, case sensitiveness typo on namespace, the ellipses... Way out of the scope of this discussion
To alcohol! The cause of, and solution to, all of life's problems - Homer Simpson ---- Our heads are round so our thoughts can change direction - Francis Picabia
-
How is:
diffNS.RequiredComponent diffComponent = new diffNS.RequiredComponent();
// WTF? I can't find the "diffNS" namespace anywhere in the code!
// Oh, wait - it's hidden in a "using" statement somewhere else in the file.
// I'll just scan *the entire file* to find out what it really is, then.any easier to read than:
var diffComponent = new DifferentThirdPartyNameSpace.RequiredComponent();
// What? .......... Ah, I see! It's a DifferentThirdPartyNameSpace.RequiredComponent:confused:?
"These people looked deep within my soul and assigned me a number based on the order in which I joined." - Homer
Richard Deeming wrote:
// Oh, wait - it's hidden in a "using" statement somewhere else in the file.
Visual Studio: Right click -> Go to Definition Printed: It's the first thing you gonna see. Anyways, the worse case scenario here is when you find the necessity to fully qualify types for when you have same named classes over different namespaces within the same file. You gotta admit this is very rare. It happened to me only once with the Color and Report class. The latter was my mistake to use such a generic and and not descriptive class name on a big solution.
To alcohol! The cause of, and solution to, all of life's problems - Homer Simpson ---- Our heads are round so our thoughts can change direction - Francis Picabia
-
the thing that tells me that it's an implicitly typed local variable is the keyword var. I've got a VS extension (can't remember which one, sorry) that tells me the exact type when I hover over it with the mouse. As for naming conventions, I'm of the opinion that the name should semantically express the usage, so this would be totally fine with me:
var count = 0;
I can tell from the name what it's there for and by the assignment I can tell it's an int. I understand that some people might get confused by this:
var count = someObject.GetCount();
But all the above example means is that the above *might* be a short or long, and you can mouseover the method call in the assignment if you're desperate to know the exact type you're assigning. It's a whole number of some sort. If you're assigning anything other than int, short or long from a method called GetCount(), your method naming is wrong. Using a single byte to return a count is a bit of a special case which is why I haven't mentioned it. I've also never encountered a need to do so, incidentally. For some reason I get quite annoyed when people claim using var is bad practice because it introduces bugs to the code or don't get the fact that it's not the same as dynamic typing because they think it's the same as JavaScript. var works just fine, it means I don't repeat myself all over the place and is statically typed which means it won't even compile if I've done something wrong.
I agree with Jim. It's too bad that it seems so easy to confuse and make developers feel insecure with code. We spend more time looking for crutches than understanding the code abstractions and how to use them to our benefit.
I would imagine if you could understand Morse Code, a tap dancer would drive you crazy. [Mitch Hedberg (American Comedian, 1968-2005)]
-
Richard Deeming wrote:
// Oh, wait - it's hidden in a "using" statement somewhere else in the file.
Visual Studio: Right click -> Go to Definition Printed: It's the first thing you gonna see. Anyways, the worse case scenario here is when you find the necessity to fully qualify types for when you have same named classes over different namespaces within the same file. You gotta admit this is very rare. It happened to me only once with the Color and Report class. The latter was my mistake to use such a generic and and not descriptive class name on a big solution.
To alcohol! The cause of, and solution to, all of life's problems - Homer Simpson ---- Our heads are round so our thoughts can change direction - Francis Picabia
Fabio Franco wrote:
Visual Studio:
Right click -> Go to DefinitionYeah, that doesn't interfere with "sweeping the code to understand its purpose" at all! ;P It's easier to scan a "
var x = new RealName()" statement than a "AliasedName x = new AliasedName()" statement.
"These people looked deep within my soul and assigned me a number based on the order in which I joined." - Homer
-
Yeah, I know, case sensitiveness typo on namespace, the ellipses... Way out of the scope of this discussion
To alcohol! The cause of, and solution to, all of life's problems - Homer Simpson ---- Our heads are round so our thoughts can change direction - Francis Picabia
Hi Fabio, The two only really important errors relate to the incorrect usage of 'var: which is exactly what this topic is about ! best,Bill
"The greatest mystery is not that we have been flung at random between the profusion of matter and of the stars, but that within this prison we can draw from ourselves images powerful enough to deny our nothingness." Andre Malraux
-
Hi Fabio, The two only really important errors relate to the incorrect usage of 'var: which is exactly what this topic is about ! best,Bill
"The greatest mystery is not that we have been flung at random between the profusion of matter and of the stars, but that within this prison we can draw from ourselves images powerful enough to deny our nothingness." Andre Malraux
Wouldn't it be easier then if you would just elaborate without everyone having to compile the code to understand what you are talking about?
To alcohol! The cause of, and solution to, all of life's problems - Homer Simpson ---- Our heads are round so our thoughts can change direction - Francis Picabia
-
var
A big ugly word. I don't use them unless I really need to. Now I have a project to add to that another developer created. Cool. There are a lot of vars in here. Unavoidable, too. Now, I'm the head "developer" on this team, and basically have to know all code inside and out pretty darm well. So does it make me a dick to want to use some sort of Hungarian Notation* on these vars? [Editing for clarity] I do not mean adding var to the front, or necessarily the type (though that will be useful in some cases, that's why I mistakenly said HN) I meant using a short form abbreviation to signify what the hell the variable is for rather than just "Loc" "Cust" etc when there are many similar variables.
Correct me if I'm wrong in my inference but it sounds like your saying that the code is not properly commented. If that is the case then the answer is clearly no. On the other hand, you could simply add comments that inform you what the various vars are intended to accomplish and then change variable names from there. By commenting first, you are less likely to change a variable name that accomplishes nothing more than blowing the whole program up. Then again, you already knew that didn't you? Scott A. Tovey
-
Hmmm pretty sure it is fine. For one they are not subclasses. They are classes within a namespace. This is a common confliction when working with many groups or using external resources, E.g Company a has "Camera" in their library as well as company B. So we end up with CompanyA.Camera And CompanyB.Camera For objects. That was actually the point that you must then call out the whole namespace multiple times. Or am I missing something that you are pointing out?
Computers have been intelligent for a long time now. It just so happens that the program writers are about as effective as a room full of monkeys trying to crank out a copy of Hamlet.
Yes, esteemed colleague, Colin, you are missing something, and it's an understanding of how you can "legally" use 'var. Since the use of 'var is a major focus of this thread, I feel that's important. I would never have commented on your code based solely on errors in spelling. And, the comment on two classes with duplicate names was meant as a "lightweight" suggestion, not an attack. Surely it is not too much to ask for anyone who posts code, even here on the Lounge, to compile it, and see if it compiles ? Meanwhile, may the hair-trigger fingered down-voters (and I don't mean you) just keep having at me, because I will say what I see, and the compiler (VS 2012 RC in this case) reports as errors :) best, Bill
"The greatest mystery is not that we have been flung at random between the profusion of matter and of the stars, but that within this prison we can draw from ourselves images powerful enough to deny our nothingness." Andre Malraux
-
wizardzz wrote:
propBeginDate
why "prop"? The "type" or "what it is" is already part of the name. BeginDate
If your actions inspire others to dream more, learn more, do more and become more, you are a leader." - John Quincy Adams
You must accept one of two basic premises: Either we are alone in the universe, or we are not alone in the universe. And either way, the implications are staggering” - Wernher von BraunActually you should check again since I don't think that BeginDate is a DateTime object at all, but a PropertyInfo object instead. I think its a perfect example. propBeginDate
-
wizardzz wrote:
since almost every single variable is a var, it's taking quite some time to figure out why some choices were made
That is my main dislike of var - when you are trying to read the code, you have no idea what a variable is, or what you can do with it, without looking at some other bit of code and coming back. Explicit variable typing lets you know immediately what type it is and hence what you can do with it. Besides, it's lazy. "I don't want to think about this variable, it just want to get on with the interesting stuff".
Ideological Purity is no substitute for being able to stick your thumb down a pipe to stop the water
I couldn't agree with you more. I've never once come back on my old code and exclaimed "Why in the world was I so explicit!?", though I have wondered the contrary on some occasions.
-
I'm not near as stringent on the use of `var`. If my data types are short - e.g., string, int, List(Of T) - I use the explicit syntax for declaring the type. On the other hand, something like
Dictionary>
...damned right I'm using `var`. It's up to the developer to make sure the variable name is meaningful - not the declaration of the data type. Yes, be responsible with the use of `var`. `var` is necessary in a few cases - as with LINQ and anonymous types. Make sure if you want an `IFoo` from a method that returns `Foo` that you cast it:
var foo = GetFoo() as IFoo;
// where GetFoo():
Foo GetFoo() {
return new Foo();
}// and
class Foo : IFoo { }I certainly don't recommend leaving fate in the hands of `var`. Overuse is abuse. And abusing `var` is downright lazy. But I wouldn't get that worked up about it - maybe. :-D
Sadly there are tools like ReSharper that are required use in some shops that nag you to death about using "var" in place of strongly typed declarations. Yes, I turn off that in my settings but some other developer will come behind me and change all my code in my tools to use "var" everywhere. I'd love to meet the person who created that rule in ReSharper and punch them in the face. Seriously.
Mike Poz
-
I do not see why people get hung up on var. (I am quite certain I will ge downvoted for this post) IMO it is cleaner.
namespace ThirdPartynamespace
{
class RequiredComponent
{
}
}...
namespace DifferentThirdPartyNamespace
{
class RequiredComponent
{
}
}namespace Local
{
class Thingamajig
{
var component = new ThirdPartyNameSpace.RequiredComponent();
var diffComponent = new DifferentThirdPartyNameSpace.RequiredComponent();
//vsThirdPartyNameSpace.RequiredComponent ewComponent = new ThirdPartyNameSpace.RequiredComponent(); DifferentThirdPartyNameSpace.RequiredComponent ewDiffComponent = new DifferentThirdPartyNameSpace.RequiredComponent();}
}Ok, so now you will say that is a rare case. Maybe it is but because this case happens (actually it happens to me alot but mostly because how I use namespaces), you should follow patterns being set. You may not be always worried about thread mishaps but you still program for it. Other reasons: Return object changes.
Computers have been intelligent for a long time now. It just so happens that the program writers are about as effective as a room full of monkeys trying to crank out a copy of Hamlet.
-
var
A big ugly word. I don't use them unless I really need to. Now I have a project to add to that another developer created. Cool. There are a lot of vars in here. Unavoidable, too. Now, I'm the head "developer" on this team, and basically have to know all code inside and out pretty darm well. So does it make me a dick to want to use some sort of Hungarian Notation* on these vars? [Editing for clarity] I do not mean adding var to the front, or necessarily the type (though that will be useful in some cases, that's why I mistakenly said HN) I meant using a short form abbreviation to signify what the hell the variable is for rather than just "Loc" "Cust" etc when there are many similar variables.
Why not just write in javascript: everything is declared as var; same as dim in vbscript. :-D
-
See how var can be a source of confusion?
To alcohol! The cause of, and solution to, all of life's problems - Homer Simpson ---- Our heads are round so our thoughts can change direction - Francis Picabia
