Chat Server Issue

[Joshua Waring]

OKAY so here comes the update, I've added it into threads but now a unknown error occurs. Thanks to a debugger I know where and when it occurs but I don't know why. I get a exceptionNullPointer at line 11 of Users.java br = new BufferedReader(new InputStreamReader(socket.getInputStream()));

import java.net.*;
import java.io.*;

public class Room implements Runnable{
public void run(){
ServerSocket serversocket;
Socket socket;
Clients client = new Clients();
try{
// Created a socket in which clients can connect to.
serversocket = new ServerSocket(7776);
// Waits for a client to connect to the server //
while(true){
socket = serversocket.accept();
System.out.println("Client connected" + socket);
// Starts their thread
client.newThread(socket);
}
}catch(IOException e){
System.out.println(e);
}
}
public static void main(String[] args){
(new Thread(new Room())).start();
}
}

import java.io.BufferedReader;
import java.io.IOException;
import java.net.Socket;

public class Clients implements Runnable{
Socket socket1;
public void run(){
Socket socket2 = socket1;
Users userfunction = new Users();
BufferedReader bf;
bf = userfunction.addStream(socket2);
while(true){
// Receives a Message.
try{
String out = bf.readLine();
System.out.println(out);
if(out != null)
userfunction.sendMessageALL(out);

		}catch(IOException e){
			System.out.println(e);
		}
		try{
			Thread.sleep(10);
		} catch (InterruptedException e) {}
	}
}
public void newThread(Socket socket){
	// Creates one thread for ever client, to parse the socket I sent it to socket1 which is then
	// received in the thread which is taken to socket2..
	socket1 = socket;
	(new Thread(new Clients())).start();
}

}

import java.net.*;
import java.io.*;
import java.util.ArrayList;

public class Users {
ArrayList recieveAL = new ArrayList();
ArrayList sendAL = new ArrayList();
// Creates the BufferedReader and PrintWriter then returns the Reader since the Writer it maintained in the class for the sendMessageAll method.
public BufferedReader addStream(Socket socket){
BufferedReader br;
PrintWriter pw;
try{
br = new BufferedReader(new InputStreamReader(socket.getInputStream()));
pw = new PrintWriter(socket.getOutputStream(), true);
recieveAL.add(br);
sendAL.

[pasztorpisti]

probably because there is a null pointer there. why don't you debug your code?

[pasztorpisti]

OK, here are a few suggestions: 1. I see you are coming from C because you declare all your function local variables at the beginning of the functions (sorry, methods). Declare your variables where you use it, or at least most most-inner scope where you need it. 2. Room does not have to implement the Runnable interface and you dont have to create a new thread for the room in your main(), call the run() method directly and execute it with the main thread. 3. The biggest mistake that causes the nullpointer is in Client.newThread: you should pass in this instead of new Clients(). I would do the work of Client.newThread in the constructor of Client and would create Client only after accepting the socket.

[Joshua Waring]

A null pointer is when it returns a Null, right? I don't see the problem because that part of the code is unchanged. so why return an error now

[pasztorpisti]

You have a serious bug in your newThread() method that causes the nullpointer exception.

[Joshua Waring]

I really don't understand, this is currently beyond me at the moment.

[pasztorpisti]

Well, object oriented programming is not easy at first. Socket/network programming is also hard. Threading is another beast. And you are mixing all of these, are you sure this is what you wanna do?

[Joshua Waring]

I'm committed to learn it and since I'm self taught, I've decided to throw myself in and learn how it all works then learn in more depth.

[pasztorpisti]

I don't recommend doing so, but good luck!

[Joshua Waring]

Parsing the Socket into the thread was my screw up, so It was replaced with parameters of the thread.