DOH!!!

Lost User

_Josh_ wrote:

Shandy

He's not going to be able to only target me now, you'll have to be in his sights.

Michael Martin Australia "I controlled my laughter and simple said "No,I am very busy,so I can't write any code for you". The moment they heard this all the smiling face turned into a sad looking face and one of them farted. So I had to leave the place as soon as possible." - Mr.Prakash One Fine Saturday. 24/04/2004

J4amieC

Im surprised nobody has pointed out that the method you want is ShowDialog not Show

OriginalGriff

That might be because there is no MessageBox.ShowDialog method... :-D

Ideological Purity is no substitute for being able to stick your thumb down a pipe to stop the water

OriginalGriff

You do get a warning however:

Warning 1 Possible mistaken empty statement

This is why I run with "Treat Warnings as Errors" set to "All" - it catches these, and won't let me run until I fix 'em. (It also means I can't get away with missing out the XML comments because "I'll come back to them later", because I never do...)

Ideological Purity is no substitute for being able to stick your thumb down a pipe to stop the water

Rahul Rajat Singh

I think the code is perfectly written. The developer must be a genius and realized why would i need a confirmation if the user has already choose to delete. So he placed an innocent looking message and a clever ; to achieve this. absolute genius I say. +5.

Every now and then say, "What the Elephant." "What the Elephant" gives you freedom. Freedom brings opportunity. Opportunity makes your future.

Pete OHanlon

As no one else has pointed it out, where were the unit tests? A comprehensive test would have picked this up long before.

*pre-emptive celebratory nipple tassle jiggle* - Sean Ewington

"Mind bleach! Send me mind bleach!" - Nagy Vilmos

CodeStash - Online Snippet Management | My blog | MoXAML PowerToys | Mole 2010 - debugging made easier

megaadam

Your tagline alone deserves a 5.

Life is too shor

Lost User

Pete O'Hanlon wrote:

As no one else has pointed it out, where were the unit tests? A comprehensive test would have picked this up long before.

Does scrum or agile have unit tests?

Michael Martin Australia "I controlled my laughter and simple said "No,I am very busy,so I can't write any code for you". The moment they heard this all the smiling face turned into a sad looking face and one of them farted. So I had to leave the place as soon as possible." - Mr.Prakash One Fine Saturday. 24/04/2004

Rage

So now you know why you should not ignore warnings in production code.

~RaGE();

I think words like 'destiny' are a way of trying to find order where none exists. - Christian Graus Do not feed the troll ! - Common proverb

BobJanova

Unit testing user interface is hard and generally missed out. Since the bug was actually in the line that checked the UI response I can see how this could easily slip through testing.

Pete OHanlon

Yes.

*pre-emptive celebratory nipple tassle jiggle* - Sean Ewington

"Mind bleach! Send me mind bleach!" - Nagy Vilmos

CodeStash - Online Snippet Management | My blog | MoXAML PowerToys | Mole 2010 - debugging made easier

BobJanova

I think we've all done something similar. But this is a compiler warning, certainly in C# (actually I think I remember it being so all the way back to the Zortech ANSI C compiler I used to use aged 10), so you should have caught it.

Pete OHanlon

And this is why I love working with MVVM and WPF - that wouldn't have been user interface code (and it didn't actually need to be there in this case either).

*pre-emptive celebratory nipple tassle jiggle* - Sean Ewington

"Mind bleach! Send me mind bleach!" - Nagy Vilmos

CodeStash - Online Snippet Management | My blog | MoXAML PowerToys | Mole 2010 - debugging made easier

BobJanova

Surely whatever framework you're using you're going to have a line like

if(DialogResult.Yes == MessageBox.Show( ... )){
modelView.DoDeleteRows(selectedRows);
}

... in the UI layer? User confirmation in the UI is part of the requirement here. If you screw up that line, which is what happened here, your model-view and model code can be as perfect and as tested as you like and you can still make this mistake.

Pete OHanlon

Nope. I'd use Dependency Injection to control the message box, so it would look something like this:

IMessageBoxService mbox = ServiceContainer.Resolve();
bool? result = mbox.Show("....")
if (result.HasValue && result)
{
DeleteRows();
}

There's no need to have a selecteRows property because this would have been handled with the binding.

*pre-emptive celebratory nipple tassle jiggle* - Sean Ewington

"Mind bleach! Send me mind bleach!" - Nagy Vilmos

CodeStash - Online Snippet Management | My blog | MoXAML PowerToys | Mole 2010 - debugging made easier

J4amieC

You;re right I read it wrong. I thought the OP was opening a custom Form.

ZurdoDev

The real question is how did that get out of development? Clearly no one actually tested it, right?

There are only 10 types of people in the world, those who understand binary and those who don't.

Bernhard Hiller

That's a pretty adequate programming style when you want to test your maintenance programmers. Hardly anyone will spot it.

KP Lee

I have to admit, it took me a short while to see it. I was verifying parenthesis while thinking the compiler would have blown up if you forgot one. Then I had to go "DOH!" too.

Adriaan Davel

Happened to me in c++ as a student, nearly gave up programming because of it :)

____________________________________________________________ Be brave little warrior, be VERY brave