Now this is embarassing

[Shao Voon Wong]

Add this comment before anyone notice your code!

// This embarrassing code is definitely not written by Gary Wheeler!
if (_Uptime != null)
{
_Uptime.Remove(TraCommon.Tokens.TraService_Speed);
}
{
_Uptime = new Service.Message();
_Uptime.Code = SysCommon.CommandCode.SysUptimeEvt;
}

:laugh:

[BobJanova]

Sadly, SVN will tell you that it really is ;(

[V 0]

Don't be too embarassed. It's quite normal[^]

V.
(MQOTD Rules and previous Solutions )

[User 7894920]

At the risk of starting a slashdot-style flame war I refuse to code an if without:

if (condition) {
consequence;
} else {
negative consequence;
}

Can't help it. Can't change it. 56 years old and too old to recover from it. But also pretty hard to miss an 'else'. Please don't hate me...

[Gary Wheeler]

Part of my problem is that, due to changes in style guidelines in my group over time, I have a body of older code that uses K&R braces. My newer stuff, including the aforementioned C#, uses the brace-per-line style.

Software Zen: delete this;

[Fabio Franco]

Gary Wheeler wrote:

It's been there for years.

Then it has been working for years too! Don't fix it!

To alcohol! The cause of, and solution to, all of life's problems - Homer Simpson ---- Our heads are round so our thoughts can change direction - Francis Picabia

[KP Lee]

Gary Wheeler wrote:

Mine was a sin of omission, while his was a sin of emission.

Someone mentioned in the other link that an empty statement shouldn't be allowed after an if statement. I think both should be allowed, but have warning messages. His would be "The conditional statement won't execute anything", yours "Extra brackets added for no apparent reason". Both may be a stretch for the compiler to see. On the other hand, people who like padded coding might not like that.

[KP Lee]

Thought I said "The conditional (if-else) statement won't execute anything" but I used the special characters (@lt; @or; >) that hid it and didn't look at my preview. Great, only gt works as substitution letters.

[User 3138470]

This reminds me why i hate ppl who write code like if (x != y) doThis(); remember one time when somebody added some code --> if (x != y) doThis(); alsoDoThat(); Took a while in debugger to figure out what was reason :-p Cause not part of my code :-) I always write my code after that if (x != y) { doThis(); } Even if have to do only one thing :-p

[Adriaan Davel]

I did this once in c++, took very long to figure out:

if (condition);
{

}

____________________________________________________________ Be brave little warrior, be VERY brave

[Michael Kingsford Gray]

Would have been obvious in VB.NET.

[AspDotNetDev]

Every line of code in VB.Net is obviously a mistake. ;P

Thou mewling ill-breeding pignut!

[greldak]

I'd be more concerned if there was something between the braces to get unexpectedly executed irrespective of the intended condition.

[Adriaan Davel]

That's exactly what happened, irrespective of the condition the code block always executed...

____________________________________________________________ Be brave little warrior, be VERY brave

[Frans_55129]

And I did this once in C, also took me long to figure it out: for (i=0; i <= ....; i ++); { }

[Gary R Wheeler]

Embarassing2A: We use SourceSafe. Embarassing2B: It would still tell you that it really is.

Software Zen: delete this;

[Gary R Wheeler]

That's usually the case for me as well.

Software Zen: delete this;

[Gary R Wheeler]

Actually, it's not. In the code you don't see, it ends up replacing existing information when it should be adding it. The existing information gets lost.

Software Zen: delete this;

[Fabio Franco]

I did notice that. What I meant is that the application was obviously working for years with that code, unless it's been abandoned. If it was behaving incorrectly it would've been noticed before. I'm not saying that what the code was doing was correct, just that the application was behaving as expected.

To alcohol! The cause of, and solution to, all of life's problems - Homer Simpson ---- Our heads are round so our thoughts can change direction - Francis Picabia

[Gary R Wheeler]

This is in a portion of the application that logs performance information for our field service organization. The bug caused part of the information to be recorded less often than it was available. The only way it would be noticed is if the folks doing the 'data mining' were paying really close attention, and they're not. Unfortunately.

Software Zen: delete this;