Hungarian UIs
-
Giving a variable name passwordString or something comparable is not Hungarian notation. The original intent with Hungarian notation was that a very short prefix would indicate HOW the variable was used, not the actual type of the variable. Thus dX meant delta-X, not that X is an integer. This was quickly perverted into a monstrosity. Name variables with meaningful names is to be encouraged, though in my style most abbreviations are discouraged. In UI programming, I often use Label/Checkbox or some suffix to distinguish controls from data. In C++, I still use Hungarian in three distinct cases: I put a 'p' in front of pointers since the semantics are dramatically different. I put 'h' in front of naked handles for a similar reason--if I see a variable prefixed with an 'h', there better be a CloseHandle or equivalent nearby (code-wise). I also put "m_" in front of class member variables. Oddly I don't do this in C# (except lately since my current peers insist on using the "_" prefix for member variables.)
So when you say you still use Hungarian in three cases, you are referring to the pre-monstrosity kind?
The difficult we do right away... ...the impossible takes slightly longer.
-
I think we can all agree that for the most part nobody uses Hungarian notation for variables any more... but it still seems prevalent in UI programming - for example I might have lblSomething next to txtSomething. On one hand I feel a bit uneasy that there must be some way to avoid this horrible practice, but on the other hand lblSomething is clearly meant to be a label which is next to txtSomething, and I need a way to differentiate between them without ending up with two controls with the same name. What say you? Disclaimer: I don't consider this to be a programming question, more a question of what styles people like to use.
I can't find it quickly but there was a good article posted here via the news feed (Insider News) that told a story, presumably true, as to what Hungarian was supposed to be for and what it got turned into and that they were vastly different. Anywho the Wikipedia article[^] might help, at least differentiating between System Hungarian and Apps Hungarian. Personally I tend to use the txtAge, lblAge, cmbGender, lblGender, cmdOK, cmdCancel etc. I am intrigued by the idea of switching to AgeTxt, AgeLbl, GenderCmb, GenderLbl, CancelCmd, OKCmd etc., might be better in at least some if not many places. Mike
-
Giving a variable name passwordString or something comparable is not Hungarian notation. The original intent with Hungarian notation was that a very short prefix would indicate HOW the variable was used, not the actual type of the variable. Thus dX meant delta-X, not that X is an integer. This was quickly perverted into a monstrosity. Name variables with meaningful names is to be encouraged, though in my style most abbreviations are discouraged. In UI programming, I often use Label/Checkbox or some suffix to distinguish controls from data. In C++, I still use Hungarian in three distinct cases: I put a 'p' in front of pointers since the semantics are dramatically different. I put 'h' in front of naked handles for a similar reason--if I see a variable prefixed with an 'h', there better be a CloseHandle or equivalent nearby (code-wise). I also put "m_" in front of class member variables. Oddly I don't do this in C# (except lately since my current peers insist on using the "_" prefix for member variables.)
Yes, I've read the Joel on Software article which explains the distinction, and agree in principle. In practice it's hard to get everyone on the team to go along with this... p for pointers makes sense, h for handles makes sense, m and underscore for member variables I change my mind on every few months - I dislike that there is a prefix in general, however the next alternative of caps/lower case first letter to distinguish feels equally smelly. I've actually got to the point of using automatic properties instead of backing fields mostly though so in newer framework versions this becomes less and less of an issue (using a private property may sound a bit wrong for what would have been a field, but that's an argument for another day)
-
c2423 wrote:
lblSomething is clearly meant to be a label which is next to txtSomething, and I need a way to differentiate between them without ending up with two controls with the same name
I do the same thing [insert](in WinForms code behind)[/insert] as I find it useful and it helps reduce coding errors. I have no qualms about using it. Also, it's strictly not Hungarian notation, since
lblandtxtare not primitive data types. /raviMy new year resolution: 2048 x 1536 Home | Articles | My .NET bits | Freeware ravib(at)ravib(dot)com
-
So when you say you still use Hungarian in three cases, you are referring to the pre-monstrosity kind?
The difficult we do right away... ...the impossible takes slightly longer.
I listed them; p, h and m_ (or _). The monstrosity kind were where you'd get a string of letters which must have meant something to someone, but which were now indecipherable. I once worked for a guy who insisted that 'i' be a prefix for integer and 'b' for byte/unsigned char, yet someone else on the team used 'n' and someone else 'd' and both used 'b' for bool, even if had ceased to be a BOOL (in the worse case, bool not only became an enum, but failure or false became -1.) PS. I suppose the most notorious example is WPARAM wParam which isn't a WORD at all. I realized that I do use lParam and wParam in this case, but mainly because when I want to know what's in the WPARAM, I know what to look for--the l and w prefixes have lost all meaning. It annoys me, though.
-
I can't find it quickly but there was a good article posted here via the news feed (Insider News) that told a story, presumably true, as to what Hungarian was supposed to be for and what it got turned into and that they were vastly different. Anywho the Wikipedia article[^] might help, at least differentiating between System Hungarian and Apps Hungarian. Personally I tend to use the txtAge, lblAge, cmbGender, lblGender, cmdOK, cmdCancel etc. I am intrigued by the idea of switching to AgeTxt, AgeLbl, GenderCmb, GenderLbl, CancelCmd, OKCmd etc., might be better in at least some if not many places. Mike
I didn't see the article - perhaps it was Joel on Software? http://www.joelonsoftware.com/articles/Wrong.html[^] I don't think AgeTxt etc is any better - you would win the point of saying "I don't use Hungarian notation", while doing something equally smelly. There is a suggestion above which is that you would have something like AgeInput or AgeEdit, which I quite like on the basis that it doesn't prescribe a particular implementation.
-
Making it a suffix means that related controls (i.e. all the things for FirstName) come together. Doing it 'properly' you have a single control, called firstName, which has the editor and the label and exposes the right properties. But UI usually doesn't work out like that, so you will have several controls relating to the same concept. You have to use the type to differentiate them, and a suffix seems better than a prefix to me.
-
Strictly speaking strings aren't primitive data types either, but it'd make my skin crawl to name a variable strXyz.
Ha! I wasn't advocating using (and do not use)
strXyz. :-D /raviMy new year resolution: 2048 x 1536 Home | Articles | My .NET bits | Freeware ravib(at)ravib(dot)com
-
Strictly speaking strings aren't primitive data types either, but it'd make my skin crawl to name a variable strXyz.
-
Giving a variable name passwordString or something comparable is not Hungarian notation. The original intent with Hungarian notation was that a very short prefix would indicate HOW the variable was used, not the actual type of the variable. Thus dX meant delta-X, not that X is an integer. This was quickly perverted into a monstrosity. Name variables with meaningful names is to be encouraged, though in my style most abbreviations are discouraged. In UI programming, I often use Label/Checkbox or some suffix to distinguish controls from data. In C++, I still use Hungarian in three distinct cases: I put a 'p' in front of pointers since the semantics are dramatically different. I put 'h' in front of naked handles for a similar reason--if I see a variable prefixed with an 'h', there better be a CloseHandle or equivalent nearby (code-wise). I also put "m_" in front of class member variables. Oddly I don't do this in C# (except lately since my current peers insist on using the "_" prefix for member variables.)
Joe Woodbury wrote:
Giving a variable name passwordString or something comparable is not Hungarian notation. The original intent with Hungarian notation was that a very short prefix would indicate HOW the variable was used, not the actual type of the variable. Thus dX meant delta-X, not that X is an integer
No. http://en.wikipedia.org/wiki/Hungarian_notation[^] "Simonyi's paper referred to prefixes used to indicate the "type" of information being stored" http://msdn.microsoft.com/en-us/library/aa260976%28v=vs.60%29.aspx[^] "Long, long ago in the early days of DOS, Microsoft's Chief Architect Dr. Charles Simonyi introduced an identifier naming convention that adds a prefix to the identifier name to indicate the functional type of the identifier."
-
Joe Woodbury wrote:
Giving a variable name passwordString or something comparable is not Hungarian notation. The original intent with Hungarian notation was that a very short prefix would indicate HOW the variable was used, not the actual type of the variable. Thus dX meant delta-X, not that X is an integer
No. http://en.wikipedia.org/wiki/Hungarian_notation[^] "Simonyi's paper referred to prefixes used to indicate the "type" of information being stored" http://msdn.microsoft.com/en-us/library/aa260976%28v=vs.60%29.aspx[^] "Long, long ago in the early days of DOS, Microsoft's Chief Architect Dr. Charles Simonyi introduced an identifier naming convention that adds a prefix to the identifier name to indicate the functional type of the identifier."
jschell wrote:
http://msdn.microsoft.com/en-us/library/aa260976%28v=vs.60%29.aspx[^]
"Long, long ago in the early days of DOS, Microsoft's Chief Architect Dr. Charles Simonyi introduced an identifier naming convention that adds a prefix to the identifier name to indicate the functional type of the identifier.""the functional type" Simonyi's paper makes this reasonably clear, though even he allowed some physical types to be represented. I believe the problem is that Simonyi was using "type" when he meant "usage" due, I believe, to English not being his first language. (I found it funny that he writes : "In closing, it is evident that the conventions participated in making the code more correct, easier to write, and easier to read. Naming conventions cannot guarantee good code, however; only the skill of the programmer can." When, for me at least, his example is nearly indecipherable and not clear at all.)
-
I think we can all agree that for the most part nobody uses Hungarian notation for variables any more... but it still seems prevalent in UI programming - for example I might have lblSomething next to txtSomething. On one hand I feel a bit uneasy that there must be some way to avoid this horrible practice, but on the other hand lblSomething is clearly meant to be a label which is next to txtSomething, and I need a way to differentiate between them without ending up with two controls with the same name. What say you? Disclaimer: I don't consider this to be a programming question, more a question of what styles people like to use.
-
I can't find it quickly but there was a good article posted here via the news feed (Insider News) that told a story, presumably true, as to what Hungarian was supposed to be for and what it got turned into and that they were vastly different. Anywho the Wikipedia article[^] might help, at least differentiating between System Hungarian and Apps Hungarian. Personally I tend to use the txtAge, lblAge, cmbGender, lblGender, cmdOK, cmdCancel etc. I am intrigued by the idea of switching to AgeTxt, AgeLbl, GenderCmb, GenderLbl, CancelCmd, OKCmd etc., might be better in at least some if not many places. Mike
txtSomething is better than SomethingTxt IMHO, because when I type and want to pull up a control name with IntelliSense I always know the kind of control I will be looking up, but might not remember the actual variable name. So I type txt... and pick the control name from the popped list.
-
I think we can all agree that for the most part nobody uses Hungarian notation for variables any more... but it still seems prevalent in UI programming - for example I might have lblSomething next to txtSomething. On one hand I feel a bit uneasy that there must be some way to avoid this horrible practice, but on the other hand lblSomething is clearly meant to be a label which is next to txtSomething, and I need a way to differentiate between them without ending up with two controls with the same name. What say you? Disclaimer: I don't consider this to be a programming question, more a question of what styles people like to use.
Think a big reason that it has disappeared is that display space is not as valuable. There was also the issue of calling something strName, well Name is probably going to be a string anyway, so sort of redundant. In the case of UI there is more TextBoxName vs txtName.
-
I think we can all agree that for the most part nobody uses Hungarian notation for variables any more... but it still seems prevalent in UI programming - for example I might have lblSomething next to txtSomething. On one hand I feel a bit uneasy that there must be some way to avoid this horrible practice, but on the other hand lblSomething is clearly meant to be a label which is next to txtSomething, and I need a way to differentiate between them without ending up with two controls with the same name. What say you? Disclaimer: I don't consider this to be a programming question, more a question of what styles people like to use.
Interesting question... When it is up to me, I dabbled fairly recently to using ux as a prefix for all GUI controls - and not naming any controls that don't require a name. So I would have uxCustomerName and uxCustomerNameLabel assuming both were referenced in code somewhere. Makes it obvious which variables belong to the GUI, keeps label and control variables adjacent alphabetically, allows me to change from a text box to a combo without any bother of renaming. But old habits die hard and I still find myself using txtCustomerName!
MVVM# - See how I did MVVM my way ___________________________________________ Man, you're a god. - walterhevedeich 26/05/2011 .\\axxx (That's an 'M')
-
I think we can all agree that for the most part nobody uses Hungarian notation for variables any more... but it still seems prevalent in UI programming - for example I might have lblSomething next to txtSomething. On one hand I feel a bit uneasy that there must be some way to avoid this horrible practice, but on the other hand lblSomething is clearly meant to be a label which is next to txtSomething, and I need a way to differentiate between them without ending up with two controls with the same name. What say you? Disclaimer: I don't consider this to be a programming question, more a question of what styles people like to use.
c2423 wrote:
lblSomething is clearly meant to be a label which is next to txtSomething
Exactly. What else are ya gonna do? And there's this: Making Wrong Code Look Wrong[^]
-
I think we can all agree that for the most part nobody uses Hungarian notation for variables any more... but it still seems prevalent in UI programming - for example I might have lblSomething next to txtSomething. On one hand I feel a bit uneasy that there must be some way to avoid this horrible practice, but on the other hand lblSomething is clearly meant to be a label which is next to txtSomething, and I need a way to differentiate between them without ending up with two controls with the same name. What say you? Disclaimer: I don't consider this to be a programming question, more a question of what styles people like to use.
c2423 wrote:
it still seems prevalent in UI programming - for example I might have lblSomething next to txtSomething.
Yes I still use it for controls but not for variables any more.
The report of my death was an exaggeration - Mark Twain
Simply Elegant Designs JimmyRopes Designs
Think inside the box! ProActive Secure Systems
I'm on-line therefore I am. JimmyRopes -
jschell wrote:
http://msdn.microsoft.com/en-us/library/aa260976%28v=vs.60%29.aspx[^]
"Long, long ago in the early days of DOS, Microsoft's Chief Architect Dr. Charles Simonyi introduced an identifier naming convention that adds a prefix to the identifier name to indicate the functional type of the identifier.""the functional type" Simonyi's paper makes this reasonably clear, though even he allowed some physical types to be represented. I believe the problem is that Simonyi was using "type" when he meant "usage" due, I believe, to English not being his first language. (I found it funny that he writes : "In closing, it is evident that the conventions participated in making the code more correct, easier to write, and easier to read. Naming conventions cannot guarantee good code, however; only the skill of the programmer can." When, for me at least, his example is nearly indecipherable and not clear at all.)
Joe Woodbury wrote:
Simonyi's paper makes this reasonably clear,
Yes it does. From that paper (Table 4.) "b Byte, not necessarily holding a coded character, more akin to w." Are you suggesting that "b" is used to represent something besides the data type of the variable from the above phrase?
-
Joe Woodbury wrote:
Simonyi's paper makes this reasonably clear,
Yes it does. From that paper (Table 4.) "b Byte, not necessarily holding a coded character, more akin to w." Are you suggesting that "b" is used to represent something besides the data type of the variable from the above phrase?
jschell wrote:
Are you suggesting that "b" is used to represent something besides the data type of the variable from the above phrase?
Read the damn paper. The b is an exception to his use of notation to indicate the usage of a variable. You are deliberately ignoring the other tables which are blindingly clear. Look at table 2 and table 3. Even table 4 save for two damn rows. Then read his whole damn discussion on the color red. What does "co" stand for? Simonyi states: "As suggested above, the concept of "type" in this context is determined by the set of operations that can be applied to a quantity."
-
I think we can all agree that for the most part nobody uses Hungarian notation for variables any more... but it still seems prevalent in UI programming - for example I might have lblSomething next to txtSomething. On one hand I feel a bit uneasy that there must be some way to avoid this horrible practice, but on the other hand lblSomething is clearly meant to be a label which is next to txtSomething, and I need a way to differentiate between them without ending up with two controls with the same name. What say you? Disclaimer: I don't consider this to be a programming question, more a question of what styles people like to use.
It seems obvious that these two controls belong together. So it makes sense to group them in a single class "LabeledText", having two fields: "Something.Label" and "Something.Text". With the added benefit that the class can automatically enforce coherence of the two controls.
