Skip to content
  • Categories
  • Recent
  • Tags
  • Popular
  • World
  • Users
  • Groups
Skins
  • Light
  • Cerulean
  • Cosmo
  • Flatly
  • Journal
  • Litera
  • Lumen
  • Lux
  • Materia
  • Minty
  • Morph
  • Pulse
  • Sandstone
  • Simplex
  • Sketchy
  • Spacelab
  • United
  • Yeti
  • Zephyr
  • Dark
  • Cyborg
  • Darkly
  • Quartz
  • Slate
  • Solar
  • Superhero
  • Vapor

  • Default (No Skin)
  • No Skin
Collapse
Code Project
  1. Home
  2. The Lounge
  3. Testers coding bug fixes directly?

Testers coding bug fixes directly?

Scheduled Pinned Locked Moved The Lounge
helpdesignquestiondiscussion
74 Posts 35 Posters 3 Views 1 Watching
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • Z ZurdoDev

    Quote:

    As this person gets more confident they'll try and tackle bigger problems

    That is certainly a possibility but we should hesitate to be so bold in our assumptions. Heck, in one of my jobs we didn't even have QA. When I was doing asp we did the changes right on the production server sometimes. :)

    There are only 10 types of people in the world, those who understand binary and those who don't.

    J Offline
    J Offline
    JimmyRopes
    wrote on last edited by
    #25

    RyanDev wrote:

    Heck, in one of my jobs we didn't even have QA. When I was doing asp we did the changes right on the production server sometimes.

    I worked in a place like that. What a mess. :suss:

    The report of my death was an exaggeration - Mark Twain
    Simply Elegant Designs JimmyRopes Designs
    I'm on-line therefore I am. JimmyRopes

    Z 1 Reply Last reply
    0
    • F Forogar

      Who QA's the QAs? There's a Latin version of that isn't there?

      - I would love to change the world, but they won’t give me the source code.

      N Offline
      N Offline
      Nicholas Marty
      wrote on last edited by
      #26

      You mean:

      Quote:

      Quis custodiet ipsos custodes

      (Basically translates to "Who will guard the guards themselves?") :)

      1 Reply Last reply
      0
      • M Munchies_Matt

        mark merrens wrote:

        One day he'll fix something he really doesn't understand.

        "So far it's restricted to typos/grammar mistakes in hard-coded string UI messages and that type of thing" Plain English? Come on. Don't be silly.

        "The whole idea that carbon dioxide is the main cause of the recent global warming is based on a guess that was proved false by empirical evidence during the 1990s." climate-models-go-cold

        G Offline
        G Offline
        greldak
        wrote on last edited by
        #27

        I hope you don't have any quick fixes in the code that you haven't been allowed to fix properly because no-one will approve a change that doesn't add any visible value and which rely on those hard coded strings

        M 1 Reply Last reply
        0
        • J jeron1

          I have to agree with Mark Merrens on this one, nothing good can come of this. As this person gets more confident they'll try and tackle bigger problems which brings greater risks. It could be just as easy as documenting what he thinks should be changed and give it to you, then you could dole the work out after aa number on them have been received. If the fixes are indeed easy, it should just take a couple of minutes for the dev team (the people who could perhaps see the bigger picture) to fix.

          B Offline
          B Offline
          BobJanova
          wrote on last edited by
          #28

          jeron1 wrote:

          If the fixes are indeed easy, it should just take a couple of minutes for the dev team (the people who could perhaps see the bigger picture) to fix.

          And probably an order of magnitude more minutes in people's time to assign a ticket number, approve it into a development cycle, estimate it and account for it in the project plan, etc.

          1 Reply Last reply
          0
          • K Kieryn Phipps

            So I'm a dev manager and our QC lead who is gaining proficiency in coding, though is by no means even a junior programmer has taken it upon himself to directly fix some easy bugs. This is certainly a faster way to get things fixed as our dev resources are severely limited. So far it's restricted to typos/grammar mistakes in hard-coded string UI messages and that type of thing. Good or bad? Thoughts?

            B Offline
            B Offline
            BobJanova
            wrote on last edited by
            #29

            I think it's okay as long as the bug fix is not signed off by the person that fixes it, and the tester knows his limits when it comes to coding.

            J 1 Reply Last reply
            0
            • B BobJanova

              I think it's okay as long as the bug fix is not signed off by the person that fixes it, and the tester knows his limits when it comes to coding.

              J Offline
              J Offline
              JimmyRopes
              wrote on last edited by
              #30

              BobJanova wrote:

              and the tester knows his limits when it comes to coding.

              What coder knows his limits? :~

              The report of my death was an exaggeration - Mark Twain
              Simply Elegant Designs JimmyRopes Designs
              I'm on-line therefore I am. JimmyRopes

              1 Reply Last reply
              0
              • K Kieryn Phipps

                So I'm a dev manager and our QC lead who is gaining proficiency in coding, though is by no means even a junior programmer has taken it upon himself to directly fix some easy bugs. This is certainly a faster way to get things fixed as our dev resources are severely limited. So far it's restricted to typos/grammar mistakes in hard-coded string UI messages and that type of thing. Good or bad? Thoughts?

                S Offline
                S Offline
                SortaCore
                wrote on last edited by
                #31

                It should be fine if it's only UI messages - if they're kept outside of variables. Such as a messagebox with a fixed caption, or a constant variable. Otherwise you risk coding problems such as "I'll just change the text that's passed to this strcpy()... oops." "I'll just change the text in this char[26]... oops." If the changes they make are under version control the coder could always review them. The thing is, if they do break it, they can just hide behind "I'm not a programmer"... quite legitimately.

                J J 2 Replies Last reply
                0
                • P Pete OHanlon

                  Quid arsos qual arsolium It roughly translates to "which arse let him touch the code"?

                  G Offline
                  G Offline
                  Gary Wheeler
                  wrote on last edited by
                  #32

                  "Benefits of a classical education."     - Hans Gruber

                  Software Zen: delete this;

                  J 1 Reply Last reply
                  0
                  • G Gary Wheeler

                    "Benefits of a classical education."     - Hans Gruber

                    Software Zen: delete this;

                    J Offline
                    J Offline
                    JimmyRopes
                    wrote on last edited by
                    #33

                    Gary Wheeler wrote:

                    "Benefits of a classical education."

                    You can converse in a dead language. :~

                    The report of my death was an exaggeration - Mark Twain
                    Simply Elegant Designs JimmyRopes Designs
                    I'm on-line therefore I am. JimmyRopes

                    G M 2 Replies Last reply
                    0
                    • S SortaCore

                      It should be fine if it's only UI messages - if they're kept outside of variables. Such as a messagebox with a fixed caption, or a constant variable. Otherwise you risk coding problems such as "I'll just change the text that's passed to this strcpy()... oops." "I'll just change the text in this char[26]... oops." If the changes they make are under version control the coder could always review them. The thing is, if they do break it, they can just hide behind "I'm not a programmer"... quite legitimately.

                      J Offline
                      J Offline
                      JimmyRopes
                      wrote on last edited by
                      #34

                      SortaCore wrote:

                      if they do break it, they can just hide behind "I'm not a programmer

                      When you change code you have just become a programmer. Alternatively, if you are not a programmer why did you change the code?

                      The report of my death was an exaggeration - Mark Twain
                      Simply Elegant Designs JimmyRopes Designs
                      I'm on-line therefore I am. JimmyRopes

                      S 1 Reply Last reply
                      0
                      • J JimmyRopes

                        Gary Wheeler wrote:

                        "Benefits of a classical education."

                        You can converse in a dead language. :~

                        The report of my death was an exaggeration - Mark Twain
                        Simply Elegant Designs JimmyRopes Designs
                        I'm on-line therefore I am. JimmyRopes

                        G Offline
                        G Offline
                        Gary Wheeler
                        wrote on last edited by
                        #35

                        :sigh: [^] Children don't know the classics any longer.

                        Software Zen: delete this;

                        J 1 Reply Last reply
                        0
                        • J JimmyRopes

                          SortaCore wrote:

                          if they do break it, they can just hide behind "I'm not a programmer

                          When you change code you have just become a programmer. Alternatively, if you are not a programmer why did you change the code?

                          The report of my death was an exaggeration - Mark Twain
                          Simply Elegant Designs JimmyRopes Designs
                          I'm on-line therefore I am. JimmyRopes

                          S Offline
                          S Offline
                          SortaCore
                          wrote on last edited by
                          #36

                          JimmyRopes wrote:

                          When you change code you have just become a programmer.

                          Not something I agree with. I might be able to fix a car, but I don't become a mechanic from doing that. Or whack a nail into a plank of wood and become a "DIY guy". Code to me is the mechanics of the program, not the UI wording. When a program goes multi-language, it'll probably end up with separate language files anyway, which don't contain any code, just variants of UI text; so surely changing that text would make you a programmer, since it affected the program? Heck, you could draw a new icon file and change the program. And if it's embedded into the application, you've just changed the machine code. Congrats on your new job title.

                          J 1 Reply Last reply
                          0
                          • S SortaCore

                            JimmyRopes wrote:

                            When you change code you have just become a programmer.

                            Not something I agree with. I might be able to fix a car, but I don't become a mechanic from doing that. Or whack a nail into a plank of wood and become a "DIY guy". Code to me is the mechanics of the program, not the UI wording. When a program goes multi-language, it'll probably end up with separate language files anyway, which don't contain any code, just variants of UI text; so surely changing that text would make you a programmer, since it affected the program? Heck, you could draw a new icon file and change the program. And if it's embedded into the application, you've just changed the machine code. Congrats on your new job title.

                            J Offline
                            J Offline
                            JimmyRopes
                            wrote on last edited by
                            #37

                            If you are not a programmer why did you change the code? :doh:

                            The report of my death was an exaggeration - Mark Twain
                            Simply Elegant Designs JimmyRopes Designs
                            I'm on-line therefore I am. JimmyRopes

                            S 1 Reply Last reply
                            0
                            • G Gary Wheeler

                              :sigh: [^] Children don't know the classics any longer.

                              Software Zen: delete this;

                              J Offline
                              J Offline
                              JimmyRopes
                              wrote on last edited by
                              #38

                              But can you say "Yippee-ki-yay, motherfucker!" in Latin? :-D

                              The report of my death was an exaggeration - Mark Twain
                              Simply Elegant Designs JimmyRopes Designs
                              I'm on-line therefore I am. JimmyRopes

                              G 1 Reply Last reply
                              0
                              • J JimmyRopes

                                But can you say "Yippee-ki-yay, motherfucker!" in Latin? :-D

                                The report of my death was an exaggeration - Mark Twain
                                Simply Elegant Designs JimmyRopes Designs
                                I'm on-line therefore I am. JimmyRopes

                                G Offline
                                G Offline
                                Gary Wheeler
                                wrote on last edited by
                                #39

                                According to Google translate: Yippee KI videri enim dicuntur haec matris fututor :laugh:

                                Software Zen: delete this;

                                J 1 Reply Last reply
                                0
                                • J JimmyRopes

                                  If you are not a programmer why did you change the code? :doh:

                                  The report of my death was an exaggeration - Mark Twain
                                  Simply Elegant Designs JimmyRopes Designs
                                  I'm on-line therefore I am. JimmyRopes

                                  S Offline
                                  S Offline
                                  SortaCore
                                  wrote on last edited by
                                  #40

                                  Changing the interface, not the code. As in my example, if there was an icon file separate in the project, but embedded when the program was produced, a graphics designer could freely change the icon without being told he "changed the code" or that he's a coder.

                                  J 1 Reply Last reply
                                  0
                                  • S SortaCore

                                    Changing the interface, not the code. As in my example, if there was an icon file separate in the project, but embedded when the program was produced, a graphics designer could freely change the icon without being told he "changed the code" or that he's a coder.

                                    J Offline
                                    J Offline
                                    JimmyRopes
                                    wrote on last edited by
                                    #41

                                    Apparently the QA person is taking more liberty than just changing icons. (S)he is changing variables, albeit hard coded ones that probably should not have been, which can have unexpected consequences.

                                    The report of my death was an exaggeration - Mark Twain
                                    Simply Elegant Designs JimmyRopes Designs
                                    I'm on-line therefore I am. JimmyRopes

                                    S 1 Reply Last reply
                                    0
                                    • G Gary Wheeler

                                      According to Google translate: Yippee KI videri enim dicuntur haec matris fututor :laugh:

                                      Software Zen: delete this;

                                      J Offline
                                      J Offline
                                      JimmyRopes
                                      wrote on last edited by
                                      #42

                                      You "matris fututor" you. :-D

                                      The report of my death was an exaggeration - Mark Twain
                                      Simply Elegant Designs JimmyRopes Designs
                                      I'm on-line therefore I am. JimmyRopes

                                      1 Reply Last reply
                                      0
                                      • J JimmyRopes

                                        Apparently the QA person is taking more liberty than just changing icons. (S)he is changing variables, albeit hard coded ones that probably should not have been, which can have unexpected consequences.

                                        The report of my death was an exaggeration - Mark Twain
                                        Simply Elegant Designs JimmyRopes Designs
                                        I'm on-line therefore I am. JimmyRopes

                                        S Offline
                                        S Offline
                                        SortaCore
                                        wrote on last edited by
                                        #43

                                        Ah, I did say "outside of variables" in my post. Changing variables is definitely inviting trouble. I agree with you on that point.

                                        J 1 Reply Last reply
                                        0
                                        • K Kieryn Phipps

                                          So I'm a dev manager and our QC lead who is gaining proficiency in coding, though is by no means even a junior programmer has taken it upon himself to directly fix some easy bugs. This is certainly a faster way to get things fixed as our dev resources are severely limited. So far it's restricted to typos/grammar mistakes in hard-coded string UI messages and that type of thing. Good or bad? Thoughts?

                                          M Offline
                                          M Offline
                                          Michael Haines
                                          wrote on last edited by
                                          #44

                                          Everyone's responses against so far have been a bunch of "What Ifs" (or clever cliches in Latin). What if allowing the QA to fix a typo brings the project in a day early, and the Dev Manager gets a nice huge bonus? What if a developer changes something he/she really doesn't understand and delays the project for weeks? Separation of responsibility is a nice guideline, but exceptions almost always prove the rule. Who's QA'ing the QA? Hopefully, the dev manager is. You may have guessed that I am a dev manager. "I am rarely happier than when spending entire day programming my computer to perform automatically a task that it would otherwise take me a good ten seconds to do by hand." - Douglas Adams

                                          J D 2 Replies Last reply
                                          0
                                          Reply
                                          • Reply as topic
                                          Log in to reply
                                          • Oldest to Newest
                                          • Newest to Oldest
                                          • Most Votes


                                          • Login

                                          • Don't have an account? Register

                                          • Login or register to search.
                                          • First post
                                            Last post
                                          0
                                          • Categories
                                          • Recent
                                          • Tags
                                          • Popular
                                          • World
                                          • Users
                                          • Groups