Is this an acceptable practice?
-
Please ask in the proper forum.
The report of my death was an exaggeration - Mark Twain
Simply Elegant Designs JimmyRopes Designs
I'm on-line therefore I am. JimmyRopesFor lazing about and discussing anything in a software developer's life that takes your fancy. The Lounge is rated PG. If you're about to post something you wouldn't want your kid sister to read then don't post it. No flame wars, no abusive conduct and please don't post ads. This tickles my fancy.
-
Its valid code. Coding practices is the topic.
-
Indeed.
-
I have yet to find a compiler that has to support and maintain the code it compiles.
A guide to posting questions on CodeProject
How to debug small programs
Dave KreskowiakVisual Studio 2013 for windows 8.1 apps
-
For lazing about and discussing anything in a software developer's life that takes your fancy. The Lounge is rated PG. If you're about to post something you wouldn't want your kid sister to read then don't post it. No flame wars, no abusive conduct and please don't post ads. This tickles my fancy.
Colborne_Greg wrote:
This tickles my fancy.
You conveniently left out:
Quote:
Technical discussions are welcome, but if you need specific help please use the programming forums.
The difficult we do right away... ...the impossible takes slightly longer.
-
Colborne_Greg wrote:
This tickles my fancy.
You conveniently left out:
Quote:
Technical discussions are welcome, but if you need specific help please use the programming forums.
The difficult we do right away... ...the impossible takes slightly longer.
I DO NOT NEED HELP Quit behaving like you know what the fook is going on. THE QUESTION IS - is this an acceptable practice, please learn to read English before getting on my case.
-
Visual Studio 2013 for windows 8.1 apps
And what does that have to do with what I said??
A guide to posting questions on CodeProject
How to debug small programs
Dave Kreskowiak -
I DO NOT NEED HELP Quit behaving like you know what the fook is going on. THE QUESTION IS - is this an acceptable practice, please learn to read English before getting on my case.
Your question will only get opinions for an answer. The answer all depends on who you ask. I hate it because it isn't explicit. It requires you to know how the compiler is going to behave.
A guide to posting questions on CodeProject
How to debug small programs
Dave Kreskowiak -
And what does that have to do with what I said??
A guide to posting questions on CodeProject
How to debug small programs
Dave KreskowiakThat's the compiler and libraries used for the code.
-
Your question will only get opinions for an answer. The answer all depends on who you ask. I hate it because it isn't explicit. It requires you to know how the compiler is going to behave.
A guide to posting questions on CodeProject
How to debug small programs
Dave KreskowiakIt is only one line of code, broken into multiple lines via the _ character.
<System.Runtime.Serialization.DataMember>
Private mLastUpdated As DateTime, mLastUpdatedBy As String, mClearanceRequired As Int64, mClearanceIsRequired As Boolean -
That's the compiler and libraries used for the code.
Considering I wasn't commenting on that at all, your post makes no sense. I was merely commenting that the compiler is never responsible for supporting the application, YOU are.
A guide to posting questions on CodeProject
How to debug small programs
Dave Kreskowiak -
It is only one line of code, broken into multiple lines via the _ character.
<System.Runtime.Serialization.DataMember>
Private mLastUpdated As DateTime, mLastUpdatedBy As String, mClearanceRequired As Int64, mClearanceIsRequired As BooleanSo what? It seems like you're doing this and your looking for absolution from the community. Again, it's a matter of opinion and in a real environment with coding standards, what you've done may be outlawed.
A guide to posting questions on CodeProject
How to debug small programs
Dave Kreskowiak -
<System.Runtime.Serialization.DataMember>
Private mLastUpdated As DateTime, _
mLastUpdatedBy As String, _
mClearanceRequired As Int64, _
mClearanceIsRequired As BooleanVisual basic code; class members for serialization - declaring a group of variables as data members.
I don't see any problem with it, as a matter of fact it actually reminds me of C++ member declaration.
To alcohol! The cause of, and solution to, all of life's problems - Homer Simpson ---- Our heads are round so our thoughts can change direction - Francis Picabia
-
<System.Runtime.Serialization.DataMember>
Private mLastUpdated As DateTime, _
mLastUpdatedBy As String, _
mClearanceRequired As Int64, _
mClearanceIsRequired As BooleanVisual basic code; class members for serialization - declaring a group of variables as data members.
"It is a vessel of fertilizer, and none may abide its strength."
Did you ever see history portrayed as an old man with a wise brow and pulseless heart, waging all things in the balance of reason? Is not rather the genius of history like an eternal, imploring maiden, full of fire, with a burning heart and flaming soul, humanly warm and humanly beautiful? --Zachris Topelius Training a telescope on one’s own belly button will only reveal lint. You like that? You go right on staring at it. I prefer looking at galaxies. -- Sarah Hoyt
-
<System.Runtime.Serialization.DataMember>
Private mLastUpdated As DateTime, _
mLastUpdatedBy As String, _
mClearanceRequired As Int64, _
mClearanceIsRequired As BooleanVisual basic code; class members for serialization - declaring a group of variables as data members.
At a first glance, I find this confusing. In particular because the DataMember attribute actually accepts a constructor parameter. - So if I set the constructor parameter, which field does it apply to? - Likewise, if you want to switch out serializers and use something like Protocol Buffers this syntax simply won't translate. You would need to break out each one as the constructor is required. - On top of this all, there's a mixing of types. I'm not a big fan of the "multi-declaration" syntax, especially when it doesn't save any actual lines like this example. But there are some cases where it is useful. That stated, if you're mixing types on the "multi-declarations", it's time split them out. I wouldn't call this "unacceptable" practice, especially in the context of firing someone over this. I would however call this "non-standard" and "confusing" and ask that it be changed.
-
Its valid code. Coding practices is the topic.
Colborne_Greg wrote:
Coding practices is the topic
Coding practices are a form of communication to the next developer to assist them in their understanding of the code. There are no absolutes -- a syntax acceptable to one group might not be acceptable to another group. In general though, use of an oddball syntax in one place in the code is a poor practice. So, the only realistic answer to your question is "it depends". It depends on whether that's the common syntax used throughout the rest of the code, or an oddball one.
Colborne_Greg wrote:
Its valid code
I have three words by way of countering this line of thought: Obfuscated C Contest.
We can program with only 1's, but if all you've got are zeros, you've got nothing.
-
Colborne_Greg wrote:
Coding practices is the topic
Coding practices are a form of communication to the next developer to assist them in their understanding of the code. There are no absolutes -- a syntax acceptable to one group might not be acceptable to another group. In general though, use of an oddball syntax in one place in the code is a poor practice. So, the only realistic answer to your question is "it depends". It depends on whether that's the common syntax used throughout the rest of the code, or an oddball one.
Colborne_Greg wrote:
Its valid code
I have three words by way of countering this line of thought: Obfuscated C Contest.
We can program with only 1's, but if all you've got are zeros, you've got nothing.
I keep a common structure, thank you for a straight answer.
-
At a first glance, I find this confusing. In particular because the DataMember attribute actually accepts a constructor parameter. - So if I set the constructor parameter, which field does it apply to? - Likewise, if you want to switch out serializers and use something like Protocol Buffers this syntax simply won't translate. You would need to break out each one as the constructor is required. - On top of this all, there's a mixing of types. I'm not a big fan of the "multi-declaration" syntax, especially when it doesn't save any actual lines like this example. But there are some cases where it is useful. That stated, if you're mixing types on the "multi-declarations", it's time split them out. I wouldn't call this "unacceptable" practice, especially in the context of firing someone over this. I would however call this "non-standard" and "confusing" and ask that it be changed.
This is what it looked like before
<System.Runtime.Serialization.DataMember>
Private mLastUpdated As DateTime<System.Runtime.Serialization.DataMember> Private mLastUpdatedBy As String <System.Runtime.Serialization.DataMember> Private mClearanceRequired As Int64 <System.Runtime.Serialization.DataMember> Private mClearanceIsRequired As BooleanThe first example I wrote, stands on in the document, where writing datamember so many times with the word private seems to be a waste of space.
-
"It is a vessel of fertilizer, and none may abide its strength."
Did you ever see history portrayed as an old man with a wise brow and pulseless heart, waging all things in the balance of reason? Is not rather the genius of history like an eternal, imploring maiden, full of fire, with a burning heart and flaming soul, humanly warm and humanly beautiful? --Zachris Topelius Training a telescope on one’s own belly button will only reveal lint. You like that? You go right on staring at it. I prefer looking at galaxies. -- Sarah Hoyt
Refrain for abusive comments
-
I don't see any problem with it, as a matter of fact it actually reminds me of C++ member declaration.
To alcohol! The cause of, and solution to, all of life's problems - Homer Simpson ---- Our heads are round so our thoughts can change direction - Francis Picabia
right on
